From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAB2837B002 for ; Thu, 16 Apr 2026 23:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776383799; cv=none; b=DyomeTnyEqr/wmS0IgRyu7xQyuxsEkidKXqRKksiAH/1j5AtsAVWZ6Fepa7KqAeCYFjFbAyRaayHYcNpSxMB8x40panBvQnRHp69xlmNPEJYxOtzDsGm5ho3CCsdOpKNOpIOfknitZNn5kBxjeHkLOfDQvcYx0gBDqe5L3QeIXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776383799; c=relaxed/simple; bh=ck2VJ/zWj05Aj+s8teEzGH5V1VeifG8sD7WLckVzR7g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GRS+I1SYtr8dk5CPX/+HqJosVhTP7w2yF0Q4FTp1uCxoO10XGEfr8F5TdZ/oKn7hWHUrjMsoutpnt7rCUExSNLJdbAvTZytcjxJIZ2/Ysz7z1CQqwgO5OiPK6CXpYr0GS9xiuzO5UT2lQb5CKKJAJtkc8GXomANPOGFVF49+pJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JSMBAsn+; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JSMBAsn+" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8d424af6282so12420385a.0 for ; Thu, 16 Apr 2026 16:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776383796; x=1776988596; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=muSutUnQ3k1ov/G6xk5xkScEVtLMLhqZsYl6TyAiBqw=; b=JSMBAsn+1VaoqWRtZ83iE/1/wHxCPomKlzwRjm5TyyqNMlniARgMLXKlVwCdDDvAUi GbiiFcxfIWXqKTf9ziBsdykiP+M/ZUYgmA+kgBwxg8lw7ZcEIA2snA5b6dp3rkbwAUpr LgV6VmAJ9UAJPUA9A43+66ALBRGh/+E4gXwwySK0gX/2saQG0q3oWcYjyS+h6dmOjhsl JYjyCGP+7JgtzPNvw9D7gavx3R0s3J7ClYyvbFmmg2F5JRrNblvIVFKWX9E8tgOMY7mv ka9kHJJOOs7Q+W4BGjQ8fk/HHgO2GZt+FeH/JLojpQIqs8VSLT94BldsmT0iigI8Nii1 cCFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776383796; x=1776988596; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=muSutUnQ3k1ov/G6xk5xkScEVtLMLhqZsYl6TyAiBqw=; b=DdA9BOK9hqHyMWz2gDGptHfnLiujpYgwnYkgVYad87xW7q+cVqtfvco9erkeZO0ui0 BHb00teswStYLGyNbY9w+B6g0Ble3oq/mwOu+2cl5AjWZpWYhCBN5EW4YX/TOhuELi11 IcZ/0382CSIWFbKjUtq+B+a7Vst8TTvgkygCjrZKwWol20mankliZv6t1oy3HvIir95q r82rB1Jq1B2myULsZQLy7C4Ktb5KkQnzN5Id1s4wESp815XhdFJS5HQPrKIzTnG46SsI 4NoTBOy6t7u1bbiZPKXeXG+NuTGLTmIaY5kRovn5yhyOxjxI0qHu+yiYvGpSn4BqFanZ MePA== X-Gm-Message-State: AOJu0Yx2x33BINMhmCVh0ixPqRlIjkf78X0AHp8BoyYFsMQyZVX1ECK4 tqGuEVjEuZ8+6hR9uoqhkeqgSnld3H/UBvmdccQcvoCto9OQZJc5WBTC X-Gm-Gg: AeBDieuWSSKl9zKfI6qe8UXU1XaMC7ZaMTb/zsgGeXhPlgrYjb5mfzk2Owfz8Lro48n GZwZgN/OcLfjmT2dIjGnEqLUSRi+0s+dZ1w2mAXqQ5AzJ5TuQu1/F5yMsdJWPHTQ5j/N2mVoeak dAq2nIs9IP7lo1dzpEzJE2KABTYLGXbGw2a9qZ395Q7h99j+iJI8Z0sbHBHPBp0yMMOoBEXJ6RO XjeivjAMVP5zfxDdBxuWn0hyTnajTfEt1o89c4d6Wv+sLvRkONupFdvHoWUJimFqdiWNEc4tl+9 xdqQbsYLynV+BBOFhPhmiFX1wV0UTYJwtnoSscU/SLAOA0rT62Q/056UJJrmbgplKjTgx8MJ3f8 s0grzy1zyEMBAhgD2ZTzbQxe3oXIelN1xVXqHHJ/1i4QHxUsQGRz8hnmRJ9kq/egdrvv8se1k7O eIkcMTsKvR5AeCyKFjxT25113xnpX32/fiBPSaVLB9eS8OfLHlktuN49CET1M= X-Received: by 2002:a05:620a:469e:b0:8e7:8067:5bbb with SMTP id af79cd13be357-8e7917a9fdbmr72219685a.40.1776383795589; Thu, 16 Apr 2026 16:56:35 -0700 (PDT) Received: from d5-mxc5484.ad.psu.edu ([165.85.209.69]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e7b036d9afsm8756385a.18.2026.04.16.16.56.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 16:56:35 -0700 (PDT) From: Yuho Choi To: Mark Brown , Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich Cc: linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, Yuho Choi Subject: [PATCH v1] regmap: ram: fix memory leaks in __regmap_init_ram() on error Date: Thu, 16 Apr 2026 19:56:30 -0400 Message-ID: <20260416235630.78408-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Two allocations in __regmap_init_ram() are not cleaned up on failure. If the kzalloc_objs() for data->written fails, data->read is returned with no way for the caller to free it. If __regmap_init() fails, neither data->read nor data->written is freed because its error paths do not call bus->free_context() (which is regmap_ram_free_context() here). Only regmap_exit() does, and that is never reached on an init failure. Free the allocated arrays before returning any error. Fixes: f6352424e37e ("regmap: Add RAM backed register map") Signed-off-by: Yuho Choi --- drivers/base/regmap/regmap-ram.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap-ram.c b/drivers/base/regmap/regmap-ram.c index 0272d53fead11..c7356b0d8c832 100644 --- a/drivers/base/regmap/regmap-ram.c +++ b/drivers/base/regmap/regmap-ram.c @@ -71,11 +71,17 @@ struct regmap *__regmap_init_ram(struct device *dev, return ERR_PTR(-ENOMEM); data->written = kzalloc_objs(bool, config->max_register + 1); - if (!data->written) + if (!data->written) { + kfree(data->read); return ERR_PTR(-ENOMEM); + } map = __regmap_init(dev, ®map_ram, data, config, lock_key, lock_name); + if (IS_ERR(map)) { + kfree(data->read); + kfree(data->written); + } return map; } -- 2.50.1 (Apple Git-155)