From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9E5F28F5; Fri, 17 Apr 2026 16:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442645; cv=none; b=e0OU0A7LR8WPYIARlk6mZSU7PPkxMJN/Ad9/BEUG4H6k27S9SWjuN3WjB+tCJS27no9YNdp1g1jpGARki1HYKB5r4Xt8RuljXg6A7Z5kofnwN1d6w7gCKTBPEPUyh74QvPFu2CApc97mepkIdGHIO6ISi1hnkowqU3R/bAbgKOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442645; c=relaxed/simple; bh=8apwD0Uu49O9/L0RV1+lQTrPxFIZu8qTAZBBQWMysOU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hvPvWFd1MaAYA2815HzY7O25NiZq2TUuQo/jp35r/AKeIPz575pbtdXXeRQ+V0YZhC2pr6DeWOhXI5Gj27mNkiXEHEvU7bQHfzOmlkZeMyDqAkU+4BhndM6GdOU7zFn64J3Xl4htpjwHLV5KhU/qno0+HmF36uhAlUbaMeXpKxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X4huMo5t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X4huMo5t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75FFCC19425; Fri, 17 Apr 2026 16:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776442645; bh=8apwD0Uu49O9/L0RV1+lQTrPxFIZu8qTAZBBQWMysOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X4huMo5tVUupfqMqLJvJbvXWZepfaZuz0/fPjHxbWIcVpykF+xdD98DT0MVjPhftq Ib6dq2Jx2LjHcQPhXRJavO8y0KAv3jY/DY1bvhlU4Ne2Z2slSeCGsRsoqL3UXZ/Iyo vLerK9pH3UVJq/NwDmk6WgNtE1nFLGsg+jp9ajWZkZ25yfaqsvkYNENWgkaw6IGHan X1DH6gjj5fkKsV4i9RT2bIz2yGMLFrJCgEoa0a/UUOSKRKKuTdEBj0sNdCb4l64QjS dhnS/MdTFZUzqemm/Buxvhk5gl+2a9MnzD7U4uzgmU/vQJHCTAdKYG5o73Tbtwv3ES Q2uxD8ul0csHw== Date: Fri, 17 Apr 2026 17:17:21 +0100 From: Conor Dooley To: Caleb James DeLisle Cc: linux-mips@vger.kernel.org, naseefkm@gmail.com, daniel.lezcano@kernel.org, tglx@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: timer: econet: Update EN751627 for multi-IRQ Message-ID: <20260417-outlet-ascent-eefba2a4aa19@spud> References: <20260416175101.958073-1-cjd@cjdns.fr> <20260416175101.958073-2-cjd@cjdns.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ahSFO216kMteIe+a" Content-Disposition: inline In-Reply-To: <20260416175101.958073-2-cjd@cjdns.fr> --ahSFO216kMteIe+a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 16, 2026 at 05:51:00PM +0000, Caleb James DeLisle wrote: > From conception, this driver supported EN751627 as it is the same > hardware that is used in EN751221. However, it was expected that > EN751627 would use a percpu IRQ as does EN751221, this is how it > works in vendor code. However upon finding that the "mti,gic" intc > works on EN751627 with no modification - but it provides a unique > interrupt per-timer, it is deemed best to make this driver use > multiple IRQs when on the EN751627 platform. Please drop mention of drivers here, bindings are about hardware, whether or not the driver uses 1 or 4 interrupts doesn't matter, the binding should have 4 because the hardware has 4. pw-bot: changes-requested Otherwise, this looks fine, so with that stuff culled Acked-by: Conor Dooley >=20 > Signed-off-by: Caleb James DeLisle > --- > .../bindings/timer/econet,en751221-timer.yaml | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/timer/econet,en751221-time= r.yaml b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml > index c1e7c2b6afde..f338739e039c 100644 > --- a/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml > +++ b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml > @@ -28,8 +28,8 @@ properties: > maxItems: 2 > =20 > interrupts: > - maxItems: 1 > - description: A percpu-devid timer interrupt shared across CPUs. > + minItems: 1 > + maxItems: 4 > =20 > clocks: > maxItems: 1 > @@ -52,21 +52,31 @@ allOf: > items: > - description: VPE timers 0 and 1 > - description: VPE timers 2 and 3 > + interrupts: > + description: An interrupt for each timer (one per VPE) > + minItems: 4 > else: > properties: > reg: > items: > - description: VPE timers 0 and 1 > + interrupts: > + description: A percpu-devid timer interrupt shared across time= rs > + maxItems: 1 > =20 > additionalProperties: false > =20 > examples: > - | > + #include > timer@1fbf0400 { > compatible =3D "econet,en751627-timer", "econet,en751221-timer"; > reg =3D <0x1fbf0400 0x100>, <0x1fbe0000 0x100>; > interrupt-parent =3D <&intc>; > - interrupts =3D <30>; > + interrupts =3D , > + , > + , > + ; > clocks =3D <&hpt_clock>; > }; > - | > --=20 > 2.39.5 >=20 --ahSFO216kMteIe+a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaeJdEQAKCRB4tDGHoIJi 0hSOAQCaJODtAPQb5wGy//l8xDIYl60EXO9mwMqpJ7jVMXy+CwEAvkrqwFkte9qD UOZywla/ZGFA1/MhHGy7LTAp0dwhuQ8= =EmxE -----END PGP SIGNATURE----- --ahSFO216kMteIe+a--