From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F3D53B27CA for ; Fri, 17 Apr 2026 09:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776419524; cv=none; b=d1sKgVgiwp3+nyodXR9c14yhiqjC9EoeE8djaJdx8Cp0p1IGLwTbPC+bKWOAr1nvU9Wg5exq3Cn374y5slh1e1nLEjutPtfnAAaBzgusABn+BUdeSokoLIKbK0idbtDznaLGbF15crJ+LjIce54r4YAX/II9X+jkOUtAwdYVS5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776419524; c=relaxed/simple; bh=8j2fuJ/CobaU+zoZaxoI8vwpmOcljoawjn8zh+K7DA8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KT2q5VgQAJyT627Zve8zhWF2ab4dDrthslvlBSeu9VA1ibuAnVJtAvvC4dnjBP/AxV6V72T/ZX7F3+F2QKjSkwNRxfdP/zlfIi0gu5jUiWInxetES2OdKItFgu1YC67YMotTftiSPEgTDjRjUhlm0t5zyr0H8jvcLF/Hl3bA8WU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P3myjRFl; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P3myjRFl" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43fde5b81a1so330987f8f.0 for ; Fri, 17 Apr 2026 02:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776419520; x=1777024320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6McsDPyH8QnKBdehE+9TN+kQ+OgryRDimxxkla2LXI0=; b=P3myjRFlDNYaIJcuPntW7P1uEaaCgT+sler6bmZzWGe30eo3qJamQTg0Mvorwm8WPU Q1KlIGPdjuVFcQF77BFGyLR7mX8gXDa5tobVzf8nYCaLZc50UVLWEF3hjSVMHaxhiVzR KsaJ2TG7X9GyKfEJc31XZdOkXrvIGWxYn6S7/S0HitRFxBsPOr4DLEWnlX6EOWLN9RBL L5AZl+4ht9+JoPquhqiyAqU9d8ruPoOoy7VR/3R22Y65PG2/FT99faN/W38b/QhxcCfj a6T3J0y+Tg59ulcjgIg5P4W83PMh3kmXGpkXhaVc81CAEZPhSMrs1P0at3lnqf42gSnf 6kJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776419520; x=1777024320; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6McsDPyH8QnKBdehE+9TN+kQ+OgryRDimxxkla2LXI0=; b=hQ9X43Ua8UdgCKP+w1aUd/PTSXeMgXwzakFWZKHUyIKWroiyPjHYUg8wfbARgF4ZNJ qku4+Fog/YJbqv7iPSKRyfhaomDFELxdb9uLbOjrJiBLwUzL8FHSh0yptYnueoAy6ls8 ZO2co0YhDCCWN8Pekhq+FwM44NZn8RWxEL7MpuYOCDHvMWVZ8cYVyDGsKUT8+9nf4lXZ 4fSHfTzkAi1KCYRr/B3E8MgXau2alDvT5/sxnL7jeD+FaU0ClNj8XT89qC2xnQsRwDFj 70pGpIZeRgNXaBV1sBnFsFKwE6A8p1Z2eYaLb91GUYUPdGqxiWojBRinkVQXomPv1u9s YROQ== X-Forwarded-Encrypted: i=1; AFNElJ9lUz+kd0BRiwcNJL/fGHvu+xacmhbayNrdCvhZi/gNUMFC1JZ8aV9Wo+twYCd54ZFCwbo3e2G5o4ZZkcw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3Qoa8gfS4b1BPzPoD+lzc7Wg1Z/n3865Pjanob82cGobfj2Km yikbHDCuV6xdcho4HrMfLIndv4UTkDT88+H5wIy6ygesyYaRSKoPN0dC X-Gm-Gg: AeBDieuX5YMQ6x1Tj68K8Y0S8jOSU35D0TzDmwwgyk7urdEfWqgRDgX+4Yh4XhlxKV0 1+oZ9NRs2Zlq794TbPMAPiM3TX2FnIOGk+M8KTDg2391otBvmlNQeyG2/+Ifs76wEO6x8XOzNKw iUONZRw5ngHr7u7ubci/lkfNfktanEf97JRJF68NEDmeHnL9/kNB6J5pQP1oMBXr3bsb7FoUN0e x5I5aVSrhO/2/rPEYwCkOW728r5HSQQakkBSxvgety1MNFkd884AwEf5UWVJT7lWAcP3QlcxJoS ++YIl8jZTkpuRzQFV2pU69MshJJM9kMT81HDP2ZC3u5otGC3jK0LfglMGVrt6kNIcEGZc2Myb8y mBhW7AiG9v0Y17GFq4Ds+FohZC6nlt6EcSEqhNW2igsCX5NlerIzTau7HmagD23Tsb5zZnMT+pf AiLOzG+pJI5YEdnDAdTR/fxGIBoNHv X-Received: by 2002:a05:6000:1acd:b0:43b:4aba:8f38 with SMTP id ffacd0b85a97d-43fe3e14242mr3173828f8f.47.1776419519622; Fri, 17 Apr 2026 02:51:59 -0700 (PDT) Received: from moxi ([178.134.243.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb1365sm3356783f8f.7.2026.04.17.02.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 02:51:59 -0700 (PDT) From: Maksym Pikhotskyi To: gregkh@linuxfoundation.org, error27@gmail.com, ethantidmore06@gmail.com, starpt.official@gmail.com, straube.linux@gmail.com, sameekshasankpal@gmail.com, arthur.stupa@gmail.com, luka.gejak@linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Maksym Pikhotskyi Subject: [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Date: Fri, 17 Apr 2026 13:51:18 +0400 Message-ID: <20260417095119.22948-1-mpikhotskyi@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The null-pointer-guard was incorrect, returning _FAIL on valid pointer. Invert the guard, so it returns _FAIL on invalid pointer. Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check") Reported-by: Luka Gejak Closes: https://lore.kernel.org/linux-staging/E4BF62EF-C6F6-431F-8EDC-77C1E613E66B@linux.dev/ Reviewed-by: Dan Carpenter Signed-off-by: Maksym Pikhotskyi --- v2: rebase on staging-next. Split into a series of patches. v3: add Reported-by, Closes and Reviewed-by tags. --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index a00504ff2910..f467cb5b1dca 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -1212,7 +1212,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe) if (prxattrib->encrypt != _AES_) return _SUCCESS; stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]); - if (stainfo) + if (!stainfo) return _FAIL; if (is_multicast_ether_addr(prxattrib->ra)) { static unsigned long start; -- 2.51.0