From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 469D03B19CA for ; Fri, 17 Apr 2026 09:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776419804; cv=none; b=nyv5VfqyzXDtJVA+bZZNSgekM2T4J250KWzq3kKYgGqqeM035v74/QB3UykVDwa5VoqkMUE/+Qphjcy+nMKNep3M2J3eeqGGxlakY5geb82b7N6+hQyasxZkfQ3WFFoDx7cS1sE5YPffE5kYsEHDDtYkofsLtDCtTbj6ze7AGZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776419804; c=relaxed/simple; bh=8j2fuJ/CobaU+zoZaxoI8vwpmOcljoawjn8zh+K7DA8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Una9IAvJujIAJl91CVSMAK94l9uwrnlf9L3qBxMoxtm26kZhbXNeLL3dR07rXVthfpcU7niMmMwPJJJnMD6SAesg/rNooL6yDtgZIW5O6vC+IRl+tOsCK1ZBLDj/OEmg2ejWjqnpVSfSYWVPXIbR46DCh089anBudzPAX/p3fgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HvjXwORR; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HvjXwORR" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43cfd832155so343564f8f.1 for ; Fri, 17 Apr 2026 02:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776419802; x=1777024602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6McsDPyH8QnKBdehE+9TN+kQ+OgryRDimxxkla2LXI0=; b=HvjXwORRpL4QSpJU0hU8OVW5KEeZkVtO+yQOD5oDQcGup62jHYAqOCErnoC8Ww9su/ aDGAefoii5E1qWmaCVLQJ8WdEdCqazvvtLvqk+5MIpRhjW8a1IkECCR/F0HsUqsSwmxQ NttO4BWK4+8MN6Jhia2QQ36MSZO4Hbg1XcA4/GMw7TG1z86MAAaofTeSK+7aPzx8mNtM MHOVanl4DxzPVLPaXgYbtwgkL0zFx2EqteauM37TsdxSqNdmmvVZei0AypHN4fbzrgJU UobBU1Jfr6Lqo4CavKIDLdxduqjUqNJ2c8740fMs/6OGMinC3Cdf/4p0GXb9WHI5H0aQ 18xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776419802; x=1777024602; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6McsDPyH8QnKBdehE+9TN+kQ+OgryRDimxxkla2LXI0=; b=M6KlI7zhsAX0oKs5g4K0QNnErDiYXzs6CYzL+/eUqNO18oD1e8kiU186Ex+mItAFyU mVYEEsS9dtp85ZNWgbWgyK82OdWuXFviTVBPxhaG28vxbI5wK7GFUTijz9wshCk++1wT bUQSyoxzmiayoKfFUXlzCcFgKHLCExsEQeOo64z4mFParrsCIhWGK8xLUUwTG1lqq0ZJ /pfT19k99+6TXuTnYaMyymMMs1TPcYtPyyhQ7Dn7tKR2/TjXYCT8NgJ7yFfjNnqT8ORw eoqA3LJ45/x+rmRDtz+pjz13kZOFZGXTL9KeCT/tfJ9CtBZlIRLIgVJ3PQUUdDUiCRMb 5jcQ== X-Forwarded-Encrypted: i=1; AFNElJ9qFrpE8ji6/dMzktAy+ZNGSdqooH/OeGd8+k+A1m26enWxf4o5kbf2MLb9ahoc6KqUsX3KE0Lnc6OUgQk=@vger.kernel.org X-Gm-Message-State: AOJu0YzaoVAqnWNju3yzoBFSlSfJzluhdquqToEl0G56LRYPelw1Z3rO Wq3be8oKGtkwPzi4DzzszLzRlNDlEA4GiXaksdACO/AED7MQuR6uR1HO X-Gm-Gg: AeBDieuvqQF67AmrWdTgjAkydet4xsUg/7sjGzTsKvvVWHdULixPagbnloIuhhALUUE yyxXyKF0+qxD4cI1rryjmC6I8jTg1EXcm+O2uIdUKEOoXllSY1/FCImCEj3WV7eZXesRI2RSCu3 7xyU9KHzdv35FmXtZFAT42WnCJ+0WqsTiNWmnQuNX0cAeQH+js5XMvdgXg0htTJWvSXnRjgxrh+ 89tmNMuLrnWfQUHHZS1NWNGmqsEbNquAdaz4+bzYFzLaHonTnmI25/vbm5jVI8hNIEpcIasw6C7 jg86eDmbz5MhYHK2PyV0kXyy7nS6jowPiRay7wGecn5qWUSh693O3B4IhNzMmn9u9evcohj/cIu 9vmIXQt4FtQqH3gIMkQDFn9hxNuvA2m8MRcyXkyYjRB6ImFKHiOJq1AnlRk7GFVzKplPyU7e8OM 8KAS/u6y6Ta+KN3prBqvoSKS1fce2Ykuc6iAIrdhs= X-Received: by 2002:a5d:64e7:0:b0:43d:50c:6f18 with SMTP id ffacd0b85a97d-43fe3dc37e6mr3243017f8f.11.1776419801590; Fri, 17 Apr 2026 02:56:41 -0700 (PDT) Received: from moxi ([178.134.243.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a166sm3454917f8f.19.2026.04.17.02.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 02:56:41 -0700 (PDT) From: Maksym Pikhotskyi To: gregkh@linuxfoundation.org, error27@gmail.com, ethantidmore06@gmail.com, starpt.official@gmail.com, straube.linux@gmail.com, sameekshasankpal@gmail.com, arthur.stupa@gmail.com, luka.gejak@linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Maksym Pikhotskyi Subject: [PATCH v3 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Date: Fri, 17 Apr 2026 13:54:51 +0400 Message-ID: <20260417095452.23440-1-mpikhotskyi@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The null-pointer-guard was incorrect, returning _FAIL on valid pointer. Invert the guard, so it returns _FAIL on invalid pointer. Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check") Reported-by: Luka Gejak Closes: https://lore.kernel.org/linux-staging/E4BF62EF-C6F6-431F-8EDC-77C1E613E66B@linux.dev/ Reviewed-by: Dan Carpenter Signed-off-by: Maksym Pikhotskyi --- v2: rebase on staging-next. Split into a series of patches. v3: add Reported-by, Closes and Reviewed-by tags. --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index a00504ff2910..f467cb5b1dca 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -1212,7 +1212,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe) if (prxattrib->encrypt != _AES_) return _SUCCESS; stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]); - if (stainfo) + if (!stainfo) return _FAIL; if (is_multicast_ether_addr(prxattrib->ra)) { static unsigned long start; -- 2.51.0