From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE27394787 for ; Fri, 17 Apr 2026 12:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430197; cv=none; b=H6oNRhpJmJBXHV4ZcmJFuje4ir9K0kVXTeySebnmPGqFKxy7faXo6l26DBKfgBHK9RdmnWxpACrk3Lkks7Ewjz0yt4YF0+6YCRLxnQhoGDwV6rOt6Omk6fOviuKSMpMFsJ29GuwsI3ZREaocBQuckQiooAK5tWgDW9Gn+8UOIwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776430197; c=relaxed/simple; bh=tnK53EaNGIBDfxbMBE4Ggz3ws+Vp5qfLWDMmlxLbTkM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BW4OiojwVGPj+POiytLiySwW9/D1110jvA+h2rgBoz+iZ9ytT+8xc0GeT7ZLgeCyzwG2zlaGnH8iVwC612PCx8J2H8i8lKgp61xpXxHMjKWdESxgnGOivj2pGXekv5PmMpXbShO18Rv3Yl77ezHk1tdaCiBNmVf2K1q//wVeonk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eMyEaOZj; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eMyEaOZj" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so216998a12.3 for ; Fri, 17 Apr 2026 05:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776430196; x=1777034996; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XnRZcX1V5Mt/WiCCq9xYJmYuZ/r7Obi0LyG4op6I5lM=; b=eMyEaOZjBv1zdiemUC++B5YWJChQRD13zT9nF6VnXkZ9Ygd9/k00Vp7s3192rIj01U Thh0LZ4V/E4PM1OSCPcAAtrg/YXDb1WkxtGmteBVk1zWwcBp2jtLXKy298fua1iqbQ9V UQi1e0c/QhLslUy8pAuZhkSeu460utVT3YtOU5Ozy5jVlsBSY84dwW48kLrx278nig7n 5BemLmYiMA/F3pkZ74Bjl8UnY6vR0kWtpeaad3V+gJjCFSq67GhgP8nszPWYxR5ECoHG 5XaF66H32O62k9bLMPB5gZRZFolD3zVwMwSPcEksAfn+ELDP2rGGfKlF/F8RrV6NxpSS B7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776430196; x=1777034996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XnRZcX1V5Mt/WiCCq9xYJmYuZ/r7Obi0LyG4op6I5lM=; b=I9lJxEpusO+ibaEyXgTS6vwTFmoNZSM50+NmIykAyb7PwVNRFg267d0fssI3Vc3Eep SHreBDknmfZCKke8oHGG/vx2fc0JyHaW/UmZPLOTgb0PEOlzTR7rUOL7BevF13BTu/ZX KfBg1uiaBEDzmPfZHwHJPVqY/QNXYyyzEwJ9p4AIU6vq96jTJ4clnmT+LsinTzjDaRil 5oMCtt/HOCRTShFKpEWwGVUJLiuK1cqz5zn9u9fPYTOOr7PW8wvLt2Edfgy9uCDjHgwB s+wf+Yn7rwPUtFa76c2YtH/2ZC6QOy6uy7NL8xxICDUXQdSOEhLcTN4f8WjYDKne8yYg 0IKA== X-Forwarded-Encrypted: i=1; AFNElJ+6xiOV97kJCd2ZfAYExVh6zwKZPj0q18Cpr8yXWQ5gO9695/ZQ2xvqK3s+4xVJR/WYhuGt9ax8/JLdPNc=@vger.kernel.org X-Gm-Message-State: AOJu0YwF8JWByB0Iv9xuqOAgLwOlv+e7HYoFdW6lOl8Mnyq3GnJigesI S8e0QNZ5ILcpBPo5j+D9+/vAEEahw0PgASCsg5DF+yjGcsbc66eNCipG X-Gm-Gg: AeBDieuge7Q4W5YUo63xCY2+LVWQOgP2y7tQOVwnSHCzmnnuoqDWR10HIYI2i109GJY ngFWf6Y99IM3kNdjXnPjggQTUI7EVX3xHGr1vo0uEkX2dn36ecLa4U2J9zgy1YveliaF8uAjRGF b7ZIUSJIshjIuJk0Bm8qhjcZO6ognYmkxjv9MJqFGIBi6xYnxc87VQUkIWJr/q2ZvGQIwQ1HZlC phq9W+WqNXU7jvA6L5+I2KkKVOC9CDAsIwHy+639l2h1PWZt33Cff4QKQUYptoEliIEC++JEQUZ o5DY16ysgXu83Ek6RDMKd7ci3BAp0G7AEDoSSHstrF5qKFh+ipIYvACPN1SBColPCa16McnaKAN ZJ6QxFvZwjZq//4X9rAKh75twgeXYfbUeZAolA3zKQ+AVLoVa7NExiIofS7+bhggl1orONw1vAo PDnH+AtXVVsOFmmZn0mVV8ZgeHzu/gaD80CA1Rp6kVQBW9chF77XhfKEKQtpU= X-Received: by 2002:a17:903:bd2:b0:2b2:ccfb:8387 with SMTP id d9443c01a7336-2b5f9f534d9mr23127615ad.28.1776430195669; Fri, 17 Apr 2026 05:49:55 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cb92sm19428855ad.50.2026.04.17.05.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 05:49:55 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, puranjay@kernel.org, cosmin.tanislav@analog.com, marcelo.schmitt@analog.com, antoniu.miclaus@analog.com, ramona.gradinariu@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/8] iio: accel: adxl355: Use dev_err_probe Date: Fri, 17 Apr 2026 18:19:21 +0530 Message-Id: <20260417124924.353189-6-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260417124924.353189-1-sanjayembedded@gmail.com> References: <20260417124924.353189-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handles deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl355_core.c | 24 ++++++++---------------- drivers/iio/accel/adxl355_i2c.c | 11 ++++------- drivers/iio/accel/adxl355_spi.c | 11 ++++------- 3 files changed, 16 insertions(+), 30 deletions(-) diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c index a310f8e37e3d..03e5744d9667 100644 --- a/drivers/iio/accel/adxl355_core.c +++ b/drivers/iio/accel/adxl355_core.c @@ -336,10 +336,8 @@ static int adxl355_setup(struct adxl355_data *data) return ret; do { - if (--retries == 0) { - dev_err(data->dev, "Shadow registers mismatch\n"); - return -EIO; - } + if (--retries == 0) + return dev_err_probe(data->dev, -EIO, "Shadow registers mismatch\n"); /* * Perform a software reset to make sure the device is in a consistent @@ -775,10 +773,8 @@ static int adxl355_probe_trigger(struct iio_dev *indio_dev, int irq) irq); ret = devm_iio_trigger_register(data->dev, data->dready_trig); - if (ret) { - dev_err(data->dev, "iio trigger register failed\n"); - return ret; - } + if (ret) + return dev_err_probe(data->dev, ret, "iio trigger register failed\n"); indio_dev->trig = iio_trigger_get(data->dready_trig); @@ -814,18 +810,14 @@ int adxl355_core_probe(struct device *dev, struct regmap *regmap, indio_dev->available_scan_masks = adxl355_avail_scan_masks; ret = adxl355_setup(data); - if (ret) { - dev_err(dev, "ADXL355 setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "ADXL355 setup failed\n"); ret = devm_iio_triggered_buffer_setup(dev, indio_dev, &iio_pollfunc_store_time, &adxl355_trigger_handler, NULL); - if (ret) { - dev_err(dev, "iio triggered buffer setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "iio triggered buffer setup failed\n"); irq = fwnode_irq_get_byname(dev_fwnode(dev), "DRDY"); if (irq > 0) { diff --git a/drivers/iio/accel/adxl355_i2c.c b/drivers/iio/accel/adxl355_i2c.c index 1a512c7b792b..19490a6e1f35 100644 --- a/drivers/iio/accel/adxl355_i2c.c +++ b/drivers/iio/accel/adxl355_i2c.c @@ -23,6 +23,7 @@ static const struct regmap_config adxl355_i2c_regmap_config = { static int adxl355_i2c_probe(struct i2c_client *client) { struct regmap *regmap; + struct device *dev = &client->dev; const struct adxl355_chip_info *chip_data; chip_data = i2c_get_match_data(client); @@ -30,14 +31,10 @@ static int adxl355_i2c_probe(struct i2c_client *client) return -ENODEV; regmap = devm_regmap_init_i2c(client, &adxl355_i2c_regmap_config); - if (IS_ERR(regmap)) { - dev_err(&client->dev, "Error initializing i2c regmap: %ld\n", - PTR_ERR(regmap)); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "Error initializing i2c regmap\n"); - return PTR_ERR(regmap); - } - - return adxl355_core_probe(&client->dev, regmap, chip_data); + return adxl355_core_probe(dev, regmap, chip_data); } static const struct i2c_device_id adxl355_i2c_id[] = { diff --git a/drivers/iio/accel/adxl355_spi.c b/drivers/iio/accel/adxl355_spi.c index 869e3e57d6f7..347ed62b6582 100644 --- a/drivers/iio/accel/adxl355_spi.c +++ b/drivers/iio/accel/adxl355_spi.c @@ -26,6 +26,7 @@ static const struct regmap_config adxl355_spi_regmap_config = { static int adxl355_spi_probe(struct spi_device *spi) { const struct adxl355_chip_info *chip_data; + struct device *dev = &spi->dev; struct regmap *regmap; chip_data = spi_get_device_match_data(spi); @@ -33,14 +34,10 @@ static int adxl355_spi_probe(struct spi_device *spi) return -EINVAL; regmap = devm_regmap_init_spi(spi, &adxl355_spi_regmap_config); - if (IS_ERR(regmap)) { - dev_err(&spi->dev, "Error initializing spi regmap: %ld\n", - PTR_ERR(regmap)); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "Error initializing spi regmap\n"); - return PTR_ERR(regmap); - } - - return adxl355_core_probe(&spi->dev, regmap, chip_data); + return adxl355_core_probe(dev, regmap, chip_data); } static const struct spi_device_id adxl355_spi_id[] = { -- 2.34.1