From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA4613603DB; Fri, 17 Apr 2026 12:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429964; cv=none; b=UGvbGXdin9AXkGaI/GFzZTZsjvdW8zq7RxQ0yBT8PpeLYtbyjV+E1YXWf6cG3kib4oRmPR/wEAhRjONLP/XZlXA5XXc1dwyi4MwPYmqg/BcPYPQFZuLB9O4Ny5ZltbEGDVE9XPL/MjiXZVrYyMOHQXnJY1hVU6DSu+kFRv0WSvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429964; c=relaxed/simple; bh=oBQ6wgddlC5wjnSYNdFLni+25iwY2tcuuIozOYsNtjc=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k733sxR4Yg/i7IUnAlh4wjmXH2ewq8gNIruYe8C707PP0IeO/aRK/QoetS92PS3Nbz/WKR7B8dD5Lm87cidpy+jzga+r2IqLd+fHlLnkhvV+i1aVdA75jVywuFipyggVsG+D+X9mdsUXVd96/VhXf12X6rCKf+XUspwsZi/pjjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.224.83]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4fxvjY3p38zJ46Cf; Fri, 17 Apr 2026 20:45:05 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id EC77240577; Fri, 17 Apr 2026 20:45:51 +0800 (CST) Received: from localhost (10.203.86.132) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 17 Apr 2026 13:45:51 +0100 Date: Fri, 17 Apr 2026 13:45:50 +0100 From: Jonathan Cameron To: "Pradhan, Sanman" CC: "yangyicong@hisilicon.com" , "alexander.shishkin@linux.intel.com" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "yangyccccc@gmail.com" , Sanman Pradhan , Sizhe Liu Subject: Re: [PATCH v2 0/2] hwtracing: hisi_ptt: Fix reset timeout handling and clean up trace start Message-ID: <20260417134550.0000027c@huawei.com> In-Reply-To: <20260414172451.14331-1-sanman.pradhan@hpe.com> References: <20260414172451.14331-1-sanman.pradhan@hpe.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500011.china.huawei.com (7.191.174.215) To dubpeml500005.china.huawei.com (7.214.145.207) On Tue, 14 Apr 2026 17:25:03 +0000 "Pradhan, Sanman" wrote: > From: Sanman Pradhan +CC Sizhe Liu > > Patch 1: Propagate the DMA reset timeout error from > hisi_ptt_wait_dma_reset_done() instead of discarding it. De-assert > the reset bit and log an error on timeout. Move ctrl->started to the > successful path so a failed start does not leave the trace marked as > active. > > Patch 2: Remove the unnecessary 16 MiB memset of trace buffers in > hisi_ptt_trace_start(). The driver only copies data that hardware has > written, so the zeroing is not needed. > > Changes since v1: > - Patch 1: Return bool from hisi_ptt_wait_dma_reset_done() for > consistency with the other wait helpers > - Patch 1: Add pci_err() on timeout > - Patch 1: De-assert RST before returning on timeout > - Patch 1: Move ctrl->started to the successful path > - Dropped "Use the passed buffer index in hisi_ptt_update_aux()" patch > - Patch 2 is unchanged > > Sanman Pradhan (2): > hwtracing: hisi_ptt: Propagate DMA reset timeout in trace_start() > hwtracing: hisi_ptt: Remove unnecessary trace buffer zeroing in > trace_start() > > drivers/hwtracing/ptt/hisi_ptt.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) >