From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20F5733F597 for ; Fri, 17 Apr 2026 16:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442128; cv=none; b=qA76ZXlwsPlUZr3gHZfJ20g/aRVOfv1EKh7sWVNbtNqs/xcLKSyZwxW9/8QriYUZ2dzcgz2akEeTHx0xML6q9Qosf9S0+Oca84oyJ0rstXbXDm3wUPbCovJUKwIjtnOzA2M7z3X9/8osdtZX9y/PuPgLabjraTaQBSOsegJoMmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442128; c=relaxed/simple; bh=elMH0A5dNUucHdQlYYF5w5q0pFGSO2M0Cmf8V51xFME=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=coPFEvJ3niUztdz5hL8nxLf3Rwy1j1yz/zMb8EUiU5h1ypDJiP8oUrNA9N5LNrmqr8jIFnOlbbLzFDI1EODD56TXcxXlnhArwApX2GE2kWVBs9wmDBaG1s4HtYvLRtR1q9nfaBAg0pBoBF3xjZJQ2Z69gWai4O+CSVwnfAXuyZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J860zpSR; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J860zpSR" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a9296b3926so5213315ad.1 for ; Fri, 17 Apr 2026 09:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776442126; x=1777046926; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=q8LPcx1HdbjW6CgkoN9QPSPuGiSccz6Lmi6jP/IIhHw=; b=J860zpSR4hMDRcd3HwPRq73iwF7DlKDpVsTHBVIrgFUzQdbAg2q5McbnwK+rxkneS5 rFPHrcfJhwcvKr+hQpo3THyfwWy7gsL9nyUNT/gvBPGGnhWGsNxuFTopNgP4Yxzk7HfA D52aIZzPpPm15bPgaR1HuL8cbAdBPzBBEsGuC29WGhPYQnBa6zTjr6/HVWpzAijlcDHm R/VV0jsR4E6giShMZpyd0sb/PO0VyGEH7BV2dBjekpxWP8EfZAx/PaR28KbUZw66LbFx FUbe9Iktf7eOYKc88ISpSVPLWrCTZppF14wJTt0WyqOsPrZiocedoGJqvXXzzwzurg7P bSHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776442126; x=1777046926; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q8LPcx1HdbjW6CgkoN9QPSPuGiSccz6Lmi6jP/IIhHw=; b=PcbNUgmLWMA5P98hjflQ5/k5HQk6FVQUKA2UE9mNtaDanvsd4VPRKpoHI6ybvfRN+M E59IblyYB9spOKG0Udly+KSwxLLN55klo4fes3vCc66YFvdUqhUfDieAQmaXgS0GLg4v 8kjh1/l6ATTWRwu0+1tUOKdErgnV0u1JOlTuSIvggpLIYiA4znukcbke/zl0XfEy5yAi PO4qWASIft21EGfS/1ibw15n/thpTQzgN2xQ+h/ZNQub2ILu7h+Cld/bO725SNYLck7j Yad5BADLZXdrYUxJ7AGl/cM598y9z3Ox08aJJLA+/4RZQ1okGTTbQDaDv7AUiOin4Yta L5kw== X-Forwarded-Encrypted: i=1; AFNElJ8JqyUbHu2P9AxcUBqdX/1pknq6ZJ58TAAbVoTV7lQdwjgdYeHzpxItrsDdAYqzXOb6BBYikHwWEj/hOVM=@vger.kernel.org X-Gm-Message-State: AOJu0YzEC1y6XhYvOAvQZivBqyH3SPuJ9weegaKh7BMerLeTVhx97NqN vw/j5TJDnXROg6WDOvsfO8i98rrLb/fUYmSaIJWsqIg64jBqOG2CyuDNOZSdUjuE2LM= X-Gm-Gg: AeBDieuzYOzKWu/9bxpGXan2VfynKVy+fYQCXIl2c+46tOi+CoGgkdpXaVeF/PbDzuc OO5HefS4Vx4mKVlS5mR67W9bzTW05UH6E8zOPqlENg0c8zin+nHkvwOzQAYvGQ3+VHNRZzdx6mQ gQzPKWlVyYpugU03BAvBPu0EDTjoBldEcDGRjlfmC9A2LyQ4NHTU4X1CprIFeQjfcS4/5zGUZv8 Z3I7tY/n2xJQC2ze03eyhU9tiCqKqIjDz+34hh7UF84hJaP8zaeRwZaKosyDzDCfxKiNY+Z+u0A jOGxeufD34JU6Gp9/Qfy8e74U5YcJSWqnTdMQJE3bK0M491rxXfkAk+Wem9rYkX+dIEuunjLgeZ a7uiRpNHYgFAnXb2lY2oTMWMO0YH+SBNncm/aFieVYrJIU92wMwm+bVJ8qcm698NQZyY7js2qZT jvhwyZb0kZ8PPGFzz2dfDE7T4dW8tdXt/BsU7PpxOKbIR/ihYrkLQ+VUq2eZyIWzJlOLlH1bjzQ vuIorjosnmQWVkdvBa5mEfW4ptJIfo= X-Received: by 2002:a17:902:868f:b0:2b4:59bf:5728 with SMTP id d9443c01a7336-2b5f9f3ca68mr27500095ad.25.1776442125959; Fri, 17 Apr 2026 09:08:45 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab20c6asm21888895ad.58.2026.04.17.09.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 09:08:45 -0700 (PDT) From: Felix Gu Date: Sat, 18 Apr 2026 00:08:35 +0800 Subject: [PATCH v2] counter: ti-eqep: fix runtime PM leak in probe error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260418-ti-eqep-v2-1-2f803963c4fc@gmail.com> X-B4-Tracking: v=1; b=H4sIAAJb4mkC/2XMyw7CIBCF4VdpZu0YQFKsK9/DdEFh2k5iL0JDN A3vLnbr8j85+XaIFJgi3KodAiWOvMwl1KkCN9p5IGRfGpRQtdDS4MZIL1rxSn3XOGfkhSyU9xq o5/chPdrSI8dtCZ8DTvK3/htJokRrfKdrrXzjxX2YLD/PbpmgzTl/AfOrWH+eAAAA X-Change-ID: 20260417-ti-eqep-8efb9cc713ea To: David Lechner , William Breathitt Gray , Judith Mendez Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776442123; l=2523; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=elMH0A5dNUucHdQlYYF5w5q0pFGSO2M0Cmf8V51xFME=; b=oUGFcAwz3nd3GDmkIHkmSvfFICnd4JUj+rR75bIVqclE1X1Gqq5nB5OXMfcDPl6koLOTggdFy QnACpv9RK7YDlLoUtnh0TxJQTwPD3q55jvWglaX7ujHyypVRrS7y0v2 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In ti_eqep_probe(), if devm_clk_get_enabled() fails, the function returns without cleaning up the runtime PM state. Switch to devm functions to fix the problem and remove unneeded remove() callback. Fixes: 0cf81c73e4c6 ("counter: ti-eqep: enable clock at probe") Signed-off-by: Felix Gu --- Changes in v2: - Switch to devm functions to fix David's comment. - Link to v1: https://lore.kernel.org/r/20260417-ti-eqep-v1-1-a7db4642d9d0@gmail.com --- drivers/counter/ti-eqep.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c index d21c157e531a..08dc6d0ad5e4 100644 --- a/drivers/counter/ti-eqep.c +++ b/drivers/counter/ti-eqep.c @@ -492,6 +492,11 @@ static const struct regmap_config ti_eqep_regmap16_config = { .max_register = QCPRDLAT, }; +static void pm_put_sync(void *data) +{ + pm_runtime_put_sync(data); +} + static int ti_eqep_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -544,31 +549,20 @@ static int ti_eqep_probe(struct platform_device *pdev) * parent PWMSS bus driver. On AM17xx, this comes from the PSC power * domain. */ - pm_runtime_enable(dev); + err = devm_pm_runtime_enable(dev); + if (err) + return err; + pm_runtime_get_sync(dev); + err = devm_add_action_or_reset(dev, pm_put_sync, dev); + if (err) + return err; clk = devm_clk_get_enabled(dev, NULL); if (IS_ERR(clk)) return dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n"); - err = counter_add(counter); - if (err < 0) { - pm_runtime_put_sync(dev); - pm_runtime_disable(dev); - return err; - } - - return 0; -} - -static void ti_eqep_remove(struct platform_device *pdev) -{ - struct counter_device *counter = platform_get_drvdata(pdev); - struct device *dev = &pdev->dev; - - counter_unregister(counter); - pm_runtime_put_sync(dev); - pm_runtime_disable(dev); + return devm_counter_add(dev, counter); } static const struct of_device_id ti_eqep_of_match[] = { @@ -580,7 +574,6 @@ MODULE_DEVICE_TABLE(of, ti_eqep_of_match); static struct platform_driver ti_eqep_driver = { .probe = ti_eqep_probe, - .remove = ti_eqep_remove, .driver = { .name = "ti-eqep-cnt", .of_match_table = ti_eqep_of_match, --- base-commit: 452c3b1ea875276105ac90ba474f72b4cd9b77a2 change-id: 20260417-ti-eqep-8efb9cc713ea Best regards, -- Felix Gu