From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 756192BD11 for ; Sat, 18 Apr 2026 03:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484107; cv=none; b=vC3yvfAVC59TZ2BkQDRT9lU/G6I5FZ1s3sA0hoAD61OzU0I/R35xoj+geY1upAVCOSnWdpNlcgTBRr61XNU6gMeZ8KL/+zH0n2NgOzFQzXKrAjKklayLh9hLOXG4nrbS6LAVzBL0JIjohsJHw2eWn5N5QtQuy/tsBqloJclPStA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776484107; c=relaxed/simple; bh=l62WI7Ygy+J0W2/WvRq2MtdPbp3iVD3gSZDmZzAIvbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HdRPnNLNhfx9mA4bqf2Dphv1qwz7UqJF+7npde1FH+cxF0MJJXvIQr2BxflzND6Nxlt1nWl78k3z3eEPVEikLzmoi5u8lFlFetsCXtu4xgWCdX3FXMdzXtm1MwS4hZCuk48yyj8KPJZqcBIU8R5U61N5FKExk2mFnVI0Wy1gIqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fPKYfilZ; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fPKYfilZ" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c795f096fa5so540741a12.3 for ; Fri, 17 Apr 2026 20:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776484106; x=1777088906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=joLiL8rHMacEzcwk5prGowFLUmrQwzWzBoDZlkxhLUA=; b=fPKYfilZ4PP/4YeVz93Xm8GYM95I4FJ+Sg/S8srQ0Qm9VTT2Lb5jKQQPYSuJV0KZuy WixARircgVOZO73O5rQodEClZ+bb/SHd33pgE+D1TFYbnpMKnwdigoxG8ebHJzrfDRXn eaETm/i1lwfoe/zK/41fFpvAYaLwkXdanq/7RBNvoLHWXrRk+dTII0hwfPw8Vce4nH8H Nb4MDrduehPROKE0MkIzHL6JY11abvfmS7q7RP9xloAb/lCu0rxHlSCgfa0a+d5UlvkR zR6iCX0maY24MgkqQW9N7FnYXe6k1GJmfbMbgx8ifmLPJjQP6ZNR0r8sSzJBP0HEpNHL sbIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776484106; x=1777088906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=joLiL8rHMacEzcwk5prGowFLUmrQwzWzBoDZlkxhLUA=; b=iVjjTo6Qiz4VP/4atIohbvRCKJFp/kJuN6zfshJwcb/is/sG1al9L8k/OEtLG8aoo/ nu6ZXt5LDqch16xynwme16r2CBKABjlWMbe1NZ9aYYr5iBRfYCXkDcUAGR3RzKzgWXZ4 hWiY37QJ6RMJTZMH46XMkMBJCbwoR+RPNNs45lgCo6iyOdPx3fyvUk+VRbSVsTMQ28hV JfDibaIT8hb8Oad6A23ODreIdQoliFGPhYUykNeV1c6171Lsz+/1UKgxmXNp6UbRSQ8l 4gtcDEoy9Sk9hnHq+R21PCkITQp0qFdJBogh5veyijgqV7mAVISYZfjcg3cEakpa1FHy dJVQ== X-Forwarded-Encrypted: i=1; AFNElJ/358OPG5ThHl3K2bvR2rRj70yjyvukGh+w+UJtkQmaGLGp9vLbshawQWkNHidpKQXr77V/LblEs2dYWkk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+dsZyK1eOHqqe3vy3bF69bGBpDak5wrpgE1PA/IMBpwnYmlHF 30MtMierzSm8TK9vxWW0n3Jkx1+xMz7O1XCv3YmMm6nKZnfRjoxfferl X-Gm-Gg: AeBDietDcBxHuboTNt/z7uFHOV/hUBkzuUeHkfUoh+qBn3mD0BwO8iVchya6xrY0o0X bTb1B1i35clkC2Hc54EmlUTa0vEScdFCPmJgJUWORbNUoieejF+0+5qP2cwakCDg3/WMw882QjJ H4xhgUc3vtS5++aCfIvbEoZqUjvhxiwrhWTUXSoXgQ2wSk9nbUZh7kyPpShGIpucIWPkK0xg80h +asnHOUDVYDThllqGqbCl9CKZgsvtM0rwUQzgdYMFUlZAJWUifs44v0qK5ASdKlvRnc8TlDuSZo hbYvIFmigjv/O3FE1v+o2DGPAVDg/x3c1daHrIJQn458NhfJFnOQ1YqThVr8TGTO7hGCSchBi9U IXe7MrkGARTKnUe9jkhIxqor6YNuc95D7NfYcp4HR0f9ururfAuI7VGPPs8wSednss8YFEw6fQH 688E8ok0qqV7xrADdwOd0OxsXijJDyPn1HcSDX3rBwgyLfXGfUmE18UU6zq8hJNwKFIdT19b+zb A== X-Received: by 2002:a05:6300:2109:b0:398:b346:b13 with SMTP id adf61e73a8af0-3a08d6f1991mr5383337637.16.1776484105826; Fri, 17 Apr 2026 20:48:25 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([27.4.62.72]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec05391sm3549074b3a.56.2026.04.17.20.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 20:48:25 -0700 (PDT) From: Tabrez Ahmed To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed , Sashiko Subject: [PATCH v3 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads Date: Sat, 18 Apr 2026 09:15:59 +0530 Message-ID: <20260418034601.90226-2-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260418034601.90226-1-tabreztalks@gmail.com> References: <20260418034601.90226-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ads7871_read_reg16() function relies on spi_w8r16() to read the 16-bit sensor output. The ADS7871 device transmits the Least Significant Byte (LSB) first. On Little-Endian architectures, spi_w8r16() correctly reconstructs the 16-bit value. However, on Big-Endian architectures, the byte swapping causes the first received byte (LSB) to be placed in the most significant byte of the u16, resulting in corrupted voltage readings. Replace spi_w8r16() with a manual spi_write_then_read() into a byte array, and safely reconstruct the integer using get_unaligned_le16() to ensure correct behavior across all architectures. Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20260329073352.270451-1-tabreztalks%40gmail.com Signed-off-by: Tabrez Ahmed --- drivers/hwmon/ads7871.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 9bfdf9e6bcd77..9b52aa496d522 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -59,6 +59,7 @@ #include #include #include +#include #define DEVICE_NAME "ads7871" @@ -77,9 +78,14 @@ static int ads7871_read_reg8(struct spi_device *spi, int reg) static int ads7871_read_reg16(struct spi_device *spi, int reg) { int ret; + u8 buf[2]; + reg = reg | INST_READ_BM | INST_16BIT_BM; - ret = spi_w8r16(spi, reg); - return ret; + ret = spi_write_then_read(spi, ®, 1, buf, 2); + if (ret < 0) + return ret; + + return get_unaligned_le16(buf); } static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) -- 2.43.0