From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ECE4272E56 for ; Sat, 18 Apr 2026 10:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776507602; cv=none; b=AhqVbtpClt9xhopmlPy3m21LbhfNKd/pSefnNVrsROMwben2A+VFYWcHLPb1bAaU2ccpgwyjJgbHM0KN9rIDbTouAdhWmoBbkpl+eH8RwNW3DisEg9j/bs4zjdX5ayU5W5D9r/WwAYLOKQ+5plAnv+3fzdT30r8l6zijIJEstFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776507602; c=relaxed/simple; bh=vZB01Uszi+NlvuVgjZIo5cDjSFQRqO8hbTz3Po6dwJI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jJh+dQPH9pq4F9BbR0mywZ/gXoK8M2DyjAEFKodAaMBUtTs289rLURQicglqreT9J4KKLij27WmWhNERGI4iKVRgiiFQrpBt2vusBXhrVQym+VbT4bf1b7JFii8K98R1lAsYtLF2n7lE9PERxQff+JYHM/6zn3DB1x+ipRFjyXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JSiJZz0q; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JSiJZz0q" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ab08e6c553so2350975ad.3 for ; Sat, 18 Apr 2026 03:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776507599; x=1777112399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xqAYAaB98xsAiWaW3K7BAxJ1Wdz7VTsIiYzGAY8PX4g=; b=JSiJZz0qBQIs+wx+1F5Aua6oA/lvVNodyLeuUWkCg4X2QEaZmt1mG1GRBeQvYItX9J 8LXSp9vtmRT+7zDq9ALjR7HPqFFIpQr+p0rIYCWjOUtKgA26b3zmZp0UUr8muKXPtsZ6 yKTXz3vK7b875FM6zWc1Rq6yR4L+r4Z4Sihud0P2VAqk+drWMolFGr6xJT7heISNQRtB BZCANn8ILdL3ZYB67hILmG53MzH3TqocpZ4XTtbeQQfkA8Mset+GMQzBJv9NlhU4xnnm V10ErJSKLtyXEyiKKvn1PoDFPr9fxT55rsdcuNdJSiEa+TO25h2b7JLKoMIRmyPqzXX2 cx8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776507600; x=1777112400; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xqAYAaB98xsAiWaW3K7BAxJ1Wdz7VTsIiYzGAY8PX4g=; b=Efyx7pm1gGOfrJUEmdB0zGGMqNtgON/PdwipOksY/xvn74GeYEaK+7j66gNZ03I01J E5vDd0XKlwqxNbU7vUw1y2ilr2hPWoYJYztIofSO1BAN5gfCctWALKBelgsthiIM40D7 AYJx8dnp8N1IThelGKt4pBS0we1feURJ9gUo9F4dfeVm3Qs3sQe02r4oSOSgiFgaT/of Tj1yZCHzWzJUvrtwAUk2Cp3sGTu+YRNYTLighdJZQUhBEYicrbHMUJMTozMoQRF407Yp TyNDitqOqb1c2YvrmwP2N1wqqAe8wr863uGUOvaFLFCjOkNJgaVPOgG7YzEx0uQZnO/m Ed/g== X-Forwarded-Encrypted: i=1; AFNElJ/5/zLajYafsFFhewfDO/Pko1aoJRwAFpwPhRPoW04n78EZU3uBrvPUoWm0yRnVY/8Jcq7uSgB2KFUPD1g=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr5eu9T9MDGfp6p3nDXxstMoCjpTbohvByulbASKNSKx2G7KKz U96IGEHZ5k9k4mr7F1s7bSIAqWQ6WGHbRTQs+7IMbUxERDZnmZExigNH X-Gm-Gg: AeBDiesniKlgY58lWRXzYifPwNpIDdiy1K+hyPG05tizIU7ks2M3RUYMDD00DA4INYk L1otnir1kFlGi/NKgFLQuHPjL3BSSJBwqe3ptpiZbWtZmwJNb+boog2lKUfd8np+NtJVMhUE3B7 gL3qRPROft8Ty5uPOST6hUVU56/h4jH85G5C33j/BCRlhTCeen/wsiRspbMvsOiWDMheA7ufqh7 Fp7Hryl9SyJ5Xosyez+ov1MkqSf2k8aZLEeipvXLx4+CkeMRAitxbUvJ40F6/rwphu34KHmgCh3 Q6VyE+5joamn/vpfIDr+iC5OiiUsruy6jzMmQB6vTfvL9j9LAoiG9VWOTuNWGbxagX/GJsoAS28 hAlbByfBXklCodpLBYqvOlqijjnClG/xcv/s0bSybMfLw/8vsUcbHdA275M2bl3jidMuh2T8OkF yocgWY5+U/JWOmx476WrReDzNjANpMynshTIWLJF8p1BnuS3rws0X2EiHwTDIfeQ== X-Received: by 2002:a17:903:907:b0:2b2:eb6b:72f2 with SMTP id d9443c01a7336-2b5f9fff1e5mr33840955ad.7.1776507599529; Sat, 18 Apr 2026 03:19:59 -0700 (PDT) Received: from fedora.izzigo.tv (45.62.127.193.16clouds.com. [45.62.127.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9ff39csm46674525ad.4.2026.04.18.03.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 03:19:58 -0700 (PDT) From: Frank Zhang To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: detlev.casanova@collabora.com, cristian.ciocaltea@collabora.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] drm/bridge: dw-hdmi-qp: Guard clear_audio_infoframe when PHY is down Date: Sat, 18 Apr 2026 18:19:36 +0800 Message-ID: <20260418101936.7731-1-rmxpzlb@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following panic was observed during system reboot: Kernel panic - not syncing: Asynchronous SError Interrupt CPU: 7 UID: 1000 PID: 2637 Comm: pipewire ... 6.19.10-300.fc44.aarch64 Call trace: ... regmap_update_bits_base+0x5c/0x90 dw_hdmi_qp_bridge_clear_infoframe+0xb0/0x120 [dw_hdmi_qp] drm_bridge_connector_clear_infoframe+0x28/0x48 [drm_display_helper] ... dw_hdmi_qp_audio_disable+0x24/0xb8 [dw_hdmi_qp] drm_bridge_connector_audio_shutdown+0x30/0x60 [drm_display_helper] drm_connector_hdmi_audio_shutdown+0x24/0x38 [drm_display_helper] hdmi_codec_shutdown+0x60/0x90 [snd_soc_hdmi_codec] ... snd_pcm_release_substream.part.0+0x44/0xd8 [snd_pcm] snd_pcm_release+0x60/0xe8 [snd_pcm] ... The root cause is pipewire tries to close the HDMI audio device after atomic_disable(), which sets tmds_char_rate to 0 and disable the PHY. In this case, dw_hdmi_qp_audio_disable() will call drm_atomic_helper_connector_hdmi_clear_audio_infoframe() directly, accessing registers without checking tmds_char_rate. Move drm_atomic_helper_connector_hdmi_clear_audio_infoframe() inside the if (hdmi->tmds_char_rate) of dw_hdmi_qp_audio_disable(). Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp") Signed-off-by: Frank Zhang --- Changes in v2: - Move drm_atomic_helper_connector_hdmi_clear_audio_infoframe() inside the if (hdmi->tmds_char_rate) of dw_hdmi_qp_audio_disable(). - Link to v1: https://lore.kernel.org/all/20260416093150.13853-1-rmxpzlb@gmail.com/ diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index d649a1cf07f5..7760527484c8 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -526,10 +526,10 @@ static void dw_hdmi_qp_audio_disable(struct drm_bridge *bridge, { struct dw_hdmi_qp *hdmi = dw_hdmi_qp_from_bridge(bridge); - drm_atomic_helper_connector_hdmi_clear_audio_infoframe(connector); - - if (hdmi->tmds_char_rate) + if (hdmi->tmds_char_rate) { + drm_atomic_helper_connector_hdmi_clear_audio_infoframe(connector); dw_hdmi_qp_audio_disable_regs(hdmi); + } } static int dw_hdmi_qp_i2c_read(struct dw_hdmi_qp *hdmi, -- 2.53.0