From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFDBE35BDC2 for ; Sat, 18 Apr 2026 11:23:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776511425; cv=none; b=j2bH/xzh20v4JHDp1WA/CY5N6QsBaGV0uMNeXdnBLx/lF811vLGWlfflcUA2L9IzC+LcEOwfljPFLsKuSyzgduhwzimhgdByzHEZ6G8Q8mXmyEuY3K+plrLd8v+cZDnB8Gn1P9ypJW5Dui2ToupVGZwFLbDACG5JsbMyax/rSwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776511425; c=relaxed/simple; bh=ZP3bbNTGALdUtItdFr3L8eIdVLWv2WwwZry2N7ZQyCQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZfDxP6aatYPcadybMuFLUx5buAhQYIE8r6eTmXqrWWrC67eQjVVutHnwy17bfFeGP4IgO5bpyuCtX4uant1z167hdaMVRL2ccqjsDVLlUqMskO1peWtPNXJ24nY7CJg9ukJezbN80ebWtpBbGPu98GzWFeGI0FGoHkq6bZvb3zM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eApkFv0B; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eApkFv0B" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43fe62837baso829784f8f.3 for ; Sat, 18 Apr 2026 04:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776511422; x=1777116222; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jAsbjYHy+4rpJ5IKMV/D1YXW5rWUwBVF6O/LM0Q6nvA=; b=eApkFv0BJcEMPuL/VQE21jtGcdwKPCZVW0q9RinAzCV8uKQf4CEoNdmly+FU4p0fML sl8d0wyC3gdiERL8DcN+xuCcO2rBJOXfol3SceJ6hj2IwI2EtL2DEbmvmOoaZoWZABbD SpITzzSNaBFd+9L0Puqv8EF/F5AlAqBka4mhRswS1yRRllTswsV87ZU6iAOPB7Wp//5/ qhXoiaqy0c/crllanMXdBNLE7BQ9oAYWviZt//3OmxFzdVdEQPkzuofHHUnStv8N59EP KyMKFLsbyq+jedHa1s29CGIEqVE3asGAcdaQoi6fuxNesxAV+jafvCiNsCX9MQ5Gk+Lc 8k0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776511422; x=1777116222; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jAsbjYHy+4rpJ5IKMV/D1YXW5rWUwBVF6O/LM0Q6nvA=; b=BnAGt/HhIgWRbC4LGNT3IXOk4YvxNJfu33qXT21ztVmZZ4nWOEctwPyfAipAwRHabi WooJoUNgd2ha4j5KX1jIcSOYUkibd/sVbP50OIIva0HBvxdAEpzdTChNv3cvYQaSZjOu Q6Y2+7ykrn/CeEChvZ/2V826Ji/DdscCYIQby3A3nVevClJhYWX1mEh3mwaLmeUw2i7K uNuLH4yL9xR38g6W3GgJ2zD6gV+faOAZLGkTuOYyHojThZW40fMExBtU3hKgwSlR2Qo9 3UVwGXw+oy+MTxj/94zZRwx0sQG3TQaY/reO2ZrDHJ4ON9ueMc4sn2g9btVBXZkdFEz5 wRog== X-Forwarded-Encrypted: i=1; AFNElJ/ZaLG9QhqulHoCrIrFbxOdBbo1H5+6Du/sDaas9enN4yKkoAcaULegSSZb+z0e0m1js2fzxjUxxTY67TQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyHuPdbk+tbj0197hcY4IEVcf0fMZDXLtUoBpwVUVGCR9C4B3Un sniL+U2eFonmY4bgg45fJwJbo8ZX608ka1ykOLKwaxsyGMHu4tvQTW9zdNOKREuD X-Gm-Gg: AeBDievYtvd+KsjQIHOkRu8kNA0Qved0sA18wpqdSxaQWt17o/aNwOvk1aoGGNIihiF RvuIMUqFJWeI/3rdmE8OPR6R8wl9ssyM6enDvxz8NNfGLlUm9XPe2oZwPFuFUAml4tOq7QXwC2n pOk9HtjWA7L2BmHCboK8zRqeVeSiEaTkm2ej92REivQxxii6KQhkfuLckx0YxcDfJD962WjfbfK OKN9haXqm1qnJ0fS6DJPGkkcA9sGqW+qhRKt36WmnH1H4dnoASHpVeTD0vKZnt06UQVXonVdjUl PoVf8oFvVZklTYkGoF7iyY2uHnQ9fe/ECAvJTVnU6BdlV6tpz4dAjvq0OrJ9IDhi53i72g6zfis Jm1zccvXdJTnwY2+sx597TdwDSdQPxyL9Xq11qtLmqjh+LOHp3mPGEBCGoBny3LhnJTd2cJ829t KnNnrK3YuF9inN07UdT8P+89d5OhjSynlbyx2iBbBD34G9fJ42YB+P3Nmr1fW1WBhLVv6EMHRay ws= X-Received: by 2002:a05:6000:1785:b0:43c:fc5c:a9fe with SMTP id ffacd0b85a97d-43fe3dbf4e7mr9682523f8f.20.1776511422101; Sat, 18 Apr 2026 04:23:42 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cc0f31sm11993447f8f.12.2026.04.18.04.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 04:23:41 -0700 (PDT) Date: Sat, 18 Apr 2026 12:23:40 +0100 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , Daniel Palmer , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] tools/nolibc: also handle _llseek system call Message-ID: <20260418122340.1dc07834@pumpkin> In-Reply-To: <20260418-nolibc-largefile-v1-1-b91f0775bac3@weissschuh.net> References: <20260418-nolibc-largefile-v1-0-b91f0775bac3@weissschuh.net> <20260418-nolibc-largefile-v1-1-b91f0775bac3@weissschuh.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 18 Apr 2026 12:19:56 +0200 Thomas Wei=C3=9Fschuh wrote: > On some architectures the llseek system call contains a leading > underscore. Also check for that one and prefer it over the lseek system > call as it is necessary for 64-bit offset handling. >=20 ... > +#if defined(__NR_llseek) > + nr_llseek =3D __NR_llseek; > +#else > + nr_llseek =3D __NR__llseek; > +#endif Is that test the right way around? The commit messages says prefer _llseek, but that seems to prefer llseek. David > + > + ret =3D __nolibc_syscall5(nr_llseek, fd, offset >> 32, (uint32_t)offset= , &loff, whence); > if (ret < 0) > result =3D ret; > else >=20