From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E497A387375 for ; Sat, 18 Apr 2026 14:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776521493; cv=none; b=un3MQdT1td5IAa2YrKMb0CRroHYdKEHCSZcCM0ISn+JWhTh/KKoIoUOSsrCh3nSyKQQMp2Cdu6fuez8Ri+sfrXdY1HnnCwUN8+UDrODl51tsAiSYZCA+dfA+5hgwH2VeHuVExJpseM0AjYX3Xqv4/BUkT75hcLmGlzU7wzzOJMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776521493; c=relaxed/simple; bh=55fP/35MZZS/hMHZOhzJkSjUW3dUdiVhKN5RAKZ+CdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aMIaV8ThgkR/9CMnilhYPSrqN3yjWG/6Hw3iuWb8KCjG7HdnTdhAw9yXUVZXbWZD94Te6nZRgKGcZmBhS6OScbvE8jhWGETaz1Co3gePcFPTQiIfbPoTl896n6+SX527RE8YdB7KWFZ45b2YEsyXBQXhJQUyP+i7KIxFsWmTJeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sGeThr/Q; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sGeThr/Q" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-488b0046078so15183165e9.1 for ; Sat, 18 Apr 2026 07:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776521490; x=1777126290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F0uV/ApidjU/+Ww0veY0spsvhyr4hvLh1zUt4FfzGYE=; b=sGeThr/QL0DaynWZBhQupqXajMk8/xGkn+2CE25Cdn2SlURauZ3IbZfnKWiMKhv16K E1BJP6pVMzS/T4CS8tqq9qMSee7Mn/ZvZeH8kKmnLj0ZBK9rK4IAOATMZzynpz4qil2X +hN6EGRNGgk9xYlX4ZH+oAOqNlzt4NDLF13dDMvsBluwwQe4gEKwDXfRy59Q0xNSysuP 9EMfk6Hzc1C7epxRPMn4tL94kfwgmz08pVmGviWAVATZ1KvUKZglVZvlcIaQh6RhjO4a FdyXSMdM/x2dHHqmHuiV0oPOnmnVO7yGpPiP9PmqKXh/mM+Slj+ep4JgudSIsyX3rAiU wpMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776521490; x=1777126290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F0uV/ApidjU/+Ww0veY0spsvhyr4hvLh1zUt4FfzGYE=; b=qV0U6Ov4jbjploTEfxV5z7hYrtE8038UncBcEANDJtQrflw44eJ1PXvf2YlkF7bSbH xAyxHBLkI0XatR4yGWRcRwnrSEXOVbxFjum5yuwgkgX7cCsLZNMVi7uvF5XsZtPbM2M/ 3DZXbNrQeTZ34KK7YvQaALZFqMAW9/QQyxZPiHZ5IdphizrxSE7x2ZW02+p05wMWYtBi DWZJ+sTtAVirFhztppBz5wdkSaoPTAgFVLLeY2VUroRlkvdI+uQ2VfRJpLuqiCZmRSwo ma13WG3hQi2iBxIBJRmX9nIHEAvs0Mcr9v9g+BmUTMEa2Mzpct2bA2fj7MPOrBvKKaDS H6nA== X-Forwarded-Encrypted: i=1; AFNElJ9XTegPKzAjR0/L/anbERHd8/e2muktf3n8LRkg0qauoUSdseyQqTj43D3Iw5wfImye50cw0k9RL4Hlzik=@vger.kernel.org X-Gm-Message-State: AOJu0YypufaoPReXXCMmTWT2z82Dn529oCfV05+cJYhXq38ePPmTkxjj mpflKyrJiY3xayj/DeKdMOdkGAesI/1CPRvHJFL5CLq2G1TtSWwoyjVP X-Gm-Gg: AeBDies0APKdayv4IOXOoHKZF+zcHssEY/bqH/bz5ZkYQe/NZ9c8FOVhxbIDvktX6ik T2F7dLOsqPKc3bDDAhYMKkSKqlKLKvlDDzSFAhgAx3b6IZUZnZ7fDrm18ABZ2HVfLs2J3UqGRPN fNUx1ZL9AxTGuCAWsKppH6bdKGJG05eC3wy9sUt0wH7e8E3vfjefwh7k9zlTM9ghQIG4XqZc6nq f21QjTPuKiCBTM6IjYBbYu1tpJr7eW1RC0/5Ig/KJrM1rJyTKG0RIxXjkkRs8Ozfk6QT5tFnhFS KPknaL7vplnxmhpcZWH82imRxCoPNtzHWZN4qpNJI28bTBT3UeUGzWpmgX1chEMts5YscjQzgU4 /L/PPFPduV8srCDiuxzoT9OBRQcGuwKnuQhd2VJjfG+h4L2WV51PDNEPe4A+LBvbxQ7qCSB4GXg Z44+xTONY23wnCz1rZM/VRRSs/ISx2+2Kd/JFt6jg= X-Received: by 2002:a05:600c:1385:b0:485:4eaf:eb54 with SMTP id 5b1f17b1804b1-488fb78260bmr95376265e9.20.1776521490069; Sat, 18 Apr 2026 07:11:30 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:4429:3762:47dc:91a3]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-488fb7a0c13sm43557365e9.21.2026.04.18.07.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 07:11:29 -0700 (PDT) From: luca.boccassi@gmail.com To: kexec@lists.infradead.org Cc: linux-mm@kvack.org, graf@amazon.com, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, brauner@kernel.org, linux-kernel@vger.kernel.org, Luca Boccassi Subject: [PATCH v7 4/4] selftests/liveupdate: add test cases for LIVEUPDATE_SESSION_GET_NAME Date: Sat, 18 Apr 2026 15:09:40 +0100 Message-ID: <20260418141123.2193917-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260418141123.2193917-1-luca.boccassi@gmail.com> References: <20260418141123.2193917-1-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Boccassi Verify that the new LIVEUPDATE_SESSION_GET_NAME ioctl works as expected via new test cases in the existing liveupdate selftest. Signed-off-by: Luca Boccassi --- v5: merge with LUO_SESSION_MAGIC series as they both change the same unit test file, to avoid merge conflicts split into separate patch v6: add more test cases as suggested more verbose commit message .../testing/selftests/liveupdate/liveupdate.c | 138 ++++++++++++++++++ 1 file changed, 138 insertions(+) diff --git a/tools/testing/selftests/liveupdate/liveupdate.c b/tools/testing/selftests/liveupdate/liveupdate.c index d132b4685f76..ffbcbd465c9b 100644 --- a/tools/testing/selftests/liveupdate/liveupdate.c +++ b/tools/testing/selftests/liveupdate/liveupdate.c @@ -105,6 +105,22 @@ static int create_session(int lu_fd, const char *name) return args.fd; } +/* Helper function to get a session name via ioctl. */ +static int get_session_name(int session_fd, char *name, size_t name_len) +{ + struct liveupdate_session_get_name args = {}; + + args.size = sizeof(args); + + if (ioctl(session_fd, LIVEUPDATE_SESSION_GET_NAME, &args)) + return -errno; + + strncpy(name, (char *)args.name, name_len - 1); + name[name_len - 1] = '\0'; + + return 0; +} + /* * Test Case: Create Duplicate Session * @@ -385,4 +401,126 @@ TEST_F(liveupdate_device, session_fstat) ASSERT_EQ(close(session_fd2), 0); } +/* + * Test Case: Get Session Name + * + * Verifies that the full session name can be retrieved from a session file + * descriptor via ioctl. + */ +TEST_F(liveupdate_device, get_session_name) +{ + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] = {}; + const char *session_name = "get-name-test-session"; + int session_fd; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd = create_session(self->fd1, session_name); + ASSERT_GE(session_fd, 0); + + ASSERT_EQ(get_session_name(session_fd, name_buf, sizeof(name_buf)), 0); + ASSERT_STREQ(name_buf, session_name); + + ASSERT_EQ(close(session_fd), 0); +} + +/* + * Test Case: Get Session Name at Maximum Length + * + * Verifies that a session name using the full LIVEUPDATE_SESSION_NAME_LENGTH + * (minus the null terminator) can be correctly retrieved. + */ +TEST_F(liveupdate_device, get_session_name_max_length) +{ + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] = {}; + char long_name[LIVEUPDATE_SESSION_NAME_LENGTH]; + int session_fd; + + memset(long_name, 'A', sizeof(long_name) - 1); + long_name[sizeof(long_name) - 1] = '\0'; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd = create_session(self->fd1, long_name); + ASSERT_GE(session_fd, 0); + + ASSERT_EQ(get_session_name(session_fd, name_buf, sizeof(name_buf)), 0); + ASSERT_STREQ(name_buf, long_name); + + ASSERT_EQ(close(session_fd), 0); +} + +/* + * Test Case: Create Session with No Null Termination + * + * Verifies that filling the entire 64-byte name field with non-null characters + * (no '\0' terminator) is handled safely by the kernel. The kernel's strscpy + * truncates to 63 characters, which we verify via get_session_name. + */ +TEST_F(liveupdate_device, create_session_no_null_termination) +{ + struct liveupdate_ioctl_create_session args = {}; + char expected_name[LIVEUPDATE_SESSION_NAME_LENGTH]; + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] = {}; + int session_fd; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + /* Fill entire name field with 'X', no null terminator */ + args.size = sizeof(args); + memset(args.name, 'X', sizeof(args.name)); + + ASSERT_EQ(ioctl(self->fd1, LIVEUPDATE_IOCTL_CREATE_SESSION, &args), 0); + session_fd = args.fd; + ASSERT_GE(session_fd, 0); + + /* Kernel should have truncated to 63 chars + '\0' */ + memset(expected_name, 'X', sizeof(expected_name) - 1); + expected_name[sizeof(expected_name) - 1] = '\0'; + + ASSERT_EQ(get_session_name(session_fd, name_buf, sizeof(name_buf)), 0); + ASSERT_STREQ(name_buf, expected_name); + + ASSERT_EQ(close(session_fd), 0); +} + +/* + * Test Case: Create Session with Empty Name + * + * Verifies that creating a session with an empty string name succeeds, + * and that creating a second session with the same empty name fails + * with EEXIST. + */ +TEST_F(liveupdate_device, create_session_empty_name) +{ + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] = {}; + int session_fd1, session_fd2; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd1 = create_session(self->fd1, ""); + ASSERT_GE(session_fd1, 0); + + ASSERT_EQ(get_session_name(session_fd1, name_buf, sizeof(name_buf)), 0); + ASSERT_STREQ(name_buf, ""); + + /* A second empty-name session must fail as duplicate */ + session_fd2 = create_session(self->fd1, ""); + EXPECT_EQ(session_fd2, -EEXIST); + + ASSERT_EQ(close(session_fd1), 0); +} + TEST_HARNESS_MAIN -- 2.47.3