From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D0B130EF64 for ; Sat, 18 Apr 2026 16:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776530053; cv=none; b=fxWKSvMwVMyv3zQyq3oUYd9UbIZ4Vx6UkVVmKZeXdzhciKP5iTy1Zb4VxpvHdF/B6MIH2VPyxgwxcvHixj6JBCBc5ZrHvBiwkLYo5kbZRhW60v7Ewwa4lZYiKXM0sp6LCGNynmdcfl9MA/ZCylt6rWebrxoPCFs8ereSCxm69vU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776530053; c=relaxed/simple; bh=XG6TwE7GFnOdhbLxuyTWUk4kokhvwC1BEoy+0m+XIw8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WZN/9r1SysMmvSMrevgwKQozZZG2KdPumVKqNvmYaX3gmtom3AQ6d3mGLS7XT4Im+7ctaTlexCFiqvac68WIj/zZqjlCOiG8Pj25o5row6V+BYcsuG5zg4AsfET3LgLrjs0AkFycQ+T1rVmJih6nvRq3mhXry+7/k259UUAjQrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NNq3nvW4; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NNq3nvW4" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43cff5dafc3so1258405f8f.1 for ; Sat, 18 Apr 2026 09:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776530050; x=1777134850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zt+aOMHTeqB+B7ZTmsYzA3/qbdPzt+krJWN0gXu7/9s=; b=NNq3nvW4R7N0bSDS+aF2KC8RaT+2xthtH3XDRcCuJIIpuhGCyg6no1GuijQGXUynpH 5AKK6LejGQh+e6AVq2PDxnPvr5CAyxojG7oaOTFS/Cq9pBeVav5pCluF0uZgxNY7QXt1 zrgqvy6ADZzW0mHzSeJIDdtPZ3vLV3JCr7DUBgRYo7PGWiPPSgrgQJtimNrzJQSJ5wet k+T8EW6H5xgveHutcSF7PeyAUoBXlSJ1Uc28tOR0VXuQzOsAUaUSM3PrC3CStBM5BWCJ vVRytluN55CPPYoow/5ePcFGJsySwMbcJRiKRmOoWuloF56CZrkYyDH1QfX1ByjHChXh 2OVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776530050; x=1777134850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zt+aOMHTeqB+B7ZTmsYzA3/qbdPzt+krJWN0gXu7/9s=; b=otGhpzz9CTud1T6hcZdLOu9H+Pq/L8EeXVvhlA9KK49SG115EtZdtu6moLKxCtC53e Z5tC00/FrfZQPSVPZxU6tJE1VRMMJxG7WOc65X2E+wMddnKLlcaaQTE3c9iUdK5AfRhL 14CKdz5guQXsnP+MpRvpSkT47y18vYr+9sKnL3CTsHJDijW6/NoZHMLB1POHplr4+qnR 1uwsHQ+WunWOe/k9qZ34piAaQCC3K5B7T7Ee7q3Nz/0Sz6occDo0UXMoSLnCwz7h0AyA GKy3MycfCFeGC9siF4Z3uvtfcQ2VJwcm8lQEanHg/k+51WNW1mbymSh8hAKwcSFlvnlf zyow== X-Forwarded-Encrypted: i=1; AFNElJ+J4kWgeM5msbxx+rjkTqojedSdRZus4Id9RUBfhdDN+ZF6G//1NskZVaLW2YOUYieej2+9FrVhnW3ZpfE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3XVuZG2vs/iomuKM0nQ4H6Id3GJbD8wpUCxn2AdYUrLfLiGb2 S4Bj1s3BKRBmUGnxvDfhwybK0RpjxSZPpQFpSi/oZT2y1FOUhafLpEen X-Gm-Gg: AeBDies8MJr+wTRuCSgSiqcXhLdtTAbsuRhLqNmG1qW4DxhzXPxTTCOfx40HYfPUdBv XrTxHSjq/UwCNo6YD1rI0Jt3JnkASAOmHQ0sOyLYC7lejTAQKD4xDZtFz+wvB+lX5mxESx1DBto o0tlmSpI6lehqFqNBdlsv+y80+mKcJPCOrGqKuaniNs+igE9WPhANiZm3Ggh9XOlqCcHvC+fLHr eHNkOvQ2RZ7qamABKmWPGLHXBzo3KG6O7ZG0SdteuS/2Wi1OWkfa2dWMkeVG54wxR5X69Tnpihm 6ZzAbKXV5HFh+HVaBzgZNx4xY3SHP34ZFWjJmdzSaXQG0DgbDUcOVGxzgEVXSe4YkT9OFKaT9v4 E2FsfAySdE+EE0oThp65SR7u5qza92y9RiFsuNMifUUswqsDC0oLwNtVtjCswEZNstGeu5VwAyW DLXIQ2HSR/AyI/XI9sKZu/nRKIvacEGVv34bXoVRs= X-Received: by 2002:a05:6000:2089:b0:439:ccd7:cdb6 with SMTP id ffacd0b85a97d-43fe3dd4f9emr11664614f8f.14.1776530050384; Sat, 18 Apr 2026 09:34:10 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:e054:93f2:97bf:84c6]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-43fe4cc0d51sm13903755f8f.10.2026.04.18.09.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 09:34:09 -0700 (PDT) From: luca.boccassi@gmail.com To: kexec@lists.infradead.org Cc: linux-mm@kvack.org, graf@amazon.com, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, brauner@kernel.org, linux-kernel@vger.kernel.org, Luca Boccassi Subject: [PATCH v8 2/6] selftests/liveupdate: add test cases for LIVEUPDATE_IOCTL_CREATE_SESSION calls with invalid length Date: Sat, 18 Apr 2026 17:28:19 +0100 Message-ID: <20260418163358.2304490-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260418163358.2304490-1-luca.boccassi@gmail.com> References: <20260418163358.2304490-1-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Boccassi Verify that LIVEUPDATE_IOCTL_CREATE_SESSION ioctl which provide a name that is an empty string or too long are not allowed. Signed-off-by: Luca Boccassi --- .../testing/selftests/liveupdate/liveupdate.c | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/tools/testing/selftests/liveupdate/liveupdate.c b/tools/testing/selftests/liveupdate/liveupdate.c index c2878e3d5ef9..f0a8e600c154 100644 --- a/tools/testing/selftests/liveupdate/liveupdate.c +++ b/tools/testing/selftests/liveupdate/liveupdate.c @@ -345,4 +345,46 @@ TEST_F(liveupdate_device, preserve_unsupported_fd) ASSERT_EQ(close(session_fd), 0); } +/* + * Test Case: Create Session with No Null Termination + * + * Verifies that filling the entire 64-byte name field with non-null characters + * (no '\0' terminator) is rejected by the kernel with EINVAL. + */ +TEST_F(liveupdate_device, create_session_no_null_termination) +{ + struct liveupdate_ioctl_create_session args = {}; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + /* Fill entire name field with 'X', no null terminator */ + args.size = sizeof(args); + memset(args.name, 'X', sizeof(args.name)); + + EXPECT_LT(ioctl(self->fd1, LIVEUPDATE_IOCTL_CREATE_SESSION, &args), 0); + EXPECT_EQ(errno, EINVAL); +} + +/* + * Test Case: Create Session with Empty Name + * + * Verifies that creating a session with an empty string name fails + * with EINVAL. + */ +TEST_F(liveupdate_device, create_session_empty_name) +{ + int session_fd; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd = create_session(self->fd1, ""); + EXPECT_EQ(session_fd, -EINVAL); +} + TEST_HARNESS_MAIN -- 2.47.3