From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1DC01A5B84 for ; Sat, 18 Apr 2026 16:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776528225; cv=none; b=Uvc49D7wlajDjtm8y3b0TbY9E2JXuhABApGpwBlLYHWPreZa8ePqyt55kCzIiW+27zve8Ti40yFpaFHH7K2LwYOjLJCh1lrqwO1FdpdYDbUo1cIgNoX5j+nKX+1jPDaQVBaOVKJo8sAfpR4jjaIo6JuSBxQl21octbPt3n/IiFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776528225; c=relaxed/simple; bh=/Z8Soy47+pE/mXnRUFRayqytVsjcE+oYVUCrRSOvav0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UXJxZUAyQuULirP6IISYlbJKoW6wj2SH1VpyQ6n4j1nrlMWSj9emw4Clwp7kalf65n8SBkB58p8NnYGLzUBgidbiN1Rrh6sJSG6XvWZXOfgh0nz5oAutOqVQ/nvbBARtVKgQo///WSO+wxUAOowzcuJ47sz0B7ArCbFe/bh1Klw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fctxgqFk; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fctxgqFk" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43d7e23defbso1043621f8f.0 for ; Sat, 18 Apr 2026 09:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776528222; x=1777133022; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3PSgoRmftqW2olKleIetslZAzqtsieFLcL8Ted7xvEU=; b=fctxgqFkJUdaM//vBFKs25sjF2FvF0mEpG69R1jovaJzQxGocg+riH2UWV2Jf2+KRO lXTvKtbL++hVrGnzXMgE3P4N4o5RJx1ij7glBfI5DZ8alKjDNZimGkN4d1Y9rIqA6MUy ZZW6ONizut8pi3csYr309a0ibLbYDow/LMnx39fz66yLQRqXz3Hxu+JY+1xMTGkk6iSS XNTSQ7Qzb64m0k1CcmX2APXw9xrwxVn3pNyZgCzncs+A6gvHKV99iwyAMN2eJyukKBS6 LFTbS3zHhyqHYtwGWG0JNDdqOVQxyfY349zYCmSs2rt4KO7ogHSix76yfA8xgS3gjpLx 09+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776528222; x=1777133022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3PSgoRmftqW2olKleIetslZAzqtsieFLcL8Ted7xvEU=; b=hWEMfs7uHRDbe0DETT2xSubtOE+1PENLvJ0BqwxCuIR33HB0dnIFD+YJy56kgtThqt MLe7pSj2D2+/ayAZ/YxjPl+R1KUBHTElVDJ24WCjqF4yW4LOna2gVSEnmYfJpvv77ize UUwLGXsBTCW4vdg7LgIQ1y+5tAwATDMejviJVrRQykUbRJmefhAUMTsI+RIwaPb3JHeR gctzHZL7MVWjakSQr28Kt0XWXrRywCaTq2uM61C/skiF05b/fsv+b9tPvXZiIu1QrNZy 9JBjKcrrEdIrzOHJbVw6Qv6S79qiysCrzinXbiIHjbiXe16BUNdUH8cBtNBPrHM+wGq6 xCyw== X-Forwarded-Encrypted: i=1; AFNElJ8ode3HaoocebAgT91GuFELUbMBNwjZNU82yAiI+5zhOSTLfFFwCnEUBP2RXUatI/XPxd+YSJ/u/PBd5IA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1EgXB2gbq3dJcqjf9hIk27CRbxYUVhW5IEhhh7GEyHr8b7Kwv x8pRFp1ZzJuFVimO4RoaG2D1/p/xrpD9QcFUOt1qs+7EXcbCJmO0jLQ5Ogzw4ZpL X-Gm-Gg: AeBDieuOaejYtItQPbsgwbGruipx5KRNhp3UIP6OlHqcoucfVBVM1fj0mdwsnGFYb7g zcoV0Nq3TXJ85GDF/CHoPOhHq/DstQSJJHHyhsKZeLQ0KxyiD0XmD18CBO8LH0BAu0reFLks5um Pr/Az5sYsNNeV+vIHxdq2O2U8XkOogD2z7VHp+lqZfdbl5aXIdGCN4dwXJIIkMq6BBiZz7P/6oo zF3/JTiFj48GsRDmxHzTs5HSshC/d/NwH2sWVJhcfVg1qF3z92DuCL5xyJnvwtTlPrk8sbBqq7M EZx+ddNHWq7+VE+FdexI04LTOQwqwG4egCNZ3Io1lPBrKoJI9VMKl8cHc5TgT/SFMNk+iaHg+aJ YkSDzS5ZBWgS/EaBGgpjf8XfHx8G6jTvZzsnimpqPFiawblk1Dktk5CAGd7ETkxtgyi5N77v2xT dfuEs+HQnmKoB/8L4RiTiV9BpyGaDbxYVRRC7vHWA8KMKFoYd2D9vmpgvwg2DLeQEYJ16Ev98e2 3w= X-Received: by 2002:a05:600c:498a:b0:489:ad:7b5b with SMTP id 5b1f17b1804b1-48900ad7b76mr27459845e9.24.1776528222062; Sat, 18 Apr 2026 09:03:42 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f8188sm149609245e9.2.2026.04.18.09.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 09:03:41 -0700 (PDT) Date: Sat, 18 Apr 2026 17:03:40 +0100 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , Daniel Palmer , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] tools/nolibc: also handle _llseek system call Message-ID: <20260418170340.775bdfa7@pumpkin> In-Reply-To: <6fe77be2-39be-4976-99d6-aced2bf3d955@weissschuh.net> References: <20260418-nolibc-largefile-v1-0-b91f0775bac3@weissschuh.net> <20260418-nolibc-largefile-v1-1-b91f0775bac3@weissschuh.net> <20260418122340.1dc07834@pumpkin> <6fe77be2-39be-4976-99d6-aced2bf3d955@weissschuh.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 18 Apr 2026 13:56:46 +0200 Thomas Wei=C3=9Fschuh wrote: > Apr 18, 2026 13:23:43 David Laight : >=20 > > On Sat, 18 Apr 2026 12:19:56 +0200 > > Thomas Wei=C3=9Fschuh wrote: > > =20 > >> On some architectures the llseek system call contains a leading > >> underscore. Also check for that one and prefer it over the lseek system > >> call as it is necessary for 64-bit offset handling. > >> =20 > > ... =20 > >> +#if defined(__NR_llseek) > >> +=C2=A0=C2=A0 nr_llseek =3D __NR_llseek; > >> +#else > >> +=C2=A0=C2=A0 nr_llseek =3D __NR__llseek; > >> +#endif =20 > > > > Is that test the right way around? > > The commit messages says prefer _llseek, but that seems to prefer llsee= k. =20 >=20 > Yes. lseek is the ifdef case below. > Here we have _llseek and llseek. > lseek always exists, but may no handle 64 bit offsets. > Only one of llseek and _llseek exists > for one given architecture. Ok, the fact that you said 'prefer' made me think that both might sometimes exist. David >=20 > >> + > >> +=C2=A0=C2=A0 ret =3D __nolibc_syscall5(nr_llseek, fd, offset >> 32, (= uint32_t)offset, &loff, whence); > >> =C2=A0=C2=A0=C2=A0 if (ret < 0) > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 result =3D ret; > >> =C2=A0=C2=A0=C2=A0 else > >> =20 >=20