Re: [PATCH] staging: rtl8723bs: remove trailing whitespace in rtw_xmit.c

Luka Gejak
2026-04-18T07:22:57Z

On April 18, 2026 9:10:47 AM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
>Hi Osdevhari,
>Let's start from the top of the email. Firstly attachments are not
>allowed, only plaintext. Secondly Signed-off-by tag must use your real
>name(Firstname Lastname <email>. Thirdly, you should setup git
>send-email and use it to send patches. Now let's take a look at actual
>code:
>
>>ret = xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe);
>
>>- if (true == ret) {
>>+ if (ret) {
>Here you did completely unrelated change to what your commit says.
>> ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8
>>*)(&ac_index));
>Also why break this line.
>>
>> ptxservq->qcnt--;
>> phwxmits[ac_index].accnt--;
>>- } else {
>>- }
>>+ }
>> }
> Here you removed an else without readding it
>> }
>
>You didn't even do anything related to trailing whitespace, they
>weren't even there. Also please don't do unrelated changes and stick
>to atomic patch rule. Check Documentation/process for more
>information on how to create and send patches.
>Best regards,
>Luka Gejak

Hi Osdevhari,
Let me add two more things: Your patch actually introduced trailing
whitespace:

git am patch.mbx
Applying: staging: rtl8723bs: remove trailing whitespace in rtw_xmit.c
.git/rebase-apply/patch:21: trailing whitespace.
}
warning: 1 line adds whitespace errors.

>Fix checkpatch error for trailing whitespace.
And trailing whitespace is a warning not an error.
Best regards,
Luka Gejak