Re: [PATCH] staging: iio: adc: ad7816: replace sprintf with sysfs_emit

Dan Carpenter
2026-04-20T13:54:43Z

On Sat, Apr 18, 2026 at 08:05:37PM -0500, Maxwell Doose wrote:
> This patch replaces sprintf calls in ad7816.c with sysfs_emit to help
> modernize the driver, ensure bounds checking, and to increase stability.

This says that changing to sysfs_emit() will increase the stability of
the driver, but actually that's not true. I am fine with these sorts of
hardening patches but I want the commit message to say that "The original
code is fine as is" instead of implying it is unstable.

If the commit did fix a real issue, then we would need a Fixes tag.

regards,
dan carpenter