public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: a <osalexandeko@gmail.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	a <a@js-host.myguest.virtualbox.org>
Subject: Re: [PATCH] [PATCH] drivers/misc: dummy-irq: use pr_* logging helpers
Date: Sun, 19 Apr 2026 07:28:03 +0200	[thread overview]
Message-ID: <2026041910-unbend-preschool-1e0c@gregkh> (raw)
In-Reply-To: <20260419040308.4239-1-a@JS-Host.myguest.virtualbox.org>

On Sun, Apr 19, 2026 at 07:03:08AM +0300, a wrote:
> Replace printk(KERN_*) with pr_*() helpers for improved readability
> and consistency with current kernel logging style.
> 
> Add pr_fmt() to avoid repeating module name in log messages.
> 
> No functional change intended.

You created functional changes, and your email "From:" line was
incorrect.

Please work on basic cleanup patches in drivers/staging/ first, before
going out into other areas of the kernel, so that you get the proper
experience of the workflow correct.

thanks,

greg k-h

  reply	other threads:[~2026-04-19  5:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-19  4:03 [PATCH] [PATCH] drivers/misc: dummy-irq: use pr_* logging helpers a
2026-04-19  5:28 ` Greg KH [this message]
2026-04-30  3:06 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026041910-unbend-preschool-1e0c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a@js-host.myguest.virtualbox.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osalexandeko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox