From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8846032E692 for ; Sun, 19 Apr 2026 11:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776596585; cv=none; b=rE/zg1cYCtY8b+3IqfJlaWgQAuUtB3WJlUlZtYwDX73KkRZe/0v4MyxzZlko36j6g9AI3EIx6OC1BhTTxMIZhDUP4tKGZYIxHVFv6aFC2O6Vvtu9SJ+TIDyIaXQczkCjqojY8w7kpQDW2LNFLj0TUtukSKjXVLOHIVQB8U8YBVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776596585; c=relaxed/simple; bh=3cxEUH0rl5qi1K4eVOi/flkQwufK+SdR0pp9z1HPhgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E944bA1vc/JLwV1En+afDCTPKx5cJa42wlEQfD7EpJqjgaTQqpWuv2+WDIX63kRD2joiuJexsfaSc5rB3LTvFRzj0/GZj3OSSQDdgSm9+ZmVgXh/SvKRJ1yTvcugI9TeXT7UVWBwCqvVd1vEZd2XegOKOaLxuS1qAW0+dIdyS54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l5NGDLQA; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l5NGDLQA" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35daa02ea08so414588a91.2 for ; Sun, 19 Apr 2026 04:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776596584; x=1777201384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pFPV09e5vgRJrLGBoxQYyojuTqO2sidsKfMnvaM2Sb4=; b=l5NGDLQAumdrevlt3zuKbyYE5PvxHQD7rS7KhtmNq2Fj9CZfz+wrdOuLfYG+yRDKJc VcSKRazKIrJ+LzxiYAOdCrSh71hd9ITkuhv8MT/drlqm1GUxcYqMIbCFXhb3W4HZiNII cSGF8ZORODHsFGOib28h9OrU4/UgyEs2Lg1mgVi0+i0W4FznXHMS1jh2/z2qrcqvG0/g UgoBAFLqRk2wQ7u42s6lEYvsJDOwusAAUNEyUos7fUZnaAw7GONRkFUkY4CgPYCnLXso rzCFfR3oLi1ZKHRq50reCZYxFyKTb7ZtXhpnMn2XQ+nIlsKTQHtQpLCmTH0P0+xsGWzF CTQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776596584; x=1777201384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pFPV09e5vgRJrLGBoxQYyojuTqO2sidsKfMnvaM2Sb4=; b=ZEbVkjTC7hU9shGTg5bCqUcK2uQHz5r7LM50uJLj3BYWQAy/w5Pt6PlI1POU1DYmcv WsfSfHY4EJRaWd7McERHauTaRUTqqmecXR9ENEyo5/pVBkv/OKsjPMwQ9yWkVkJtWCQX yZXMjRtGgaN9jcwZerilwksui34ShxIXXg2KroRNK1l8NP4aHhDU7j53JOMl7DomDInx lLdEmoTxD/J4kEuRvSnjcjqbXjkolg6QVi3cSSk6WVlAzSxnuGHoizmXSian7VkYeSRi qua3rDrJkXziiiwNfRzA/ZxGgObb3Z17ZVmkv4LeN4Q4B6J2HBBvEqMuy71n0gMlnQWw KSfA== X-Forwarded-Encrypted: i=1; AFNElJ+twwFJv2q+QcM/PG8C4Gpk6y5Ez+2sclrHGzbwSCLdp80+ABmZirqhv5J8lF6bMindD9VCRo/DTJ4gr/s=@vger.kernel.org X-Gm-Message-State: AOJu0YzjvCzbL+vZ34av9sIQSaE6Ik+BvnNbdI6Q1pSOVB1U7VrS5cCT 5ZbD6gW3j1UWyPLvDDGD0jM6UEjJHFvDNQK3vdNAmWz5d8lztMFA8XLt X-Gm-Gg: AeBDietk6C9yGdQeuBHBzdUZ4xDh1Uoc26q82wqFRoGBS91Ypz2wq2jMBAMAsRJIs63 m3zEn50b05JwivhGLROi+pb+ndU7Tse64sCHdY3fJ4wwAwyGEOg3icZ8Qm8U5VSvJRiXi+clPvG xxfZeuRs7C6Dg/dD3XB9O3c0fuk0fYwTSkTIj3MyzcIyTV9CWl134YC3T1G4kSU+LJgBh7QDp3i DwsYggYjFrhuXcX8vU839kIYYZW1+RbEIgSd6SAcL6P6VLt3HjT0V0xlvCzbwL8FiQ4KVI99JYk Ib2Z1QkYlEnQNDnsMOsra0Xj7vkEYM3xi9ZMzM5z2V0GPvUP9HC4LApH6rIdEXn2TD+eTw24kbb y/A2NlZriLUyGtvIbdqRi5XAchDvtYdssAIESe5QEYDy8IXUhMymuXsBXJYK8dprt94BIZ2dL9T sgTPqv/GI5hW/DQwAQlBmc/gjSYkY= X-Received: by 2002:a17:90a:d604:b0:35b:94db:fdaf with SMTP id 98e67ed59e1d1-3614044f697mr5319706a91.4.1776596583718; Sun, 19 Apr 2026 04:03:03 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797703059fsm5527972a12.24.2026.04.19.04.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 04:03:03 -0700 (PDT) From: DaeMyung Kang To: Namjae Jeon Cc: Steve French , Sergey Senozhatsky , Tom Talpey , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, DaeMyung Kang Subject: [PATCH 1/2] ksmbd: destroy tree_conn_ida in ksmbd_session_destroy() Date: Sun, 19 Apr 2026 20:02:54 +0900 Message-ID: <20260419110255.2477785-2-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260419110255.2477785-1-charsyam@gmail.com> References: <20260419110255.2477785-1-charsyam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When per-session tree_conn_ida was converted from a dynamically allocated ksmbd_ida to an embedded struct ida, ksmbd_ida_free() was removed from ksmbd_session_destroy() but no matching ida_destroy() was added. The session is therefore freed with the IDA's backing xarray still intact. The kernel IDA API expects ida_init() and ida_destroy() to be paired over an object's lifetime, so add the missing cleanup before the enclosing session is freed. Also move ida_init() to right after the session is allocated so that it is always paired with the destroy call even on the early error paths of __session_create() (ksmbd_init_file_table() or __init_smb2_session() failures), both of which jump to the error label and invoke ksmbd_session_destroy() on a partially initialised session. No leak has been observed in testing; this is a pairing fix to match the IDA lifetime rules, not a response to a reproduced regression. Fixes: d40012a83f87 ("cifsd: declare ida statically") Signed-off-by: DaeMyung Kang --- fs/smb/server/mgmt/user_session.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/smb/server/mgmt/user_session.c b/fs/smb/server/mgmt/user_session.c index a86589408835..0dd9e6c976ac 100644 --- a/fs/smb/server/mgmt/user_session.c +++ b/fs/smb/server/mgmt/user_session.c @@ -391,6 +391,7 @@ void ksmbd_session_destroy(struct ksmbd_session *sess) free_channel_list(sess); kfree(sess->Preauth_HashValue); ksmbd_release_id(&session_ida, sess->id); + ida_destroy(&sess->tree_conn_ida); kfree(sess); } @@ -665,6 +666,8 @@ static struct ksmbd_session *__session_create(int protocol) if (!sess) return NULL; + ida_init(&sess->tree_conn_ida); + if (ksmbd_init_file_table(&sess->file_table)) goto error; @@ -684,8 +687,6 @@ static struct ksmbd_session *__session_create(int protocol) if (ret) goto error; - ida_init(&sess->tree_conn_ida); - down_write(&sessions_table_lock); hash_add(sessions_table, &sess->hlist, sess->id); up_write(&sessions_table_lock); -- 2.43.0