From: Maxwell Doose <m32285159@gmail.com>
To: ak@it-klinger.de, jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] iio: proximity: srf08: replace sprintf with sysfs_emit
Date: Sun, 19 Apr 2026 10:58:06 -0500 [thread overview]
Message-ID: <20260419155806.208741-1-m32285159@gmail.com> (raw)
This patch replaces sprintf function calls with sysfs_emit and
sysfs_emit_at. This removes unsafe functions and makes the driver more
stable and modern, by ensuring that boundary checks take place.
Signed-off-by: Maxwell Doose <m32285159@gmail.com>
---
v2:
- Fixed indenting of sysfs_emit call in function srf08_show_range_mm.
- Optimized return sequence in function srf08_show_sensitivity by
directly returning instead of modifying a variable and then
returning.
drivers/iio/proximity/srf08.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
index d7e4cc48cfbf..604e89f89fe3 100644
--- a/drivers/iio/proximity/srf08.c
+++ b/drivers/iio/proximity/srf08.c
@@ -226,7 +226,7 @@ static int srf08_read_raw(struct iio_dev *indio_dev,
static ssize_t srf08_show_range_mm_available(struct device *dev,
struct device_attribute *attr, char *buf)
{
- return sprintf(buf, "[0.043 0.043 11.008]\n");
+ return sysfs_emit(buf, "[0.043 0.043 11.008]\n");
}
static IIO_DEVICE_ATTR(sensor_max_range_available, S_IRUGO,
@@ -238,8 +238,8 @@ static ssize_t srf08_show_range_mm(struct device *dev,
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct srf08_data *data = iio_priv(indio_dev);
- return sprintf(buf, "%d.%03d\n", data->range_mm / 1000,
- data->range_mm % 1000);
+ return sysfs_emit(buf, "%d.%03d\n", data->range_mm / 1000,
+ data->range_mm % 1000);
}
/*
@@ -316,10 +316,10 @@ static ssize_t srf08_show_sensitivity_available(struct device *dev,
for (i = 0; i < data->chip_info->num_sensitivity_avail; i++)
if (data->chip_info->sensitivity_avail[i])
- len += sprintf(buf + len, "%d ",
+ len += sysfs_emit_at(buf, len, "%d ",
data->chip_info->sensitivity_avail[i]);
- len += sprintf(buf + len, "\n");
+ len += sysfs_emit_at(buf, len, "\n");
return len;
}
@@ -332,11 +332,8 @@ static ssize_t srf08_show_sensitivity(struct device *dev,
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct srf08_data *data = iio_priv(indio_dev);
- int len;
- len = sprintf(buf, "%d\n", data->sensitivity);
-
- return len;
+ return sysfs_emit(buf, "%d\n", data->sensitivity);
}
static ssize_t srf08_write_sensitivity(struct srf08_data *data,
--
2.53.0
next reply other threads:[~2026-04-19 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 15:58 Maxwell Doose [this message]
2026-04-20 9:04 ` [PATCH v2] iio: proximity: srf08: replace sprintf with sysfs_emit Andy Shevchenko
2026-04-20 12:48 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260419155806.208741-1-m32285159@gmail.com \
--to=m32285159@gmail.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox