From: Sean Chang <seanwascoding@gmail.com>
To: Benjamin Coddington <ben.coddington@hammerspace.com>
Cc: Jeff Layton <jlayton@kernel.org>,
trondmy@kernel.org, anna@kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sean Chang <seanwascoding@gmail.com>
Subject: [PATCH v3 0/2] NFS: fix RCU and tracing pointer safety
Date: Mon, 20 Apr 2026 00:31:36 +0800 [thread overview]
Message-ID: <20260419163138.26963-1-seanwascoding@gmail.com> (raw)
This series addresses two Sparse static analysis warnings in the NFS
client related to RCU safety and pointer attributes.
The first patch resolves a "dereferencing noderef expression" warning
within the nfs_page_class tracepoint by removing a redundant __private
attribute that was causing Sparse to complain during trace-buffer
assignments.
The second patch fixes an RCU-unsafe dereference in nfs_compare_super_address.
It wraps cl_xprt access with rcu_read_lock() and rcu_dereference().
Following reviewer feedback, the RCU critical section is kept minimal,
covering only the transport and network namespace checks.
v3:
- Patch 2: Removed the redundant XPRT_CONNECTED and pointer existence
checks as suggested by Benjamin Coddington. Since the comparison is
performed while holding sb_lock, the transport's existence is guaranteed,
and its connection state does not affect the server's identity.
v2:
- Patch 1: Instead of changing the 'req' field type to unsigned long (as in v1),
simply remove the redundant __private attribute. This resolves the
Sparse warning while preserving the original pointer type.
- Patch 2: Reduced RCU read-side critical section scope to cover only
the necessary transport/net-ns checks, as suggested by reviewers.
Sean Chang (2):
NFS: remove redundant __private attribute from nfs_page_class
NFS: Fix RCU dereference of cl_xprt in nfs_compare_super_address
fs/nfs/nfstrace.h | 2 +-
fs/nfs/super.c | 16 +++++++++++++---
2 files changed, 14 insertions(+), 4 deletions(-)
--
2.43.0
next reply other threads:[~2026-04-19 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 16:31 Sean Chang [this message]
2026-04-19 16:31 ` [PATCH v3 1/2] NFS: remove redundant __private attribute from nfs_page_class Sean Chang
2026-04-19 16:31 ` [PATCH v3 2/2] NFS: Fix RCU dereference of cl_xprt in nfs_compare_super_address Sean Chang
2026-04-21 11:00 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260419163138.26963-1-seanwascoding@gmail.com \
--to=seanwascoding@gmail.com \
--cc=anna@kernel.org \
--cc=ben.coddington@hammerspace.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox