From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9CFB2D7812 for ; Sun, 19 Apr 2026 16:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776616308; cv=none; b=a7Kkb3Gtdz38Ic8CP04D2AEZdwuUR/9Jv9o8hrfQzujTRNWzVMJ0+FAX6kZCQhHWT2fL6YiaMhHRgatSN8QxUI3F7hk9XaNedpF/YWMBsbXnYrn7KZrke89JjazI7fjpiwjvYbqhdSdsXuP8ZtT2MyQn6KzKkjvXBLtxQKv8Rec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776616308; c=relaxed/simple; bh=NL7/rpUFZgcXfFXM3mLGmeyhHSstJj05hAh1BkI2xWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kPQVbnkDsIBgz7RAmJw5opNfh0tDf+/v5aiD7w4Di2JqWWsCLs5X2L6niIbf9zZHmm3oDD9+TShBxVfxqJQVngQYDxpti5hAYQe+NT2MyAjMnhkzB0YDT/fi/B4UmTAldAU/8zvjCLHukRGRQqR94+3p+8nWtw7ITqfy6AYOXs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hvjc1NdP; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hvjc1NdP" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c7961d7bc09so746889a12.1 for ; Sun, 19 Apr 2026 09:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776616306; x=1777221106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IYB76730a2VnObmOSGsgG6RhIK7mfAkEXznIiOrB1/E=; b=Hvjc1NdPSc67F7HAWxe6IAHl/aUX6hamQdsN0Chy7FHLxQ6xRSJhF1C9k4q1ecFE74 5Gl2Xm4p9ga1v3M1Yb9NMQcnQz0ISduMB4fNvOLE9gWLfThQk74/lPfR1QoT4mdejA+H Jiyr+7W9Gzfxld37MyOnEVrSiU7wzKPlVVfpUfhyrYyv2/oXvs/NKpBp7dfEaY9UcGnj I84UAVPlupC5n9BGH8XFr1BGnu7d+S1gVTNuN3kJa0ZlFcBHqw5UbYjVFouPxeOU03id MRat5S+ZvTtswNX1mw720qsAq+6cvh8A10qFnTs67O8/oOtYRMgE11FaBcw2EmhVjNkQ C6Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776616306; x=1777221106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IYB76730a2VnObmOSGsgG6RhIK7mfAkEXznIiOrB1/E=; b=WixupgI1yyI7XPmOQZ6PaWfhh58AZY+M23UG9sdi200OOac/L9CiuKXKe+bBl3vht2 v+c86S41TJLkS58S/tr0kgQDMlTAVX7En6BTr8+9NmfhHVGLBeUy6yVr76TJxa9S6yKJ VV2kDTlkdCQmFhgR86M98RL8XKuOV7yiCxnXefm1jIQqJcdu0+Unm2JYzEuYA5hA+nky bXOjITqzpuB5d+gnxQBSZVF9fknQg+l5Lfoda7TYbyYbq6wGJFPI5/k9DMoOBaSbLOl+ Rwcp5sr0WD1vabshrJtyGjdvmgpTzPTcW24YUp++10+Rw6kloVOAqROnUfTaGtvmyLku xwYQ== X-Forwarded-Encrypted: i=1; AFNElJ/d9a4YTXOGmTSsWxOY9Kvqp2Ty//iDOcE3ASyKYUZZlWnaCT8qpOr30z8MNzvEsOqthzRSik1Qh8a4aOg=@vger.kernel.org X-Gm-Message-State: AOJu0YzdCZgeJJRjbUhZuMC+pefy3IsHtO+Vw6CCAbtZ6v52aJVqvpNQ uSw4eGWyAOHl/KpgCy9C1RR0lVum1hAiPB+dXIH/6OdvNE59Rbc/NRae X-Gm-Gg: AeBDieuZzXdzfaGdmLDX9iOj/5qAVzEcEUAy3SqatYFdIszEAPJ7M7QEjTxjlBcTXyJ k2QzgULrBlChYyHxxZ5hbM0ev0ANbklgNyEv5GNScTQud251tpzdg9NO0eRAU8T5SQ8OWQUE8kB KawFkXbKu4wjjveC+CtFf+NCl+QXN+CZ7wQgqIDJDqd2QXvS+as6MZs4y2biGS59HtWUW3GVG3i l6x5WvYl9TenfaaU7nKQHopwhcNF/nKd9heQPeqnXA9o4LQhalSGpz3vISTKiB2SayPs4ip2+tS xFf4VipdGZYZ+Yq6/iYvOno/unhpJNpoRfi0oJ0+GncGyrpBJ+w9qEa041ODJW79labvl+PPmqd caWJNOvbx9z1A+37U372Kx2zTtz638yJ8eKr2VwxwW0HbAc5+xheLStWZCHS9RYOq2gWDd/ujiR 7Zclxh8fy5nkNwWf7Bbqm6kaTHOilRdU9I3X0L4dRB4fGHmnnezpn+DmmSD93iYWl2y8D5urHgO SDc6ZRrB8jhoOnl+6n+ZAk8/fOFvA== X-Received: by 2002:a17:90b:3c8d:b0:35a:18b1:c245 with SMTP id 98e67ed59e1d1-361403bd142mr11178841a91.3.1776616306029; Sun, 19 Apr 2026 09:31:46 -0700 (PDT) Received: from localhost.localdomain (1-160-233-238.dynamic-ip.hinet.net. [1.160.233.238]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-361417748aesm7814196a91.0.2026.04.19.09.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 09:31:45 -0700 (PDT) From: Sean Chang To: Benjamin Coddington Cc: Jeff Layton , trondmy@kernel.org, anna@kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang , Benjamin Coddington Subject: [PATCH v3 1/2] NFS: remove redundant __private attribute from nfs_page_class Date: Mon, 20 Apr 2026 00:31:37 +0800 Message-ID: <20260419163138.26963-2-seanwascoding@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260419163138.26963-1-seanwascoding@gmail.com> References: <20260419163138.26963-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The nfs_page_class tracepoint uses a pointer for the 'req' field marked with the __private attribute. This causes Sparse to complain about dereferencing a private pointer within the trace ring buffer context, specifically during the TP_fast_assign() operation. This fixes a Sparse warning introduced in commit b6ef079fd984 ("nfs: more in-depth tracing of writepage events") by removing the redundant __private attribute from the 'req' field. Reviewed-by: Benjamin Coddington Signed-off-by: Sean Chang --- fs/nfs/nfstrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfstrace.h b/fs/nfs/nfstrace.h index 9f9ce4a565ea..ff467959f733 100644 --- a/fs/nfs/nfstrace.h +++ b/fs/nfs/nfstrace.h @@ -1496,7 +1496,7 @@ DECLARE_EVENT_CLASS(nfs_page_class, __field(dev_t, dev) __field(u32, fhandle) __field(u64, fileid) - __field(const struct nfs_page *__private, req) + __field(const struct nfs_page *, req) __field(loff_t, offset) __field(unsigned int, count) __field(unsigned long, flags) -- 2.43.0