From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B226C1A704B for ; Mon, 20 Apr 2026 00:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776644733; cv=none; b=sKtWhdlqItg8cCXhxP3+EZhiND34xd776lpmXv7LQmBG+jg1Agasv7VvYav0G8h+RTFrYIHdB6YP0fG7p+q17HG7173Uu0fgg/HdtC91hmChb6pUfnRnupdUd1Nkc29sCmcz+FZ8AuKsCzcf7x11fEh8hn6E7ItAnohc/h+Kwkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776644733; c=relaxed/simple; bh=2Todk00zQ6cG35V6362z9OGX/TDC+qA9QjRrqGoreTw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OQbzwyXWrkV+GDbz2CKDrqzok16QffQtixdj481mhb19QypWLRAYDZOc/W/UK282Tr624ZjyCxK5EXCWkcFIMt/GF9XmFGtCBk2vtX0WA7SdjClfVZpZmuAIWnZuqtGYage+gFe81/vbnpjNc8uZ9N18IhrAesdlIeQejDwHiA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XKTvSIfL; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XKTvSIfL" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-50d8da3e656so29677911cf.1 for ; Sun, 19 Apr 2026 17:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776644732; x=1777249532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pD01rqioldlYsrskZpVddZZVgvRR2M6kER/Afl9Dngk=; b=XKTvSIfLy4DWuWdRZwWx5QlCsn1fWRRZCsvBF4h38OpmFzCR7rDmcTWHlPNW2v/bVq BlMWxcjDTGGa4Rj/1MnYSGvpYvzUPzCSvGpQvXI72zdS6a84xCObj1kb/riYRJuLbGiL PtXL8SXa+7fgRlwmlgTSpNpEUaSh1BoBZBtod9ExOCX0pc0X0H9MrxGaK1lGCHg/ICSJ YgCTlNioGnreTfXzYQutUJzLCPmRwFeeJGDNoRXkG4RLY8oPw/8lj/9XXiZenOStH1UQ nnuxtF84QEFgVlxqnsqtELDL1uoC5CCG2twELWrhfFX8yuJI7fwguW/z+0egMRHmFbk4 oG+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776644732; x=1777249532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pD01rqioldlYsrskZpVddZZVgvRR2M6kER/Afl9Dngk=; b=HqVtfddrlu/pH6Pqrf/o/NzetqhRXjf/0sMXq2EtaaIoFueEQO3eKeuEH4YviY+UTF u831ux6O46VIFYY1wjipwK20aodPxjC5sCQfFX6D69lx4ghXRlRRSTJy7YqW5fi6PmVP etJ9fQs3aGCXzWiZReSC+YNcc1fNLPqEK8mG+t/k4IuXxVC1MQ00Vl+A5wJ7OPjvJ3KF 8XsepOsoJr9y/UBT0oYzx1i5mUZPlIszdN1uJVjZwWQZ/a6u4p0XMFt6NLkCFs8fYVo2 QTwMRERCjjG4QKZAczuZsm5VqWsl/q+1BzGYHtwoqysDD+KYZ7LswAlUbbQ9Og5YM96t AX2w== X-Forwarded-Encrypted: i=1; AFNElJ+uVCeDznn++CDrZZ2J9+8rJ+7TkG1YOLj8452cQl80tWs2raAFiaTr80fKRTUZ5iSnaXSHG/fCRbh8QEg=@vger.kernel.org X-Gm-Message-State: AOJu0YyQxu2fKfbB9Ksbdw8WtO+KPMDpUlWkohqcmFFVMlVReq2QmGL1 srIVoG1lvCDsCZ9kysKrew+zB2vkt0m0LcBTaXu+oKHE0rB5IUtOezYH X-Gm-Gg: AeBDiesoTZ/IYyLWKQayFIByLqbYkX6RqvOT/XnIo5smiGmp1kd15Z6JtAWWMOSV2by a7R4FnlLq5uT0nb4zX1cdc2iZYqwk6HcBTFRUJzETCyTs+yZY9NM2IxBgwmLZCXipJU3IHOORIC ZNmV9NIxNhOusYuskwxufoXRKkKfCjYUyXwIbXQvah7rWyo2HjPtIHHcGfZo+MXPFblUVxywfWS XAQUdxv78c4VST3+kVc0p1/VhdjJJxvVVaP0a2Hz1KbxS94737KafL+757L/jPuSuo5bY7+wFTQ MKLC0K+KW6D2x/e7SWLXuaZ08qKDmCDejqrN2UKtcnVFrotyXeNynJIa2VScDBX2Dihd2CvUP+Q LOzwKOG3dXRWATbQqH9FwnDLavclUMmK7fvzUXQ21LsxcVPTAABZ18evWnJ1PZlPhhovh/nLaKi rhyYdaDf9rqNnzcXfXVA3YDBYsr6VKeShmoRB5bbO/bGBGykx1gPh6iaBxX0WuREWMpPunbA== X-Received: by 2002:ac8:7c56:0:b0:50d:9b07:9c2b with SMTP id d75a77b69052e-50e36c8da62mr179916521cf.56.1776644731742; Sun, 19 Apr 2026 17:25:31 -0700 (PDT) Received: from localhost.localdomain ([165.85.38.136]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50e392c7994sm71923961cf.4.2026.04.19.17.25.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 19 Apr 2026 17:25:30 -0700 (PDT) From: Yuho Choi To: Thomas Zimmermann , Javier Martinez Canillas , dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim , Taegyu Kim , Yuho Choi Subject: [PATCH v1] drm/sysfb: ofdrm: fix PCI device reference leaks Date: Sun, 19 Apr 2026 20:25:13 -0400 Message-ID: <20260420002513.216-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit display_get_pci_dev_of() gets a referenced PCI device via pci_get_device(). Drop that reference when pci_enable_device() fails and release it during the managed teardown path after pci_disable_device(). Without that, ofdrm leaks the pci_dev reference on both the error path and the normal cleanup path. Fixes: c8a17756c425 ("drm/ofdrm: Add ofdrm for Open Firmware framebuffers") Co-developed-by: Myeonghun Pak Signed-off-by: Myeonghun Pak Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Co-developed-by: Taegyu Kim Signed-off-by: Taegyu Kim Signed-off-by: Yuho Choi --- drivers/gpu/drm/sysfb/ofdrm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sysfb/ofdrm.c b/drivers/gpu/drm/sysfb/ofdrm.c index d38ba70f4e0d3..247cf13c80a05 100644 --- a/drivers/gpu/drm/sysfb/ofdrm.c +++ b/drivers/gpu/drm/sysfb/ofdrm.c @@ -350,6 +350,7 @@ static void ofdrm_pci_release(void *data) struct pci_dev *pcidev = data; pci_disable_device(pcidev); + pci_dev_put(pcidev); } static int ofdrm_device_init_pci(struct ofdrm_device *odev) @@ -375,6 +376,7 @@ static int ofdrm_device_init_pci(struct ofdrm_device *odev) if (ret) { drm_err(dev, "pci_enable_device(%s) failed: %d\n", dev_name(&pcidev->dev), ret); + pci_dev_put(pcidev); return ret; } ret = devm_add_action_or_reset(&pdev->dev, ofdrm_pci_release, pcidev); -- 2.50.1 (Apple Git-155)