From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFAF213B584 for ; Mon, 20 Apr 2026 01:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776646893; cv=none; b=IotdnKHcc7XcT7IqA0lu+RwR9AUdAla72t131UA7IonaUHMqv7+yXOSTseOLUmobMbWSrTmeU5u6LH84ZvaHWN/mW7NbdfJqiZIzAQrATwRoPMD/j/JW62NLjTYbRzcguvSp8rZZhjZxhIqDFnMTAME/HRUJ/t/WZhBHFimYnR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776646893; c=relaxed/simple; bh=CAFACS5bc7bNOjL5ZrwKpBgULCMFmthkCdlQILDVQP4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nH3eUlbs2xl798S2E27yOwlk/iTyr6R+ckVYImScwV595U+1gUKz1Ye5u/gSstI2CwnUM7DVtTw67Xc30d7WIzHm/uXkPhgCdj4oCndvhIFmszNcrN8DXp8VTS2jSeq09/P665+CodAcpBD+vRBCjE/LaFum6QQyDtE+wy1oCqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bA1eIMk7; arc=none smtp.client-ip=209.85.217.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bA1eIMk7" Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-610aadb2d9fso779640137.0 for ; Sun, 19 Apr 2026 18:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776646891; x=1777251691; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cExEE0g/VkjWFezfORG8uwyZglaid4Bs+rAW28gYyow=; b=bA1eIMk7KL5A2M36QGuPVDOcJ7p6HC94JffrgYzFJYBwPItqN4bm1nZiQt3a/68uyl 9KJKHMXhe6tmud9IfmI2i59u8zviB7RaZv2rnxyTzQMisXopDO/ypxgbmM1/tGobzd4J 4e/HB8lnHHBYrgZaWYwNPZjpZ0EFv3IFmz7unYIBJ3DoJVeExuG6ZrQ78gmiZELegesl Bn+4O0dFbzeC72AHWmk/O/brc3URqdAMBmJbmvyVd12K5MQuhlWPgkkZYgqf/6LGEC4x w8naRsPQMOyk0rYiWddcoTikiqnBq6pD2k1POKg8BItPNGtyItjhH5MLQ18nGYhAfDXg UkvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776646891; x=1777251691; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cExEE0g/VkjWFezfORG8uwyZglaid4Bs+rAW28gYyow=; b=mmmtngsVqv9wkSHQRAxoq0jKNkrvBLZPpd3fGEJ0+21iK5GVHzulr1tyXj1ISI+rm7 geRz9gdSaX+SNsvb4XGyT6TVM0zm8YI0pJikJcef/jV8qMG+I/B/6MSBDQJ1o3uYh9gg 3Oh2i4xg4CoRi7DimMlfGuUVRUZi0Sn+16D246c2qNq8+FbkD8Oe7qpAcZPpydUBuhKf pjigoJdH7rrHgjoXQxFHfHu/rGoe5YXqRkF1qOpBsvIGBixExQylohUJHDmRAvgyL1ks KxaVTDeDgA/C9o7bjcdFSI8fg72mg6Cyv5elb3YFMKYdXky+darjBEn7+ykge1tmUFhB wwog== X-Forwarded-Encrypted: i=1; AFNElJ/Csc5ROfN2xzpK+/naKJKNxhaTWsTHXggc6SYJ/prbXruwnPVDyYgSUCCz2U9sOaAVpEq0nOfmHYzcLrk=@vger.kernel.org X-Gm-Message-State: AOJu0YylbWy2TXlvl4wyaiIfvRCx0C0/j/YvT955SZQr1fw9Py5moDf8 dbKacaJY6IJiOtS4hW3jxzJ2S5j/mPYyLrmhEiLgsCYuE2pKqkgJ7TEQ X-Gm-Gg: AeBDiesUlFijTQbDXkKrWYdAf/tjQ5ArWQ8e6Bmx5Gv8N1wXf5IdoBw3VeYDHf0RORj CCRNk/+oSdg5YjsIyMljYpfGl1CpInUnYOCBzeutPjlMyBbmYj0P/XNLgGu8nmMZlZgVFyLV7YM 9ZmoXFLbS6jhj/oijsOmWWaJnLmszN+ODXLCZZJMwL7OiIKgPD79H+88HVzuhH7EGEwy70NEUlK U3AKCWNeaA80DWd2MIWZdL8p/3dkNf8kACLc4wAkXxArX+NPqGbdq+46TFTQT3Mt3Jhv0XVks7h 1jzBTsf/MEspUhPq4K+gMM3AvcU8WQjtTGAn7hqxHGhL4hI2aRS01B6qdezJ9UWpU/D47gW5v9J 2hYPWz3lGMRpTgdKg2MxfTzbFWNEYqy1Ux34kbs4dEumhRKN8ckVLQN17HKYDhykwgomiAeNUpS 5xMMGW8aAwt2USLRBWGXDITM5tDAAUb6z/gzj807q6I6Sg0iuyIYEVY/ktxTk= X-Received: by 2002:a05:6102:6c9:b0:607:f24a:1bef with SMTP id ada2fe7eead31-616f60b3913mr4269910137.13.1776646890798; Sun, 19 Apr 2026 18:01:30 -0700 (PDT) Received: from localhost.localdomain ([165.85.38.136]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8eb9becc6c3sm44376885a.39.2026.04.19.18.01.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 19 Apr 2026 18:01:30 -0700 (PDT) From: Yuho Choi To: Helge Deller , Jason Donenfeld , linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim , Taegyu Kim , Yuho Choi Subject: [PATCH v1] fbdev/offb: fix PCI device reference leak on probe failure Date: Sun, 19 Apr 2026 21:01:18 -0400 Message-ID: <20260420010118.17960-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit offb_init_nodriver() gets a referenced PCI device with pci_get_device(). If pci_enable_device() fails, the function returns without dropping that reference. Release the PCI device reference before returning from the pci_enable_device() failure path. Fixes: 5bda8f7b5468 ("video: fbdev: offb: Call pci_enable_device() before using the PCI VGA device") Co-developed-by: Myeonghun Pak Signed-off-by: Myeonghun Pak Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Co-developed-by: Taegyu Kim Signed-off-by: Taegyu Kim Signed-off-by: Yuho Choi --- drivers/video/fbdev/offb.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c index f85428e13996b..166b2dff36f59 100644 --- a/drivers/video/fbdev/offb.c +++ b/drivers/video/fbdev/offb.c @@ -640,8 +640,13 @@ static void offb_init_nodriver(struct platform_device *parent, struct device_nod vid = be32_to_cpup(vidp); did = be32_to_cpup(didp); pdev = pci_get_device(vid, did, NULL); - if (!pdev || pci_enable_device(pdev)) + if (!pdev) return; + + if (pci_enable_device(pdev)) { + pci_dev_put(pdev); + return; + } } #endif /* kludge for valkyrie */ -- 2.50.1 (Apple Git-155)