From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4B1537FF57 for ; Mon, 20 Apr 2026 04:27:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776659260; cv=none; b=NJFpFdZHqKk+9HtyeenxnBfJX1p5H0DJY0Yl4MTP4mHy0x671Z51FE5tFteK5upZ8baYJaXnD5+sqmosA9UOiYq/xWShVhtlUVQt/poHOLHJxsoh2bGvy+khhpONeTX3Zfah2ZqMSogKt2obtqn6UZlEIZNpFJruvfDpRGI9rJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776659260; c=relaxed/simple; bh=UXuC3HT4ZRVzNuH/eMOOnxvBOw6om5rKv8yIGlsCNzA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XFF/jYuu/7mra6RTErYe/pbesLIxGnHe8VsktEMVd9E7lppPty5sITJ5F1RJcc9rH/Fp8wx2aiJy+nKt753lKWN/7LdgE7HMRzvHSjqebfZehpghteUe4lgtufX8lzkNq0UaLquUyVOQrBQPnbLxOO/uzf/MT6QczcYHj1ANEWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PO17/5bb; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PO17/5bb" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-8a58057d7baso33930136d6.1 for ; Sun, 19 Apr 2026 21:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776659258; x=1777264058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xwJCgiVgC1aHzj9fgm9AjJI13G+o5uSok2wZI6YyOf8=; b=PO17/5bbULXjyfJPAaElyUaGRoTqLQP7NN/uJS73qqvm957S7C0BVoGwkqYVcLzmf5 qnhrwGm73FX8SfnvzL9BHh19wPxDiuWlF7DPXhkHFO/Kf2noUyd1Y4jfISlgfHkvAA60 xm4nRz1pVp1AWkYZyD1uNV9s6fetir9pOAvVylmEG5r32QBtlsKj6cEZpN5hlzD8Klxh mW3cLPwkU6hVjEvSM7jCVP3zLP3qQKiVzrcseLN+kq0xroavb9UKHD1PqEUo+Hhvdcy2 yE0lUYnvHnJTQAHgSvS6hHS6tl3ogn/Cs/cNMmFji4HQMazj6Ia6YRVo9BO0N8D5Mtct ljjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776659258; x=1777264058; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xwJCgiVgC1aHzj9fgm9AjJI13G+o5uSok2wZI6YyOf8=; b=kq1rDb12TExnQFmd3bkL+td3OUCpR7oJ0UfVdAkc8b8FZDzPav6mxWpaRqq5yNCLZV WONscAwFPF13/CS831V4i2jAJYxmrEwcBQknIQd/tY5q4b4HpJKUgXdrFygZNoaF/q/f J6FF95TOZpvrvNXUubtSz9oPrgs2kKDuiSyhiMMNjJ3clFbeS8aiJRegwVsuqyWXUR0m Rmo4xv8YXXd7JQozqgIoOTijfR4JY6jFbLS0IO2Kqn0JqCyL53IvCHhGugtUb4cctGX6 g6gwftGX0wHCUanI04BvIz6T3eipb/qM6OL/t6asqo0phA5HjmNOJxrV+X5gYGJCGS33 z3EA== X-Forwarded-Encrypted: i=1; AFNElJ/ECgMS8vwvJe09LdNTnNOC2L90MddvErP6YG/MnfEKZIm1pb771WDLxchq4PXj9ESkprP51Mh8BYRfIq4=@vger.kernel.org X-Gm-Message-State: AOJu0YwMdY3LR8x+kaQ1j5jUN1/AuFz7lrocSQJAMR/SagsZ/XoxLamt LtUjHlJX5vb7J+SHdykM1dr66CnSD1PYWsWnGgjev9CFcXsYXgn3d2BB X-Gm-Gg: AeBDietL+c1wYXDM7idQMkJKfHJqlo/WDTwm/pBdDMkuhwS0EXbgSPIxWGNUyMLP1w4 t2Q9GeW92QHu4O+9XSsoEp9gSjZq3HtepoxN0DglbL6SChrFvXLnB1bzPpFmxPd4hwzRnw/gm3M nTXWgNftr0upSHlZJdw2IRhYz2A/itfSybMMQeCZjn+g3BW12wGjeEDPeB8XisHzL56u+cpIpP8 Uoxnzp4hu6MvlXngDHdmjTLolNfcu+9OMmuBejsIwmZFLZATDMLL2tg7kvj8R8C3UkCivGIDpBY HXWZj0CUg8t5IZ0CM+SQSiX6rfL8FDo5gegvSjXNuj7LNZ8frGbxMtNABKUxzzOznOKIIpNh+UX vU19JYHg490bfEaMcRBWbFcEDsvSzJ0fEbd0EJ7iBNBS948PN+8NLepQZspinMCkYtJK28StYoq AiXLw7AdmXmXogPWshbK/PY8iIIxYxGS8ONgHNFasvwwcb2ALavD+mDbq8CMU= X-Received: by 2002:a05:6214:1c0b:b0:8b0:2b9e:963b with SMTP id 6a1803df08f44-8b02b9e9dcamr192145566d6.12.1776659257806; Sun, 19 Apr 2026 21:27:37 -0700 (PDT) Received: from localhost.localdomain ([165.85.38.136]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ac429e9sm67598516d6.3.2026.04.19.21.27.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 19 Apr 2026 21:27:37 -0700 (PDT) From: Yuho Choi To: Greg Kroah-Hartman , linux-staging@lists.linux.dev Cc: Hans de Goede , Michael Straube , Andy Shevchenko , Minu Jin , Omer El Idrissi , William Hansen-Baird , Ethan Tidmore , Ingo Molnar , linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim , Taegyu Kim , Yuho Choi Subject: [PATCH v1] staging: rtl8723bs: fix stale recv_frame free in recv_func_posthandle() Date: Mon, 20 Apr 2026 00:27:34 -0400 Message-ID: <20260420042734.3685-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit recv_func_posthandle() saved the original recv_frame pointer before calling recvframe_chk_defrag(). On the last-fragment reassembly path, recvframe_chk_defrag() may return the first fragment as the new frame while freeing the original last-fragment frame when draining the defrag queue. If process_recv_indicatepkts() then fails, recv_func_posthandle() frees the saved pre-defrag pointer again, which can result in a stale pointer free. Free the current recv_frame on the failure path instead of the saved pre-defrag pointer. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Co-developed-by: Myeonghun Pak Signed-off-by: Myeonghun Pak Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Co-developed-by: Taegyu Kim Signed-off-by: Taegyu Kim Signed-off-by: Yuho Choi --- drivers/staging/rtl8723bs/core/rtw_recv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 337671b1211f0..a404b6fc97723 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -2139,7 +2139,6 @@ static int recv_func_prehandle(struct adapter *padapter, union recv_frame *rfram static int recv_func_posthandle(struct adapter *padapter, union recv_frame *prframe) { int ret = _SUCCESS; - union recv_frame *orig_prframe = prframe; struct recv_priv *precvpriv = &padapter->recvpriv; struct __queue *pfree_recv_queue = &padapter->recvpriv.free_recv_queue; @@ -2163,7 +2162,7 @@ static int recv_func_posthandle(struct adapter *padapter, union recv_frame *prfr ret = process_recv_indicatepkts(padapter, prframe); if (ret != _SUCCESS) { - rtw_free_recvframe(orig_prframe, pfree_recv_queue);/* free this recv_frame */ + rtw_free_recvframe(prframe, pfree_recv_queue);/* free this recv_frame */ goto _recv_data_drop; } -- 2.50.1 (Apple Git-155)