From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D379733EC for ; Mon, 20 Apr 2026 05:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776662371; cv=none; b=j1Z8PPRQBzlq0AysucLId4aJIBR+vwN1bLkWR3urGIN8rmtvU9HNDIQGGwVJmA7I/1Rw0PwNBbDJm08zAJM/OYzGSNHtFlrgnuyo9I+plA9EiJLmpLn+t6iza0uDrGjCtKVKmQ1ToIOhhX3roOY5hl6YnewFJ7FJMi3qcRxy33k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776662371; c=relaxed/simple; bh=8kg6S8DHulB7fNhWP6eFQ6wLGKro9ckhhdhLO6BIo24=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=beUxnAW169jzRtCr1aSUg3jm0LB1QjybuZxj4jhGWXtyI4cjIRVsgunTIq1o/DfzOHG8IjRpCxriqjXAeZrYJMXjU4TwoxbuQJ4qASPceIUsweFbC1Nmfn/D/61xoN1TQFtImx2LY54JET346oCJ2XTDHaOOimaBfZwiquvuaeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=noEHpEYQ; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="noEHpEYQ" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8c9f6b78ca4so336219385a.0 for ; Sun, 19 Apr 2026 22:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776662369; x=1777267169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XVBsgs/Wk3x8UxkibJW5Haz8zZ0ewkla2R+/4mLmWr8=; b=noEHpEYQsNSyox39H81xVN2gdmBhds0+C6WYPl+Z6HLNFSc57C7CFxneAMUfgPyiwJ 2mvEnlFQ7UoQlm9Fu6MMPAMC8fXOo197CFhs7dE18hjQIbOeZkGixZfytfWp2VbOCiP7 F++cxXQK3up1L2ufyfBj7ZyaOChEWhebBKmwDgdeIHQunraKfgC0w+kpCfoi0uow5TuZ QzM4cwFEDymrJ0VhXFz2j9lnEearryQFR+XlYmGpXwDm9D24/DzFFR16qFyK/uX5OlwL yklpQoVFAVvdYhyk3W8FUCBTEkF7M4zyAj2ii75KL5o6iddwvijeMxg4qMrw8Sbe8kFx dJJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776662369; x=1777267169; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XVBsgs/Wk3x8UxkibJW5Haz8zZ0ewkla2R+/4mLmWr8=; b=qlUChZYITN/Cmw0og/iY1Ja8XtKaH00ibA2ljf5sSDdq8Ctb4KE1ohzPJgh2TqYPgv zsNFuFvxgtt1sIUjGN6zil1NVw8iNdRHMZYE5ATu/zZZkqW9x3GMrufxpIy1ZIwCJd30 e3qjrikNOYvu6vjC7ifCypEptJViwKQqdGS/SrJeu7s8b+Q9DKOvPWIEagZdHCVvE/0h CXOmkrFBJaGtpM5wVLo5j+lYc2uj0Rmk1eWk4UJB7jQLizIjiu8gwWjNrAMNlslzkNX6 nJfdonfyYDenyhQTlY+J1V1hv6+BzsiiXSUxDDpjFh4XgMjHuMcB7AoBXUg5nWSA4e5h 4oow== X-Forwarded-Encrypted: i=1; AFNElJ/I+bWAYDCpWAi0eyI9jPAH8VPplwSEq5DtbyATj6e7LvNavK3okm1WA9Ty5AIGzPv/yKIITL+DUg6Qov4=@vger.kernel.org X-Gm-Message-State: AOJu0YzLCbk6S8+cRNYqqAysel4U9bmAG/Q0q4U/ITBuQk6mwSRzeCps P4eriAQ/6ILm8wPDp+yiG+kZhDsKfar3hOAFW4abilT/wkI2myWkrX8m4OHQKrVE7G+pYA== X-Gm-Gg: AeBDiev+MnGzd/xkOH/pxsmLaNr8IsxBiOz4cHaNuSiquVKtQH7Xem2ATmIn8e8DGey aIWx3ZbEsN0+6Ls/KE/XueUBJXbjt7/kt45K7LSa9rW3wIEVyDKh40e0TUS71OptuGYiTSxUtjJ TuUmKwXQkJQ3cYopnXVIZPDBycRj8eL/3K2c6jteTTjAILzAOLfDtgafoffqOJzW7LEpVscQoA7 BlM8sTV1iNkI2hFtl2G1N4igPc7ZdVxx11kIuuSnRigc2tWfjwa7hJZHOdyEkeV7ZQzJ59I3Ofz 2na1YG9c2XkvcYB0hg278NbzxqMSHJKsU3vKo+VoBA0kHGCgToADp8nCtSfCZQ6X6eI591P6P6V k2ChJQUWJNcP6wq0pNU/PortrdE4dovGT2lL5KUF7uPaDzUVvUwlNrXnphkphyxh+dj+aCBomPl LpPWT8S7uGHJiIPbZo+flCGsEZEI7WZ+NtJxeEbNxFSvl8fgdIsCJh7qMdscA= X-Received: by 2002:a05:620a:2913:b0:8cd:94f9:1bb1 with SMTP id af79cd13be357-8e79010e10emr1688870285a.27.1776662368751; Sun, 19 Apr 2026 22:19:28 -0700 (PDT) Received: from localhost.localdomain ([165.85.38.136]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e7d99c3c17sm726161485a.45.2026.04.19.22.19.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 19 Apr 2026 22:19:28 -0700 (PDT) From: Yuho Choi To: Antonino Daplas , Helge Deller , linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim , Taegyu Kim , Yuho Choi Subject: [PATCH v1] fbdev: savage: fix probe-path EDID cleanup leaks Date: Mon, 20 Apr 2026 01:19:26 -0400 Message-ID: <20260420051926.28276-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When CONFIG_FB_SAVAGE_I2C is enabled, savagefb_probe() can build both an EDID-derived monspecs.modedb and a modelist from it before later failing. The normal success path frees monspecs.modedb after the initial mode selection, but the probe error path only deletes the I2C busses and misses the EDID-derived allocations. Free both the modelist and monspecs.modedb on the failed: unwind path. Co-developed-by: Myeonghun Pak Signed-off-by: Myeonghun Pak Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Co-developed-by: Taegyu Kim Signed-off-by: Taegyu Kim Signed-off-by: Yuho Choi --- drivers/video/fbdev/savage/savagefb_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c index ac41f8f37589f..c2f79357c8da0 100644 --- a/drivers/video/fbdev/savage/savagefb_driver.c +++ b/drivers/video/fbdev/savage/savagefb_driver.c @@ -2322,6 +2322,8 @@ static int savagefb_probe(struct pci_dev *dev, const struct pci_device_id *id) failed: #ifdef CONFIG_FB_SAVAGE_I2C savagefb_delete_i2c_busses(info); + fb_destroy_modelist(&info->modelist); + fb_destroy_modedb(info->monspecs.modedb); #endif fb_alloc_cmap(&info->cmap, 0, 0); savage_unmap_video(info); -- 2.50.1 (Apple Git-155)