From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2664733EC for ; Mon, 20 Apr 2026 05:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776662436; cv=none; b=TuDgUyry8+ogwGwEOBphOuLKmw40TLX0RzOLzFi0JMGphCELgqvcgQUf9J8Jdx/4htjhCmt1Q0/Y9+J9+BqeBSd7n8hZ8Q82qJMz4wH2UeuuZPPadIFHp2CY0QFvBwLHW4RyFexuJQToAoD9fV/au748TXLdPxtdzLZgkHuBM/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776662436; c=relaxed/simple; bh=vTVlZVCv2wePdBPVUbKl+dgb9uitOhrwwvGI3GrHa0Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PtdnElO/zFIktAWWD+iJT1YN4U1l/lABPvoTUxoIHB5EN14hvS64nhI6mNrQZcgn8YttUlIM4yMjCoCdjhMLlsTrMllDlEpWa5BOAN9BwYSxK17E06o5hsQDc4zRoLu12/7F5Sphzs/qLgEgsIX0aZQKOVAHSrXaAsa9EmffjEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bX8Gl4AI; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bX8Gl4AI" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ab39b111b9so10122515ad.1 for ; Sun, 19 Apr 2026 22:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776662434; x=1777267234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GzRXCJv6s7nBaWaSPV26wDLtfWq6m8la+VtHkby4pFA=; b=bX8Gl4AIHRw6c+EuYLJ0EjQ0ohrQ/sKH76XXX3wf0BSX9j8qiXpl7NUecDacHJapwn BsxLU4cf3KXgXjV3oNj3Wor/eBz4eGcWn3Is4IOjjficsMb/5PEEywPfY9hriWd2CO2t TC4b2YTmuXcp7U7+3NCl9dCRZhDbZwNpNHPTczMrWAr+SZCa25lnimgWocWv5mc0vIxk KkVQe+kIJ3sgkcv5zSGrxIaVnRidcdlTB5vD0/RHaWN1glh24VuM+9qtmQhf2H6EMIyk DDaz4C+KPn7qn0KcPMr5+b20Uaj8eqVGhOKvNZWNqr0tAhHqoGFFwU98S19p3jygGJG/ 5qkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776662434; x=1777267234; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GzRXCJv6s7nBaWaSPV26wDLtfWq6m8la+VtHkby4pFA=; b=cxEIQBQ5NQJWSuHPlo27pgzS72PRc5FE9oPV9b9hj39VQIDGc3CTtlvoRwOpaT2su+ nKl1bp2gB2w4i/1Tvv0/MeV+TQYKb5iUgGPKWowGPAq/7FUbDzxm8Xp0U0//Xzi7VqXZ wXMjggHLwjGXq8Zvzl379TwocjSjvcgZA3fKUDpjXS+i1SJsJyTKOXWseo4dG27uMYXg ZueeYuYxleXDLHpICyWfLa5cb1ZJgsoBRc9O7/lpn8AFgVCwZGYnE7cB9HoDdQyqBZtp GN9ca5JWAcrW1AZf1nGJUUoTvEHNQvLigVshzvLbolbYHdkveiw0j0iBEDojmE5UJ0Jn 9OVw== X-Forwarded-Encrypted: i=1; AFNElJ/6w3vO1a0rPfNzZZRTNiXzHjdTqb+o1wfZ/Y/aPMd7MEkQ8Ijlqi82IRAkk33iQ+YDnibAOR/ttC2rztU=@vger.kernel.org X-Gm-Message-State: AOJu0YxgJXiLN7yAX4uGCjtBB+cYV9Wbg6hNltBv78sTozWp3E8/VZlv RknxJmIMW18/VkmawcxbOfLG5qljt+9/xvdWaYzydS7jv0YHgLIBBDGp X-Gm-Gg: AeBDieuadQ8KYYYlzSbC56xdPV+YuMl+iVgU581aEer5MhBDg3rVxIChFWI8sb1ze8A iLZXLbV787GAfMXd9AJVeL69BjlbxN3WLE4Z9PD5VZXBS1WbPRA4t3PJJRfCQhvlnfxc+bvMajs gH2Kb2u48igrUGfnliLUdm0LUHxy99JUiU6BN+gsJHWPMlbPcVBhHmUsYjeMIvcQ+cQhJGOnma3 IlzQ56e/1n9+8eiHm1CR4zPeYCd5/qkszsVhHEJGRB6NbzMhMkxcDBIeyGUTRYuhQURfYTbxOuX Ec4yEtuofeOvfG6j80osFNw9CeFqWQmPR/lxXkwOt2hnIeD5X/MHWoA/ijxpVDQgI2Kj98Drl0C hUrhY/DzHaNKsCFWwd/oPFMYdDqvrBxdR894DG1eSbnVSBbx51FfdLxBXnrg6G1iN5f7EBV/M4q ZjbsVftLexn03tSyU6bRXqj9bM4y6nIhXlq4EFdOjPXd/FxqhToQA= X-Received: by 2002:a17:903:124c:b0:2b2:57df:264d with SMTP id d9443c01a7336-2b5f9f61ad2mr132449745ad.33.1776662434501; Sun, 19 Apr 2026 22:20:34 -0700 (PDT) Received: from rahul-mintos.ban-spse ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab30f29sm87965555ad.68.2026.04.19.22.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 22:20:34 -0700 (PDT) From: Abhishek Rajput To: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, abhiraj21put@gmail.com Subject: [PATCH] drm/mediatek: Convert legacy DRM logging to drm_* helpers in mtk_dsi.c Date: Mon, 20 Apr 2026 10:50:08 +0530 Message-ID: <20260420052008.5417-1-abhiraj21put@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace DRM_INFO(), DRM_WARN() and DRM_ERROR() calls in drivers/gpu/drm/mediatek/mtk_dsi.c with the corresponding drm_info(), drm_warn() and drm_err() helpers. The drm_*() logging helpers take a struct drm_device * argument, allowing the DRM core to prefix log messages with the correct device name and instance. This is required to correctly distinguish log messages on systems with multiple GPUs. This change aligns the radeon driver with the DRM TODO item: "Convert logging to drm_* functions with drm_device parameter". Signed-off-by: Abhishek Rajput diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 0e2bcd5f67b7..a67ad575f5f0 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -510,6 +510,7 @@ static void mtk_dsi_config_vdo_timing_per_line_lp(struct mtk_dsi *dsi) u32 delta; struct mtk_phy_timing *timing = &dsi->phy_timing; struct videomode *vm = &dsi->vm; + struct drm_device *drm = dsi->bridge.dev; if (dsi->format == MIPI_DSI_FMT_RGB565) dsi_tmp_buf_bpp = 2; @@ -543,7 +544,7 @@ static void mtk_dsi_config_vdo_timing_per_line_lp(struct mtk_dsi *dsi) horizontal_backporch_byte / horizontal_front_back_byte; } else { - DRM_WARN("HFP + HBP less than d-phy, FPS will under 60Hz\n"); + drm_warn(drm, "HFP + HBP less than d-phy, FPS will under 60Hz\n"); } if ((dsi->mode_flags & MIPI_DSI_HS_PKT_END_ALIGNED) && @@ -623,12 +624,13 @@ static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, { s32 ret = 0; unsigned long jiffies = msecs_to_jiffies(timeout); + struct drm_device *drm = dsi->bridge.dev; ret = wait_event_interruptible_timeout(dsi->irq_wait_queue, dsi->irq_data & irq_flag, jiffies); if (ret == 0) { - DRM_WARN("Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); + drm_warn(drm, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); mtk_dsi_enable(dsi); mtk_dsi_reset_engine(dsi); @@ -663,9 +665,10 @@ static s32 mtk_dsi_switch_to_cmd_mode(struct mtk_dsi *dsi, u8 irq_flag, u32 t) { mtk_dsi_irq_data_clear(dsi, irq_flag); mtk_dsi_set_cmd_mode(dsi); + struct drm_device *drm = dsi->bridge.dev; if (!mtk_dsi_wait_for_irq_done(dsi, irq_flag, t)) { - DRM_ERROR("failed to switch cmd mode\n"); + drm_err(drm, "failed to switch cmd mode\n"); return -ETIME; } else { return 0; @@ -849,11 +852,12 @@ static void mtk_dsi_bridge_atomic_pre_enable(struct drm_bridge *bridge, struct drm_atomic_state *state) { struct mtk_dsi *dsi = bridge_to_dsi(bridge); + struct drm_device *drm = bridge->dev; int ret; ret = mtk_dsi_poweron(dsi); if (ret < 0) - DRM_ERROR("failed to power on dsi\n"); + drm_err(drm, "failed to power on dsi\n"); } static void mtk_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge, @@ -916,7 +920,7 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) ret = drm_simple_encoder_init(drm, &dsi->encoder, DRM_MODE_ENCODER_DSI); if (ret) { - DRM_ERROR("Failed to encoder init to drm\n"); + drm_err(drm, "Failed to encoder init to drm\n"); return ret; } @@ -932,7 +936,7 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) dsi->connector = drm_bridge_connector_init(drm, &dsi->encoder); if (IS_ERR(dsi->connector)) { - DRM_ERROR("Unable to create bridge connector\n"); + drm_err(drm, "Unable to create bridge connector\n"); ret = PTR_ERR(dsi->connector); goto err_cleanup_encoder; } @@ -985,6 +989,7 @@ static int mtk_dsi_host_attach(struct mipi_dsi_host *host, { struct mtk_dsi *dsi = host_to_dsi(host); struct device *dev = host->dev; + struct drm_device *drm = dsi->bridge.dev; int ret; dsi->lanes = device->lanes; @@ -1012,7 +1017,7 @@ static int mtk_dsi_host_attach(struct mipi_dsi_host *host, ret = component_add(host->dev, &mtk_dsi_component_ops); if (ret) { - DRM_ERROR("failed to add dsi_host component: %d\n", ret); + drm_err(drm, "failed to add dsi_host component: %d\n", ret); drm_bridge_remove(&dsi->bridge); return ret; } @@ -1034,11 +1039,12 @@ static void mtk_dsi_wait_for_idle(struct mtk_dsi *dsi) { int ret; u32 val; + struct drm_device *drm = dsi->bridge.dev; ret = readl_poll_timeout(dsi->regs + DSI_INTSTA, val, !(val & DSI_BUSY), 4, 2000000); if (ret) { - DRM_WARN("polling dsi wait not busy timeout!\n"); + drm_warn(drm, "polling dsi wait not busy timeout!\n"); mtk_dsi_enable(dsi); mtk_dsi_reset_engine(dsi); @@ -1123,6 +1129,7 @@ static ssize_t mtk_dsi_host_transfer(struct mipi_dsi_host *host, const struct mipi_dsi_msg *msg) { struct mtk_dsi *dsi = host_to_dsi(host); + struct drm_device *drm = dsi->bridge.dev; ssize_t recv_cnt; u8 read_data[16]; void *src_addr; @@ -1153,7 +1160,7 @@ static ssize_t mtk_dsi_host_transfer(struct mipi_dsi_host *host, } if (!msg->rx_buf) { - DRM_ERROR("dsi receive buffer size may be NULL\n"); + drm_err(drm, "dsi receive buffer size may be NULL\n"); ret = -EINVAL; goto restore_dsi_mode; } @@ -1177,7 +1184,7 @@ static ssize_t mtk_dsi_host_transfer(struct mipi_dsi_host *host, if (recv_cnt) memcpy(msg->rx_buf, src_addr, recv_cnt); - DRM_INFO("dsi get %zd byte data from the panel address(0x%x)\n", + drm_info(drm, "dsi get %zd byte data from the panel address(0x%x)\n", recv_cnt, *((u8 *)(msg->tx_buf))); restore_dsi_mode: -- 2.43.0