From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2985AC145 for ; Mon, 20 Apr 2026 06:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776664852; cv=none; b=XTC28Z7a5eG9U31F5JBem2rm5+NXDaaNrw1whkriRkOfRVcqZlxxcR3stzMka+3KCUUX/y3pFXDDrzIc3WsJH0kc10hfqQz+k5tHtyoaKchGUigiWTZvnWw9Bzs6AkZaVTMhVnrbi/DJC/wCp6TE8nWJ3JhIcKiJ8Es5QnJUlis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776664852; c=relaxed/simple; bh=RCC7mhfihNLXUAQpshgnrlRH9fonmVdKHPMsUEk+Es4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=EKlA5y4URqlEwrkcnAKSenrK1cJ4PFVMJqrZDhLG93nsIvd25fjz0dBF5VPJcV2F+BUI16e2irwTaeQ2NJoSyJZHY04chYeniuuqnyqN111UFGnXBx5gFdOO3TkJActxFCkTEqqJ4ka9Bu+HYG/M9U1iapmZZn3Asrfg/vrApko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CEfBlUnf; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CEfBlUnf" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c648bc907ebso1708325a12.3 for ; Sun, 19 Apr 2026 23:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776664850; x=1777269650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Yz+oIzHN4SvCOmidsaqa2XOdC5mswCbAEa0s0bwdLUA=; b=CEfBlUnfS/w7ap916/XSzzsG25XVN9yfag0UfR/19Yw/bFidI1zjiJ4L7aLvzu0nwG RoQJ6lHqFQ/3hb+mAFPwAVOICp619/0aa8lXTvHPjbtUxCLESfzzklk1GIlvM+9T/+o2 vDPFd0hNS8tObkS97ChFhHZ37NjTPTBRBKlu1zEuIMvXMEzF7swJCNTmuuRb6lp7IvEW I9FM62skzpPp/QpODBTAfkgDRDkcqiF9i5IJAROy+53hqRJQpa86pX3wiajoEl85Ql44 M7OZaPB5YkmhO0OSk33F+t19/1Q+QhnO7pOKZm2eH3/VPUDcBwNg4akpxkyXhjet7/2G cxNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776664850; x=1777269650; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Yz+oIzHN4SvCOmidsaqa2XOdC5mswCbAEa0s0bwdLUA=; b=VJj0ay8QlO0kjaXjLGQnBCQty6zKAqCxOznQloJOtJAVjGcz4R5P108PQkENFT7EL5 EN0n6LlIS33gr+JSx4PY4i30V5/bGGRZ+W5euQKQCM/2v9TFwa0s2I6lwEgtvVv8+jkU 2DgFZKOy6Cm5/zLTrpQhTbZrmybBS0IFjOjyMLDUBEB05oic8VP/C5Eg+7nZsRTjPlA5 EiVNB6Q6X/co3njuJLujIOSFzhF96zNxmAxA0+++eH03mtL7X6+0IKLslFAtEmxX5oOr FVszafgicMJUVjoXjfYewCgsNFeehTKUV9rBIt6hepT5/YsGbc7n1rYt1m1Y1RCkugUm UQzQ== X-Forwarded-Encrypted: i=1; AFNElJ+PQxLyTUzzsKk5djDt86oPbHYd8+StFcg8GSmDRTWduEcr6jZ7BE+JNRjBBHMFo3yPyt+VHOGRJDREbTA=@vger.kernel.org X-Gm-Message-State: AOJu0YxnQuKUAjvGSdDJR1SxBDwDsVqciEQ72ZwfvGZJSMgFw+XPYaF2 zWwwhJfPKDVOHrrqJkLY1AAwgjHns0TbdDIwBbW2KDANQ4fO7dN6qgiddcvB+g== X-Gm-Gg: AeBDieu5BzjfrvLqyQx5nDscyJecP37z3rDKiM69c+6ZPOhGY+MDlwLgbOqBvfQiBVM 5woU3pdLUu5CqtTr4xWQVaNbfL3Mz5dRWQ3uxVCYALWTBqS4tabjOlImb3jX63nKa6gyZCJ8QaW /qUFB1vjk94IUtP7PmWS+fEUQzBot0uAphPwZs4pjQtaq0xLkEcDniW4Pgkld9hFHfWkTNX0aY7 V14LXN5EffmkEUHT9DQZjpkO+iqXFJVHyBEsZzyKs0TxmfoyYHCf+2Kt4utT5fVbX/fVIFyjnCj nN9/xIGFrLnxKn7SY5i82CEMIV26fHlrX7mtdb4yKhdpd8J8kwrUqtZf2jlox6Aj8K0pVXb7kJg PSDkpVoIKuzRK37zTygF1kRRRbHqKXowEP+2/MedSN6HaRGJjlpSMpw33ORnLNjd3HyoaY4Jb5Z 3HxnihJiQ/MTNNe+8V7FVD7M3AseBaC+jQ1hlMpG+3OQ== X-Received: by 2002:a05:6a21:6d97:b0:3a2:d68d:9e6f with SMTP id adf61e73a8af0-3a2d68dd1demr935441637.33.1776664850261; Sun, 19 Apr 2026 23:00:50 -0700 (PDT) Received: from localhost ([2402:7500:488:a282:4b1b:c431:6491:7795]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797701d9bfsm6749812a12.16.2026.04.19.23.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 23:00:49 -0700 (PDT) From: Jack Wu X-Google-Original-From: Jack Wu To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] platform/x86: dell-dw5826e: Add reset driver for DW5826e Date: Mon, 20 Apr 2026 14:00:29 +0800 Message-Id: <20260420060029.1754854-1-jackbb_wu@compal.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If the DW5826e is in a frozen state and unable to receive USB commands, this driver provides a method for the user to reset the DW5826e via ACPI. E.g: echo 1 > /sys/bus/platform/devices/PALC0001\:00/wwan_reset Signed-off-by: Jack Wu --- v4: - Fix version of the ABI documentation to 7.2 - Add include linux/types.h v3: - Rename sysfs attribute from "pldr" to "wwan_reset" for clarity - Add ABI documentation for the wwan_reset sysfs interface - Validate _DSM method availability in probe using acpi_check_dsm() v2: - Remove extra empty line - Add missing includes and Remove unnecessary includes, sort includes alphabetically - Remove noisy dev_info() - Handle obj->type != ACPI_TYPE_BUFFER as error with proper return code - Replace miscdevice/file_operations with sysfs attribute (DEVICE_ATTR_WO) to reduce boilerplate - Propagate trigger_palc_pldr() return code to userspace - Convert from acpi_driver to platform_driver --- --- .../testing/sysfs-driver-dell-dw5826e-reset | 9 ++ drivers/platform/x86/dell/Kconfig | 6 ++ drivers/platform/x86/dell/Makefile | 2 + .../platform/x86/dell/dell-dw5826e-reset.c | 90 +++++++++++++++++++ 4 files changed, 107 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-dell-dw5826e-reset create mode 100644 drivers/platform/x86/dell/dell-dw5826e-reset.c diff --git a/Documentation/ABI/testing/sysfs-driver-dell-dw5826e-reset b/Documentation/ABI/testing/sysfs-driver-dell-dw5826e-reset new file mode 100644 index 000000000000..a665e265633f --- /dev/null +++ b/Documentation/ABI/testing/sysfs-driver-dell-dw5826e-reset @@ -0,0 +1,9 @@ +What: /sys/bus/platform/devices//wwan_reset +Date: April 2026 +KernelVersion: 7.2 +Contact: Jackbb Wu +Description: + Writing to this file triggers a Platform Level Device Reset + (PLDR) of the Dell DW5826e WWAN module via an ACPI _DSM + method. This can be used to recover the modem when it is in + a frozen state and unable to respond to USB commands. diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig index 738c108c2163..c4540c837a88 100644 --- a/drivers/platform/x86/dell/Kconfig +++ b/drivers/platform/x86/dell/Kconfig @@ -276,4 +276,10 @@ config DELL_WMI_SYSMAN To compile this driver as a module, choose M here: the module will be called dell-wmi-sysman. +config DELL_DW5826E_RESET + tristate "Dell DW5826e PLDR reset support" + default m + depends on ACPI + help + This adds support for the Dell DW5826e PLDR reset via ACPI endif # X86_PLATFORM_DRIVERS_DELL diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile index c7501c25e627..8150283cfd1d 100644 --- a/drivers/platform/x86/dell/Makefile +++ b/drivers/platform/x86/dell/Makefile @@ -28,3 +28,5 @@ obj-$(CONFIG_DELL_WMI_DESCRIPTOR) += dell-wmi-descriptor.o obj-$(CONFIG_DELL_WMI_DDV) += dell-wmi-ddv.o obj-$(CONFIG_DELL_WMI_LED) += dell-wmi-led.o obj-$(CONFIG_DELL_WMI_SYSMAN) += dell-wmi-sysman/ +obj-$(CONFIG_DELL_DW5826E_RESET) += dell-dw5826e-reset.o + diff --git a/drivers/platform/x86/dell/dell-dw5826e-reset.c b/drivers/platform/x86/dell/dell-dw5826e-reset.c new file mode 100644 index 000000000000..4e0d64535abb --- /dev/null +++ b/drivers/platform/x86/dell/dell-dw5826e-reset.c @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * dell-dw5826e-reset.c - Dell DW5826e reset driver + * + * Copyright (C) 2026 Jackbb Wu + */ + +#include +#include +#include +#include +#include +#include + +static guid_t palc_dsm_guid = + GUID_INIT(0x5a1a4bba, 0x8006, 0x487e, 0xbe, 0x0a, 0xac, 0xf5, 0xd8, 0xfd, 0xfe, 0x59); + +static int trigger_palc_pldr(struct device *dev, acpi_handle handle) +{ + union acpi_object *obj; + int ret = 0; + + obj = acpi_evaluate_dsm(handle, &palc_dsm_guid, 1, 1, NULL); + if (!obj) { + dev_err(dev, "Failed to evaluate _DSM\n"); + return -EIO; + } + + if (obj->type != ACPI_TYPE_BUFFER) { + dev_err(dev, "Unexpected _DSM return type: %d\n", obj->type); + ret = -EINVAL; + } + + ACPI_FREE(obj); + return ret; +} + +static ssize_t wwan_reset_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + acpi_handle handle = ACPI_HANDLE(dev); + int ret; + + ret = trigger_palc_pldr(dev, handle); + if (ret) + return ret; + + return count; +} +static DEVICE_ATTR_WO(wwan_reset); + +static struct attribute *palc_attrs[] = { + &dev_attr_wwan_reset.attr, + NULL +}; +ATTRIBUTE_GROUPS(palc); + +static int palc_probe(struct platform_device *pdev) +{ + acpi_handle handle; + + handle = ACPI_HANDLE(&pdev->dev); + if (!handle) + return -ENODEV; + + if (!acpi_check_dsm(handle, &palc_dsm_guid, 1, BIT(1))) + return -ENODEV; + + return 0; +} + +static const struct acpi_device_id palc_acpi_ids[] = { + { "PALC0001", 0 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, palc_acpi_ids); + +static struct platform_driver palc_driver = { + .driver = { + .name = "dell-dw5826e-reset", + .acpi_match_table = palc_acpi_ids, + .dev_groups = palc_groups, + }, + .probe = palc_probe, +}; +module_platform_driver(palc_driver); + +MODULE_DESCRIPTION("Dell DW5826e reset driver"); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("JackBB Wu"); -- 2.34.1