From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE8D79443 for ; Mon, 20 Apr 2026 09:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776675812; cv=none; b=qKFf/xmIA5h8vh/0RupDWvG+X7V0SzIPV7elMnvI9FQeb5O2uYwU0WXc4idtRClldHHmkKx7V0NLKTRjJz2DGEd3C3T9NGdOjcoQllLJXLtrl0k+Yz4p+3OM8tXoYCdT/qE32QEIsPVNfXH7qxdsWXHW6+BPTR0E/X0YdIEOjVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776675812; c=relaxed/simple; bh=1tZrYGL2ukBRHqFAeIW8jryqk5p9P57CIGtRpN4KNcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R0AG4BD5LT/SRbOIYbNe5xl1b8tiq0PGik4gfIdYDZvKm0nRnlQDhLYKVXbX2zsjABrV0hImlD6O0Q+lq5uf5s6r/m157S3evlLejEHV+5hC1UeYJYDUrOIlmE9gwh5P8SQJ5hrr/HJwnT1C2fU7XjWMyIPosgs1E5i8GPZkrhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mgiodse9; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mgiodse9" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35da9c0c007so2670520a91.2 for ; Mon, 20 Apr 2026 02:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776675811; x=1777280611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1tZrYGL2ukBRHqFAeIW8jryqk5p9P57CIGtRpN4KNcs=; b=mgiodse9w1+GOZP/6eOpvd9qDxsDpb2lYLfkuYEYMWJEIEQdFMxXRQMKOK5XqZjazx 9ZsXBZnA8O22xoNOBjpzv0r48q3wMKQM3KoLj6QmeqHvksQ34LDb63jErKt1SFPAhczf H0BJL957gF7SWD/ed/Up52Wql/MP/1vp7g1gijEKXVS52JC+QiWLQ1WZzr9+9yp8F3Uh yZiDrtFE/m3nZRxgZojs5vjOUQPEx861CvpXVO92N9Y5NJhnLE7DWsQAxW5aaJBjSv2X mf/ayPh/rq9EcVqpMF8vHP0bBC+YtdqmzLVoBHJZyHViowRHIN5mt6Dsgbp2T56cHbHh rsOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776675811; x=1777280611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1tZrYGL2ukBRHqFAeIW8jryqk5p9P57CIGtRpN4KNcs=; b=gEKeujP0kZ4ImUkCS9B7ZNEpgq+IdlGDyb0OWSEYMuIqHKbsmyVowUZm5/ow8aoS9y /964gnc9z+ywFjTxvxZ4F97nlt2GIZAwC2+LVuX/NUWmqNZPO/puDPTdpZ645Kq/uBCp AXXsLN86Yvd3+rhm9XnBfi2E93GyUqypW/Mq8zytxnga0FGw/UrRPgcTQvTbh23t15uM /VRuj/5YtOnscgTXNzZNgNQy4eXrz2NptLKkJp+HmMimFvLATxVf/LMJeJmiQsva/fTk cCV07XkGHtadtX1ewr5AgJ7EDlLch0IhGmajArXH9NMP2sB6DlCO/C5HgiJdqgIXfM4y qFig== X-Forwarded-Encrypted: i=1; AFNElJ/OpOq469EM/8lIdQZyRZP46SQfj5Kk+nOS9P7PxL5IZTSplDzBo8tOmrpp4xkZs9RhM2z3sAcWqLkXgcQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzM3fSjfw1z/qYnIdLid8fjfn6uDxCpHlxFcuSZCohLgXiCzAII 73NnzCXqIRlGGgMgrdCyIfPpSb3h/Cs3p9TzIeqoqC27EdNt62vPiimB X-Gm-Gg: AeBDiet6slCjzXjgIlOSVaWCZMuQs+8mkq+QeqN98XmsbpugoeBv3NQXDxWApiSfHoK tKz4NNc189T09hh22NMk7QyGKdK2Ok1KIhjw5R0JgoUHESmbWDfPlecG+2O8t4LCuTkgenY9V3J hEkovvs7srapj2blEEqV/bUw3M8j2DduYHB/zYYCx1hExnHbfLdkx4EpsQHGQs+EiTiM/iAPtbn jNn1Kf2aLgNj3+8I9jQO56R0z0XHKXAvZg8VzB8oCJ8/GX2zraVFo/d6661bsEGedyB0nxohfX/ C4Ri7Uh0FUVR8TWKJJ1cFRosalQUX1uR8A+FyUC4OVTzkq9Mz2MpSKkGqi48F8XwV5eUrCI1WL3 pWapjOTImdoxBHzh5o8woJd3hbrITyP2OWMWfPDoT1J5+/BIaQXxYMGUE6DRgJ4YpgtUKWZTfvf jMSNtSYQs3tCP3lCAoRMm2lVXUYTGQMJQnrKCf4kPIVg== X-Received: by 2002:a17:902:cec8:b0:2b0:5b4e:370c with SMTP id d9443c01a7336-2b5f9f8b3ccmr140887735ad.32.1776675811168; Mon, 20 Apr 2026 02:03:31 -0700 (PDT) Received: from 7c1ef1825668 ([115.245.213.202]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa1739fsm98861015ad.22.2026.04.20.02.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 02:03:30 -0700 (PDT) From: Sanjaikumar V S To: pratyush@kernel.org Cc: hd@os-cillation.de, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, mwalle@kernel.org, richard@nod.at, sanjaikumar.vs@dicortech.com, sanjaikumarvs@gmail.com, stable@vger.kernel.org, tudor.ambarus@linaro.org, vigneshr@ti.com Subject: Re: [PATCH v5] mtd: spi-nor: Fix SST AAI write mode opcode handling Date: Mon, 20 Apr 2026 09:02:37 +0000 Message-ID: <20260420090237.21-1-sanjaikumarvs@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <40364d66-f8a2-4efb-a4d3-70f0aa3137e2@os-cillation.de> References: <40364d66-f8a2-4efb-a4d3-70f0aa3137e2@os-cillation.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Pratyush, In v4 you suggested updating dirmap_info with the right opcodes. I went with a different approach in v5 -- disabling dirmap for SST AAI devices in sst_nor_late_init() instead. The reasoning is that updating dirmap_info at runtime is problematic since AAI requires dynamic opcode and address byte changes per write, and controllers may cache the template at dirmap_create time. Hendrik has tested this approach on his SST25VF032B. Does this approach work for you, or would you prefer a different direction? Thanks, Sanjaikumar