From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF06D3D75AB; Mon, 20 Apr 2026 13:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776692373; cv=none; b=ZQYAfJMORLJyEyS0AueC4mnpvj62zP2wGUq5owxnyyvOMmWG4SVlwJm0yQ1cnCj12m1T+ghkoy+y0nERUjbVzeAfWl1jrh0WVzt8ThlIKbnG2+ocJ39j55dn96mGcHk9T2JfK8EEHLU26T/kKZ1ol/TeDd/81/3JAXbxTWqDcZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776692373; c=relaxed/simple; bh=QV3/kRtnuqUUDprxbWR5pkNW+yWztIYB+VtpAMRuffE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WcBHUi4WDYg9qBm59Lt7CmWJGPlJvGDa4jFgulCdClI7IkMNhoN+ACoIdR+hDvCnZM5oLzaBR1aS0ebo+j2Hra4ZzsHgoO0Ieno5Xz/irJPOdUY6QtBzvvhtdPfdyAWpcwJlcrE+F9hI/q7izO2nvA7KvIUUeO/evFn8UmriGVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rUQr//4x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rUQr//4x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E39AC19425; Mon, 20 Apr 2026 13:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776692372; bh=QV3/kRtnuqUUDprxbWR5pkNW+yWztIYB+VtpAMRuffE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rUQr//4xkxx3D3yKvPfqTimlbnn7kNSAHnCzfaA+MVn7i9x6JhtUGCIjUw+HuWcmt h6aAvjvD0mPG/N0e+PzQhtGppPOt1KmckMqNEY0BeyGZlcRD+G0sR54cBx8bWgFHTB Gawo27UIsUnhcFc1F0hDdyNHTzAbvEMI2wHTasyUALFhkJvHOEZk5pMi54TRLGu80O jTZEk0Fh5YgOdFwJZO+kBBXlMwD8aAhY7jog5Um60tHiHROvLj20imQ6ihSEfBZmP6 ahYRbbtDPMuwsPmYCnZFdDf/ne3NQZECgijAQQPgP4qEBrR8zBU/9G/uebmMcmQ+HA bvtEWK4t6yU1Q== Date: Mon, 20 Apr 2026 08:39:30 -0500 From: Rob Herring To: Minda Chen Cc: Alexandre Torgue , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Emil Renner Berthing , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org Subject: Re: [net-next v2 3/5] dt-bindings: net: starfive,jh7110-dwmac: Add JHB100 sgmii rx clk Message-ID: <20260420133930.GA2322456-robh@kernel.org> References: <20260417024523.107786-1-minda.chen@starfivetech.com> <20260417024523.107786-4-minda.chen@starfivetech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260417024523.107786-4-minda.chen@starfivetech.com> On Fri, Apr 17, 2026 at 10:45:21AM +0800, Minda Chen wrote: > JHB100 SGMII interface tx/rx mac clock is split and require to > set clock rate in 10M/100M/1000M speed. So dts need to add a > new rx clock in code, dts and dt binding doc. > > Signed-off-by: Minda Chen > --- > .../bindings/net/starfive,jh7110-dwmac.yaml | 42 ++++++++++++++++--- > 1 file changed, 36 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > index edc246a71ce3..3802cdbf1848 100644 > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > @@ -39,20 +39,26 @@ properties: > maxItems: 1 > > clocks: > + minItems: 5 > items: > - description: GMAC main clock > - description: GMAC AHB clock > - description: PTP clock > - description: TX clock > - description: GTX clock > + - description: SGMII RX clock > > clock-names: > - items: > - - const: stmmaceth > - - const: pclk > - - const: ptp_ref > - - const: tx > - - const: gtx > + minItems: 5 > + maxItems: 6 > + contains: > + enum: > + - stmmaceth > + - pclk > + - ptp_ref > + - tx > + - gtx > + - sgmii_rx No, this allows any of the above strings plus any other random strings. Rob