From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5128336829D for ; Mon, 20 Apr 2026 14:06:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776693969; cv=none; b=CtvKAQDOIbJzMsB1kPvS1Zb1DARf/9oAT0JRDWklsleZMB0aLd5tD8O6kLxxkyhFaXW7tfuAZAz0xMuGW04x4U6m+fQpwuc6sqMTkIsAzxHCkoRbH5ia+A3zRS8/c8LeGYBH6agqgiYDflsGldmVMfvkmbTTSI0CQ/Hm25GFvUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776693969; c=relaxed/simple; bh=McTgtxXg3SkM7Vh3ExzGVSZIoRrxtuX65qsjp38NkUs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OZ0pTel9fxrpXILQh1POPbNE5aqz8Ngvx/rxqLzxG1Tcu5sZWN240aD8W8yNST3Fa1ECS62550Z4n1jKuoqK6OZWf21uiFEnyw4q8DpGyJvULuwI1/yyM4B9ps2kc9teAOjZ89qQADLcgfGyrf8VvFRmzlEtcgg80PgiGTDfQ4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q5zzoyNo; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q5zzoyNo" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b9c9d03524cso445143466b.3 for ; Mon, 20 Apr 2026 07:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776693967; x=1777298767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6GhnsM1qLpNzVnb2Fml7lbOW3GGX5eMcUoHx7q/ECGk=; b=Q5zzoyNoGLpX3uJqpBapGZJOGEmCWPX3XU6vsnW5AQMzOvESUYlGaaLyeTNMlxo5s3 q58Lgi1Qw1ppbMm63n5yvvINYWQL3BcNwy6tas1s6ZA+TEekaqed72Vd5v5EQKNzTQaX CnbF8VVFI3/HYK44eJ6s8/Yiyf372JdPNbIjk0Q0BONwquyzRofOieX/DDEAMT0Qrcgb fSPCUPbgApcGoFVxYZKPPV30A6kJQnyOfscGDmGI63i5w4hCZ9nPCXl9nB2/7QPDm3ao 6kUuETHQKkmx1WG2afiTsMy+zZItiCD+W7zaPPRc92TMvw9dM4jCegt/PiBIElDpjR9h bwug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776693967; x=1777298767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6GhnsM1qLpNzVnb2Fml7lbOW3GGX5eMcUoHx7q/ECGk=; b=WzLKv6YJjnKyKsZDGSwFijr7W75o0pa4vUEJe5Zd8ZYQPsS+svtsTuG1A5prcl/6hR eUidtSjo7JFwNhgs07Gcs9vGUQttf+Ruv0zXR0quLefsG0tzdiHC/UqZ9Vddcg9y4T76 947UBxjsNgufzDOo/g6aiW2mtxuDPh7EeMUIKlKYxNMo07Nv8vZSAjBrpWVqFnmqMZR4 O53Ce4rNeuGgBPPCXM1hAgyGdvKabZUDv7YAyBSZj1ZGmvdTqJ8jJpQ+ODKHz1QtvaE+ afl75YuTvuMdwCDIKtyIJdNU9+KOTfBPnuI//CwZlPpE0wHBJ8M/atuYLem67uK5qGVL zwBQ== X-Forwarded-Encrypted: i=1; AFNElJ8bIhWR/OrmyGPhn3jxdKzW8tTOWc6A2z5nWHKc6nasZ/DanGIQUdolzJaNCf/fHQmvue/vlaR3lrVu23w=@vger.kernel.org X-Gm-Message-State: AOJu0YxJYdxoLq58sP45ARJBe7XiI5r8bqVW3KfRs9PTMgxYD7BvgrN+ lV/Ys4SeP7QQgxy+eVjqdQAdRIo9lofrg7vymfVvOAUvSfSkfsNbUH+a X-Gm-Gg: AeBDiet2XTGv0DYTPniLL4AW6BoK3fIXgS+MZuAAzRketXiqt+TJdSh38peao9LKAUg dgxdkn2wdLej/b6d/DowOg10hOQYoesPPSSED4V1ljcujlcxpzO6cdS1DtS7omA8p/EKbiHt7lD AatUZJ0mgGwFNu7FNkJWP/2NWn8iSR+9KDU2OYz93rfRGSRTDxJRaR8amDGmKqR1weLwgqoVMqI lEUHrYNLLat6IlIWFdkZwFMGfijBfG8t9sKDWEAsOmmK8pXpllQRAPbnaRRSITpRw7XHgAYAOcs Mi8+rZ1SneRa+oxfbauzYIKPAmALlya0P1rzK9ZjG/fPuO7Di4YnOUoZRWH677PBlUf3r3AykTf ciuBauQQ5IsOzMdkVAlmDJbkttOaH1WH5XWdXwKYHAfHhCu66Ux3/wjEjfLls1kko1/0+Yawu6o zJkHoneSNiBzk3V3nZO/AsiGgOzUDQOkzMZHa4Oke3zzHe7XAv69ULqwc2Z/oxGbSXU4bqhPdsZ wia1MEBocJID3Mbt9MJEvsnezB8dIHZme07/by5Attir9UphZWGhyWC83iQpDYDUXujTRmy+/PA Fth9OkL5WwLs+IozZ87dCWloDuA= X-Received: by 2002:a17:907:160d:b0:ba9:2233:1ec with SMTP id a640c23a62f3a-ba92233023amr14668466b.22.1776693966583; Mon, 20 Apr 2026 07:06:06 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba45121109csm358128966b.6.2026.04.20.07.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:06:06 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Alexandru Hossu Subject: [PATCH 2/2] staging: rtl8723bs: fix OOB read in OnAssocRsp() IE loop Date: Mon, 20 Apr 2026 16:04:32 +0200 Message-ID: <20260420140432.150431-2-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420140432.150431-1-hossu.alexandru@gmail.com> References: <20260420140432.150431-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alexandru Hossu The IE parsing loop in OnAssocRsp() advances by (pIE->length + 2) each iteration but only guards on i < pkt_len. When a malicious AP sends an AssocResponse whose last IE has only one byte remaining in the frame (the element_id byte lands at pkt_len-1), the loop reads pIE->length from pframe[pkt_len], which is one byte past the allocated receive buffer. Additionally, even when the header bytes are in bounds, pIE->length itself can extend the data window beyond pkt_len, silently passing a truncated IE to the handler functions. Add two guards at the top of the loop body: 1. Break if fewer than sizeof(*pIE) bytes remain (can't read the header). 2. Break if the IE's declared data extends past pkt_len. Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 5f00fe282..9666226a6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1400,7 +1400,11 @@ unsigned int OnAssocRsp(struct adapter *padapter, union recv_frame *precv_frame) /* to handle HT, WMM, rate adaptive, update MAC reg */ /* for not to handle the synchronous IO in the tasklet */ for (i = (6 + WLAN_HDR_A3_LEN); i < pkt_len;) { + if (i + sizeof(*pIE) > pkt_len) + break; pIE = (struct ndis_80211_var_ie *)(pframe + i); + if (i + sizeof(*pIE) + pIE->length > pkt_len) + break; switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: -- 2.53.0