From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4868E3A6B9C for ; Mon, 20 Apr 2026 14:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694670; cv=none; b=qfVZ2ScIDvvQvqb/G2LyOYv8CA6j99/g34v1GO+aH9Zaooa34AfJB8Hpsc5D9qo9e/Uxdh4RSyS5RXPe8G5mr1nfCe/nqqqjAUVtrtBbaD8ZWrkCrDUw9tT6elC+bHKe1XO3PlhJYRCwZpklA29kGRfkv2bQiaYNzcpPC5374As= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694670; c=relaxed/simple; bh=QhJfDHi/8rLPhR+jmwtM7LFYMmAbOTEzS0sOBNZ8mPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nDjvuqRe4mHSwxTskD6Glzjk2WTQKlUydIb+Kh9hA0qBZqNJNl1i29yL7/xNVF/SWdiRDkhkk0FgLEQIr2sI+o1OcdvldSLvWsuhSJcfC3m+6lyzLxSBsIgD7KVettxTlhwQnNBlfHEoR6uRPcUtUhhn0TFwQciBFnzJvahNEGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WgEC06F4; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WgEC06F4" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43d7650202fso2501296f8f.2 for ; Mon, 20 Apr 2026 07:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776694668; x=1777299468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f2+fqkbJq3L5Dr2igTq44CcXT0ZR7odi5lkKx2bdprE=; b=WgEC06F4JxIs32kX0Vb+4cG66uC2jiFJmhaOGZqTVeE5PumisJ62aSX4HRig43+5LU oXnqz9mBJz3cNTCYses2NtAp+gS/DklxitRBNNwASHeccNMVQqRcRNRTxIvIRhTqSezx eC66DWGpL6ab4hRugP+5H3Ch8J65VYXC/ktKUUjtOKBzIlNQW7bGDK5agc0xAvepVJhU Fb0riNFCnD4ZdrPpwtzTMS/r8R2LRF5UO3T3mcPatxI1VVbF3LqRSqe5Rbb81i7+fLHZ bX4AeLgJQhFMILL+gy8SffNPTitDz12Rwa754vsJdYmtlvcOI9Rvtq9GF61+uCaabv2u fTZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776694668; x=1777299468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f2+fqkbJq3L5Dr2igTq44CcXT0ZR7odi5lkKx2bdprE=; b=rj9IPXSKnOTMT8+AvbU2jbmwubFQtyPb/LtHDGNHVUR5EVVbDZa76wx2+6nchob7xd hFVtTUof5LjuqW4TYjPpXNNyWQkJJhiWffdauz0FiecUwGoLJ5xIchU1shOymbhAf+zo s2WQi+1MXL1NE0Oz0bAdAWws7Y6fXdy2eHRnbBHDPIr0YNCIx7ZQPEcM3v7FxVmkk/hC OJsAjOvThpY4TLNOB8nc6C5OvmDp3Ov+jdrfBPg6I75kWn2t4wQ3BQmWxoEnPVqRMfaZ pI7xn++kYiZgKGTDfD3HA/JacAKKrFAFPITD7Ma4RYqwFl27gZJTkmDLJbgvUrBptF69 earg== X-Forwarded-Encrypted: i=1; AFNElJ8vHB8nWSwuVpj7wvaSxSz67p2jbpOp1sDzUqWxIkUrT41UY4t4rFhq0RTR8GYvLBR/8tvC3nYiNtUEMxg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxli5yfNnn3Cis+VV5/o1R6JQXbINtjRjBFi/Rf0M/qT07A7U0h vDR9Ek12q4TinUtXfU42O6B4k2aI1aA2pdAKErahH2ngnLbk+BRU/Fvp X-Gm-Gg: AeBDietb0691RCoi1qKPNX6yVTR7yUao4Uwxuu0vv3WZHDZsI4r+uezOIsn8wNtTLyQ FiDcbdO+87dtWl6Z0uCSV2jup+BKnrdMcZfX+XqpjdnZvFwWflRdiLfIODU8oMeRmopuah9iMCE YWGpHefqvAYhTlh4pUeXwRC0lVCMSZ/gKRGf4M44zU4LW/Qc4FtsEj4g5V0xtM6x5E09Rm3twrm 7qDpB9deaHErV/ixILAVChB62MCSamOXR+Q1M+ZLuqnfghU1fJnE0UL67S1d9ShqZ5xjRCSiB2W 9Dl/dSz3BEI76LOVUR6k5PNtUsA2C00Xu2gMvrm7VgYR8ZstNdSpaTANvr1Ejuhd2k4NM32byIZ FcO+tYcbDUG9mkjvSOHIQcw2mS4ghXm4JCI6ZKT+AxodnR4Ph49i9Lw6mquni2ES3nXs7WeXlLo 4cotNdTEjM0OlbwFGpPB4S79vIEqb7beyXsfDogWQ= X-Received: by 2002:a05:6000:186c:b0:43e:a703:3665 with SMTP id ffacd0b85a97d-43fe3e0c6femr21089126f8f.25.1776694667476; Mon, 20 Apr 2026 07:17:47 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:355d:3be4:308b:c943]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-43fe4cc375dsm26832847f8f.14.2026.04.20.07.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:17:46 -0700 (PDT) From: luca.boccassi@gmail.com To: kexec@lists.infradead.org Cc: linux-mm@kvack.org, graf@amazon.com, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, brauner@kernel.org, linux-kernel@vger.kernel.org, Luca Boccassi Subject: [PATCH v9 2/6] selftests/liveupdate: add test cases for LIVEUPDATE_IOCTL_CREATE_SESSION calls with invalid length Date: Mon, 20 Apr 2026 15:15:10 +0100 Message-ID: <20260420141741.2688371-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260420141741.2688371-1-luca.boccassi@gmail.com> References: <20260420141741.2688371-1-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Boccassi Verify that LIVEUPDATE_IOCTL_CREATE_SESSION ioctl which provide a name that is an empty string or too long are not allowed. Signed-off-by: Luca Boccassi Reviewed-by: Pasha Tatashin --- .../testing/selftests/liveupdate/liveupdate.c | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/tools/testing/selftests/liveupdate/liveupdate.c b/tools/testing/selftests/liveupdate/liveupdate.c index c2878e3d5ef9..f0a8e600c154 100644 --- a/tools/testing/selftests/liveupdate/liveupdate.c +++ b/tools/testing/selftests/liveupdate/liveupdate.c @@ -345,4 +345,46 @@ TEST_F(liveupdate_device, preserve_unsupported_fd) ASSERT_EQ(close(session_fd), 0); } +/* + * Test Case: Create Session with No Null Termination + * + * Verifies that filling the entire 64-byte name field with non-null characters + * (no '\0' terminator) is rejected by the kernel with EINVAL. + */ +TEST_F(liveupdate_device, create_session_no_null_termination) +{ + struct liveupdate_ioctl_create_session args = {}; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + /* Fill entire name field with 'X', no null terminator */ + args.size = sizeof(args); + memset(args.name, 'X', sizeof(args.name)); + + EXPECT_LT(ioctl(self->fd1, LIVEUPDATE_IOCTL_CREATE_SESSION, &args), 0); + EXPECT_EQ(errno, EINVAL); +} + +/* + * Test Case: Create Session with Empty Name + * + * Verifies that creating a session with an empty string name fails + * with EINVAL. + */ +TEST_F(liveupdate_device, create_session_empty_name) +{ + int session_fd; + + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno == ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd = create_session(self->fd1, ""); + EXPECT_EQ(session_fd, -EINVAL); +} + TEST_HARNESS_MAIN -- 2.47.3