From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3E1361DC9 for ; Mon, 20 Apr 2026 15:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776697631; cv=none; b=Vz09HyckfPeOwAA1QV3vs/l8zkIqA/HWB4X0ld+lWdnLf39812MhEPGN/wEhti3BJaV0XtWfjwkiaYJazzEez/qA97Niy+0I83UMSFPFWFvCGBXwyVOzNCWdxt3LPWnvPVpfnAlMRRrf5ue6GTdT1uWz9+AD1WitkTEMiUAeMBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776697631; c=relaxed/simple; bh=p6RBN7hFAjglXhRN6dF0E6s/Whr9ZAWZrTmi7Z6WG2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rMPzOqd/6wmFgXq2EVL5cXbRN8FKBkfQAd9UZQ5l2RGRSM58tJztr9XvfCjRJU1G5ecR5ZUTQ9RGQxjWnHxE9ZBaeJRXBEW74z0uEbJExQUq4R8j7ppUY+lyme9ToBabR0KJIKiHb6tay//XKBaknoS5NeOZmh1lRpOTmGrSKqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EQYShY6Z; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EQYShY6Z" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43fde5b81a1so2327521f8f.0 for ; Mon, 20 Apr 2026 08:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776697628; x=1777302428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ynS4V1zPnfRYyra1R+IgeuqIvRmeRjBbGLtQrOc/Ilg=; b=EQYShY6ZKkhRD4sp7fncU376bX0zZ9Ewjv1zRU78Lye+Ioduvhj3Qhj84WpMVSKZwW N0mo6DPjwAlTM8DewzrCDPKVCBla+wkKkrN42YjZ4Wnkl03Juh5XPkHyUNtUyokOfkPy NcJ13s79tRGMmiPhkd1BvcHyvXd1XmZQdexAh0aotM1TwGAjJ5sCDDYxVAzcHNgpkI09 ufslGg8dRXpHSeu43j/AXCD5pD3peD2/60GZi7Z8uGdbM9Whysx7qAcz7JyOd9OJyG3y JEM82qh2ahk3Hbjk4tDpYHJfv2aVo/kxlKmP+FVw9S0zOkG9KRcm/e0zwIOaw4FzKWjM Iobw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776697628; x=1777302428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ynS4V1zPnfRYyra1R+IgeuqIvRmeRjBbGLtQrOc/Ilg=; b=AcliQICOFhSY+Dy/Eh/AR9i+gUJrykx87QPrpTT1higujSFF7ADWyCNYtEFLU7QzPZ a/RTgNQEtGC7RCKZSPrRSYlJ8oE8HEluO+oDuFUB5s2mqqmjBV39aOJ5yX/Cz1o+LvKX TXPd/SDCehoerSoI5Yf9GE9jzdDehElzOp4YEjNRnBEDr4TslSgeV0+qg8TEWxqyzuBi 9JinNDonxh5HEKR4Yr4XuW5iIShmXtxOItO940Yu2CeW4inp0HPcNbdU+7aI9ZNQpu59 R06QOYIm336yBMVr7PGf1ZhcFE9acdAwzuGJrTKpzwrlVpbzK4zAiXQ8bBQU7lDcDsgM 5yXg== X-Forwarded-Encrypted: i=1; AFNElJ8IdTqq417gEcFmJM/Q7EFCTRflb6hylS/wygD9io8bCJs/5QXoK3ceuzuRYDfsOSarsBQCh0lXZTwsWBs=@vger.kernel.org X-Gm-Message-State: AOJu0YxPyl8gpBOh2OlutjyvQaV+SAs5amDl5EC40lS+ZZM4xCsDyhi+ UDFolAxeJLPAtIycZmMtKBpt3rsAPrIbyAM6hjdUAvhw8jBcPp6hH1oa X-Gm-Gg: AeBDievjK2ziY7/PLApQ5A34HdEwzLcr99RNU3dzkmz24P/8hSeR3sfBIAOdNLsiXJW oxFC0tuVYqhJfZ/3vnHaK77qZ2Z2xTPXCmnqFNp4Ma8Miyi5ZFQ4potjLN2Jrf8RmgTyYSzV58h /a2COtRTsSOZurzvpCD7AHy9rRnnHgYTi3eM60YKH/8o/5/DNbXRIC+KVaXLTlNu1hu3HUBXAP+ Tjx9AX3qHs0pJxad3KzCndXm52A1gQGrEtbWK1lLERgZhVw+Lz0TQPIgVzcz2+bpKC9ay/4k9hJ AujoUlbWndhQoJqLYG3YWzTG44uQkOb3YN4okeu3VDcq4na9nDLzqIx7U2X9xXRMchSWUr3yRen 85nct/3SLJ+tlhAMUYutz05RKxECtrzPw40peKApcCByWDq4S3nfX0uUtjZ1bO07ZvJPDKpdI1p 3EbdUcg//xlkxsmvdQQOIYYFMukeuwf2m6DZ39sb5A7n0S6f9fiHEhw0jkfuQkAmZh5uklrDI= X-Received: by 2002:a05:6000:1889:b0:43b:8f4e:27f8 with SMTP id ffacd0b85a97d-43fe3dc12e6mr21117601f8f.12.1776697628278; Mon, 20 Apr 2026 08:07:08 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:1552:6880:e516:62d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a79esm31927136f8f.17.2026.04.20.08.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 08:07:07 -0700 (PDT) From: Osama Abdelkader To: Anitha Chrisanthus , Edmund Dea , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH 2/2] drm/kmb: unwind partially enabled DSI clocks on error Date: Mon, 20 Apr 2026 17:06:58 +0200 Message-ID: <20260420150658.165734-2-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260420150658.165734-1-osama.abdelkader@gmail.com> References: <20260420150658.165734-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If enabling clk_mipi_ecfg or clk_mipi_cfg fails, disable any clocks that were successfully prepared/enabled earlier in kmb_dsi_clk_enable(). This avoids leaking enabled clocks on probe failure paths. Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/kmb/kmb_dsi.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index 500dc00ba6ae..3ec16b1aa16c 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c +++ b/drivers/gpu/drm/kmb/kmb_dsi.c @@ -1526,17 +1526,23 @@ static int kmb_dsi_clk_enable(struct kmb_dsi *kmb_dsi) ret = clk_prepare_enable(kmb_dsi->clk_mipi_ecfg); if (ret) { dev_err(dev, "Failed to enable MIPI_ECFG clock: %d\n", ret); - return ret; + goto err_disable_mipi; } ret = clk_prepare_enable(kmb_dsi->clk_mipi_cfg); if (ret) { dev_err(dev, "Failed to enable MIPI_CFG clock: %d\n", ret); - return ret; + goto err_disable_mipi_ecfg; } dev_info(dev, "SUCCESS : enabled MIPI clocks\n"); return 0; + +err_disable_mipi_ecfg: + clk_disable_unprepare(kmb_dsi->clk_mipi_ecfg); +err_disable_mipi: + clk_disable_unprepare(kmb_dsi->clk_mipi); + return ret; } int kmb_dsi_clk_init(struct kmb_dsi *kmb_dsi) -- 2.43.0