From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54BD5379981 for ; Mon, 20 Apr 2026 17:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776707496; cv=none; b=bOfwp+/GXjt+G/uVbc7DztzpL+JnwD9y3f+tvbbCpS/1frXfs5+ubFCTpy98XO20uXrC+9fEK7O5VDfoT+2ZO/SnXVRVHqddHKAccy4DKi98ecXPoT0bIdbDdQ8fDd50oGbkaMvubiy7uguzFQdP6gFpypK1fcpFAzw4LSG2j5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776707496; c=relaxed/simple; bh=uam3YtKNdr+siwieCKD8+jNVlZSofiVOKYEtdaCJ0Jc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Pmg0Ds51kXBpHBNGMjFCCbIJftyPAEXi1y9JkpuA2kj5lrhKWcHRTxFlOMPwDX8XKCu06tmFeFQtgGQYKo7RMw2408afHFRD8HhQPxM7LMyUD3sUJguvIemPPiEyZ7WDleeb+PzkVJMxsEybG0HV4wdyjyC65xnTcY2m3FWwUbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nDr2HXjL; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nDr2HXjL" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82f956bdc66so276348b3a.1 for ; Mon, 20 Apr 2026 10:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776707495; x=1777312295; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Xv8YKf2c4/2CV26eV/yRwUDY1hw9RhAfAYIys2Ru/sM=; b=nDr2HXjLHTd3vpHV5imYVnN/Dnksz37g+vaNQf5FwMRRRz3x8hTzG5oEtXwL/Fqg16 bLoLgHwLMCdiz1HJSS3myuTeVU//mUaAzQJu76Oiw53KPzw1hDpU3kntOTXC1qAs0cf/ rAqCBEgffMzRJGvmAAJAbPK4O3HYGbgOJdVRUvCypmwiM9KmUy3IAsx0PtetwudSLbl7 ipdWIw0QQ4qV2TTx+whNjv+A4OnR/dQ7VbE6WkGE1nx4+PZsl25mhir5til84a/V7ExI A5AQEacc2xjh+41XWZ6FX8kql5dj74EncI9GYIS5AvgPyIMmIN8YCiftDfJ94B1/5IRq bWDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776707495; x=1777312295; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xv8YKf2c4/2CV26eV/yRwUDY1hw9RhAfAYIys2Ru/sM=; b=sb+BlSIa3mV8eUzSgc7aKR9k/zuHr1tE77vKBtr69pD5cDwW23pwgsu6d0hKAKyh2E S0UquPMDgPRo0ZJgWnl1aO29Z5obyfT63RIsPOK1bOSCQy03MemrXXOPllYjPJmnJPJJ uUmhSJfCiEG7WwkrM3Mgt8EqKNuW+8bdAbhzCZuCW801Zu5D6vRV2D358ChyDYyUJb4p uENJrjmoI3kKiqluEzWRYFKtWETL/OX9GT241J601AmFhFHe6nmGYAfvzaY1O5Eldz0x CsecK5ubo8yvOsFBQlKDitxVMo7Tx8hl/6L1TxdwjUZPGG7q6B8AtRBvN9Av8KpmI++Z JlIQ== X-Forwarded-Encrypted: i=1; AFNElJ/WrBuO+qJlYeJPDsw+MSPFvaTfnb3cPhQT94hzeC1ulHkY5TfxtEf3RADvzCcU5WV6sS+iQXiLpJDzNjU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywdwi4I5XZq8rfu9OzwozAw3thiaa90Edu1Eqv7BpTSMH/X65Gx H1vWaWUPTBLRl0JhSoktPigUtbXKKAed10TEBquLVQJt9xMF7rQ0UPv/ X-Gm-Gg: AeBDiet1y9k4P2Y9mEietKtm31W+agWrH4mlqn5wyDhBAHXksGdWWvm7KYseDyKbwtP BlNYqLaS8lssgtRtNH+Un0bp7bp7ggIRlSYI5iWdulexSoYMrbLz15gWN+s9VzXDlVUanUvHGOq 0pZy/IBP6URAvKhpZIGptSSoUZeEzpkw1wEmwlYh136KjeKXLsuVuvTIkT44i7JtGHBZPBxJMtI b1cZtnUkEiwzM95cgxlD+Jt2cb3a2R8Pf00Yk0tEl5Fs0zJ0xxs11jA6VlM6he+bYlY9vO4A6ba P57SKWn1usNy/iQKzLpWiJVc9su0Nd8HpLVQgkio4ZZyKD7jslTk9L1FxLHc6CddnQD3sLiJBeE 2PuPE093CRpA5giSsPKUnLaYttH9Oft6WeakJRWHjCoDsvDNxQFgtmWWTaFRmyxlnhhZf/zjp8c +peuWsK2W7RW0KsC8JZxWA18xC/q4= X-Received: by 2002:a05:6a00:2d03:b0:82f:6a82:4231 with SMTP id d2e1a72fcca58-82f8c85475fmr7428020b3a.1.1776707493907; Mon, 20 Apr 2026 10:51:33 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f97eb5ce8sm9299074b3a.61.2026.04.20.10.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 10:51:33 -0700 (PDT) From: DaeMyung Kang To: Namjae Jeon , Steve French Cc: Sergey Senozhatsky , Tom Talpey , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, DaeMyung Kang Subject: [PATCH 2/2] ksmbd: fix CreateOptions sanitization clobbering the whole field Date: Tue, 21 Apr 2026 02:51:25 +0900 Message-ID: <20260420175125.3341090-1-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit smb2_open() attempts to clear conflicting CreateOptions bits (FILE_SEQUENTIAL_ONLY_LE together with FILE_RANDOM_ACCESS_LE, and FILE_NO_COMPRESSION_LE on a directory open), but uses a plain assignment of the bitwise negation of the target flag: req->CreateOptions = ~(FILE_SEQUENTIAL_ONLY_LE); req->CreateOptions = ~(FILE_NO_COMPRESSION_LE); This replaces the entire field with 0xFFFFFFFB / 0xFFFFFFEF rather than clearing a single bit. With the SEQUENTIAL/RANDOM case, the next check for FILE_OPEN_BY_FILE_ID_LE | CREATE_TREE_CONNECTION | FILE_RESERVE_OPFILTER_LE then trivially matches and a legitimate request is rejected with -EOPNOTSUPP. With the NO_COMPRESSION case, every downstream test (FILE_DELETE_ON_CLOSE, etc.) operates on a corrupted CreateOptions value. Use &= ~FLAG to clear only the intended bit in both places. --- fs/smb/server/smb2pdu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 6a60f97baa60..38d3bc66912d 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -3063,7 +3063,7 @@ int smb2_open(struct ksmbd_work *work) } else { if (req->CreateOptions & FILE_SEQUENTIAL_ONLY_LE && req->CreateOptions & FILE_RANDOM_ACCESS_LE) - req->CreateOptions = ~(FILE_SEQUENTIAL_ONLY_LE); + req->CreateOptions &= ~FILE_SEQUENTIAL_ONLY_LE; if (req->CreateOptions & (FILE_OPEN_BY_FILE_ID_LE | CREATE_TREE_CONNECTION | @@ -3077,7 +3077,7 @@ int smb2_open(struct ksmbd_work *work) rc = -EINVAL; goto err_out2; } else if (req->CreateOptions & FILE_NO_COMPRESSION_LE) { - req->CreateOptions = ~(FILE_NO_COMPRESSION_LE); + req->CreateOptions &= ~FILE_NO_COMPRESSION_LE; } } } -- 2.43.0