Re: [PATCH v2 0/1] nvme: core: reject invalid LBA data size from Identify Namespace

Keith Busch
2026-04-21T00:25:02Z

On Mon, Apr 20, 2026 at 07:11:13PM -0400, Chao Shi wrote:
> On Mon, Apr 20, 2026 at 02:51:00PM -0700, Keith Busch wrote:
>
> Fixed in v2.
>
> > you're missing the corresponding queue_limits_cancel_update() for this
> > error case.
>
> Added in both error paths in v2.

Not quite what I suggested. Instead, if you move up the validation
checks, you don't have any cleanup in the error case to do.

And don't bother splitting the error cases. The message about the "0"
LBADS is in reference to the the broadcast identification. It's never
valid for a controller to return an unusable flbas index value for an
attached namespace.