Re: [PATCH] rhashtable: Restore insecure_elasticity toggle

[kernel test robot <lkp@intel.com>]

Hi Herbert,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-nonmm-unstable]
[also build test WARNING on net/main net-next/main linus/master v7.0]
[cannot apply to next-20260420]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/rhashtable-Restore-insecure_elasticity-toggle/20260418-233732
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
patch link:    https://lore.kernel.org/r/aeLgjAeJuidWNy3N%40gondor.apana.org.au
patch subject: [PATCH] rhashtable: Restore insecure_elasticity toggle
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260421/202604210112.4dByOk9v-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260421/202604210112.4dByOk9v-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604210112.4dByOk9v-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from net/mac80211/s1g.c:9:
   In file included from net/mac80211/ieee80211_i.h:27:
   include/linux/rhashtable.h:831:32: error: member reference type 'struct rhashtable_params' is not a pointer; did you mean to use '.'?
     831 |         if (elasticity <= 0 && !params->insecure_elasticity)
         |                                 ~~~~~~^~
         |                                       .
   include/linux/rhashtable.h:839:13: error: member reference type 'struct rhashtable_params' is not a pointer; did you mean to use '.'?
     839 |             !params->insecure_elasticity)
         |              ~~~~~~^~
         |                    .
>> net/mac80211/s1g.c:104:36: warning: implicit conversion from 'unsigned long' to '__u16' (aka 'unsigned short') changes value from 18446744073709551614 to 65534 [-Wconstant-conversion]
     104 |         twt_agrt->req_type &= cpu_to_le16(~IEEE80211_TWT_REQTYPE_REQUEST);
         |                               ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/byteorder/generic.h:90:21: note: expanded from macro 'cpu_to_le16'
      90 | #define cpu_to_le16 __cpu_to_le16
         |                     ^
   include/uapi/linux/byteorder/big_endian.h:36:53: note: expanded from macro '__cpu_to_le16'
      36 | #define __cpu_to_le16(x) ((__force __le16)__swab16((x)))
         |                                           ~~~~~~~~~~^~~
   include/uapi/linux/swab.h:107:12: note: expanded from macro '__swab16'
     107 |         __fswab16(x))
         |         ~~~~~~~~~ ^
   1 warning and 2 errors generated.


vim +104 net/mac80211/s1g.c

f5a4c24e689f54e Lorenzo Bianconi 2021-08-23   95  
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23   96  static void
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23   97  ieee80211_s1g_rx_twt_setup(struct ieee80211_sub_if_data *sdata,
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23   98  			   struct sta_info *sta, struct sk_buff *skb)
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23   99  {
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  100  	struct ieee80211_mgmt *mgmt = (void *)skb->data;
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  101  	struct ieee80211_twt_setup *twt = (void *)mgmt->u.action.u.s1g.variable;
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  102  	struct ieee80211_twt_params *twt_agrt = (void *)twt->params;
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  103  
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23 @104  	twt_agrt->req_type &= cpu_to_le16(~IEEE80211_TWT_REQTYPE_REQUEST);
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  105  
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  106  	/* broadcast TWT not supported yet */
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  107  	if (twt->control & IEEE80211_TWT_CONTROL_NEG_TYPE_BROADCAST) {
7ff379ba2d4b7b2 Johannes Berg    2021-09-27  108  		twt_agrt->req_type &=
7ff379ba2d4b7b2 Johannes Berg    2021-09-27  109  			~cpu_to_le16(IEEE80211_TWT_REQTYPE_SETUP_CMD);
7ff379ba2d4b7b2 Johannes Berg    2021-09-27  110  		twt_agrt->req_type |=
7ff379ba2d4b7b2 Johannes Berg    2021-09-27  111  			le16_encode_bits(TWT_SETUP_CMD_REJECT,
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  112  					 IEEE80211_TWT_REQTYPE_SETUP_CMD);
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  113  		goto out;
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  114  	}
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  115  
30ac96f7cc973bb Howard Hsu       2022-10-27  116  	/* TWT Information not supported yet */
30ac96f7cc973bb Howard Hsu       2022-10-27  117  	twt->control |= IEEE80211_TWT_CONTROL_RX_DISABLED;
30ac96f7cc973bb Howard Hsu       2022-10-27  118  
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  119  	drv_add_twt_setup(sdata->local, sdata, &sta->sta, twt);
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  120  out:
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  121  	ieee80211_s1g_send_twt_setup(sdata, mgmt->sa, sdata->vif.addr, twt);
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  122  }
f5a4c24e689f54e Lorenzo Bianconi 2021-08-23  123  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki