From: Jakub Kicinski <kuba@kernel.org>
To: "Nikola Z. Ivanov" <zlatistiv@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] netdevsim: Initialize all fields of ip header when building dummy sk_buff
Date: Tue, 21 Apr 2026 08:20:05 -0700 [thread overview]
Message-ID: <20260421082005.74a3efb4@kernel.org> (raw)
In-Reply-To: <20260421073738.22110-1-zlatistiv@gmail.com>
On Tue, 21 Apr 2026 10:37:38 +0300 Nikola Z. Ivanov wrote:
> Additionally remove the now redundant zero assignments
> and reorder the remaining ones so that they more closely
> match the order of the fields as they appear in the ip header.
Doesn't matter, now that the whole thing is zero-initialized.
I don't think it's worth the noise in the git history.
--
pw-bot: cr
prev parent reply other threads:[~2026-04-21 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 7:37 [PATCH net] netdevsim: Initialize all fields of ip header when building dummy sk_buff Nikola Z. Ivanov
2026-04-21 8:19 ` Breno Leitao
2026-04-21 8:54 ` Nikola Z. Ivanov
2026-04-21 9:12 ` Breno Leitao
2026-04-21 11:44 ` Nikola Z. Ivanov
2026-04-21 15:20 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421082005.74a3efb4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zlatistiv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox