Re: [PATCH iwl-net v2 0/4] iavf: fix VLAN filter state machine races

Przemek Kitszel
2026-04-17T15:22:46Z

On 4/17/26 16:29, Petr Oros wrote:
> The iavf VLAN filter state machine has several design issues that lead
> to race conditions between userspace add/del calls and the watchdog
> task's virtchnl processing. Filters can get lost or leak HW resources,
> especially during interface down/up cycles and namespace moves.
>

[...]

>
> v2: Retarget from iwl-next to iwl-net; these are bug fixes.
> Rebase on current net tree (conflict resolved).
>
> Petr Oros (4):
> iavf: rename IAVF_VLAN_IS_NEW to IAVF_VLAN_ADDING
> iavf: stop removing VLAN filters from PF on interface down
> iavf: wait for PF confirmation before removing VLAN filters
> iavf: add VIRTCHNL_OP_ADD_VLAN to success completion handler
>
> drivers/net/ethernet/intel/iavf/iavf.h | 9 +--
> drivers/net/ethernet/intel/iavf/iavf_main.c | 52 +++----------
> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 76 +++++++++----------
> 3 files changed, 52 insertions(+), 85 deletions(-)
>

Thank you for the series, it looks good.
Also thanks for the not obvious details, like changing
list_for_each_entry_safe() -> list_for_each_entry() in places that
no longer alter the list

for the series:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>