From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD78339F18C for ; Tue, 21 Apr 2026 09:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776762054; cv=none; b=ASe0SQ262EkfMTuoZb8C0Zd+xdp/soJLifcidBf4jCWSDfuuKd4UT1kqdLaIATXyhrGNXsaSCSOdMeExIB/tAUSqghOHab5t1slrgfltlg7AfgwIePQGWoTqxf/Z9No+IK7MzIyhry16MkvJkcUxnQPnHtooYuwlDX7X2mxPBnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776762054; c=relaxed/simple; bh=BjutMcIEH3kbQHlv3u1kc0EHf31XPA5x+6cvpcO5yEY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E+B53g1po4TMnAInpk1HWSAIwgQ4p2hOFl2da7WKsE/T917dmofpxbJqTlUhWDNSquVMBztI99rL375TKfkrdsfxule0mcNTSyqJYRAEfJsCjGjkuHrwMUIQllJ4mBV5K8ERCxtwX9n+10oPYdzi/xWiJbotNVYLR0TgA0Y/Fj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ue7+Jk+l; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ue7+Jk+l" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-38e9653b580so41021471fa.2 for ; Tue, 21 Apr 2026 02:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776762051; x=1777366851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dthsqIm/Cpxg0B4QgCoO1C8r6BeVrJ1ExMuPMtumgl8=; b=Ue7+Jk+lTAUjZaDV8JrNC5bHrQWgfjBDDODcJIZIQtyZmBYDXW5qk+nZzgjoRMnmXi 40YWmB3Ug/qpARNBJ6di3TId8Y1A7X4bJDAQ2dGii4AD00P5rf810FMugH3+iqxhbJez lyIrO+YNA/WwYfyegTF84av3KM9pLiCVpH4yBdSRAeSdN3g9XIfqmMQ94PPvrNHkACAI pHEPjfEePp1+qM16HYu3EfMsfoPtpBynu+H3z8+IQiL9ZHN2eivHvylJOma1p5Ofk+Z9 vqmZPP9pD9oj20wc4RyXd/p2GPXPbWpJ+lNCLVdTYUje5CfhQnZgaDyvoGMjYF9rjIwL QeBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776762051; x=1777366851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dthsqIm/Cpxg0B4QgCoO1C8r6BeVrJ1ExMuPMtumgl8=; b=ZGxzwkBKZHr1JXoO+Z7oeCETNr+ZSOePlB09W0R4B5lTdTAQ/WssKqn0x8g6LBBKwt esiZAWRqrZ7RT2alLKPxrs8+nf2JzPjz8N+uHWFMp+hFUDn6kSYRQBi4pB5slnGYYeIs DVvLRPptSFRi/B6aqUSsZYI7k1WR9+hOqyk7FGrgXsnrhVZ+AwTR0yAvAN+aaVbpF0ha ewZrdZknVEvPOVjtWQvLswQ35lPm14zYX5kmjThA420TCXfD0mskQv2nPuJRD/1mcPk6 ouLeJmnZw7jIz9moL8TD+jpyYZCU4rUifZsezK9RtG7inIY+SN51WbZQAUbR/MHCAJiB lgyw== X-Gm-Message-State: AOJu0Yy1RHWrOR0kwyJtb001MlkF4DW4jecDK/zlYyFaqVO+e6+cVGhn TcKZzwP8ShPVRBcXdQHodGHzxxidQQGnN6yV3euwoBLqJJWQWxYY9Cnv X-Gm-Gg: AeBDiesBZaq0bwL+jWR9puCzfy/+2owVCtQmjyEJw1+A2PZ6DWpN+r7JebMg+nWOLRg W3CxKYtXA+t/0h8SWhpYVbocNZXdNjR3BK6hZpe9m2KOcep/pio4dCt+EWLoK4mMe6LhizmQ80V g6a3yCDYO91r11tDmHOlAif+mAlyN5+/r7NksUF2mxPkkE/QKVNZls8HdLLUtlgzaV18GgDHFb7 hiUv7owHUOgYTsRO1SO44yX2H9HYxjVsU9YO9MHR6qXOqEkkiOb4+z4MBZMRnWYuEnNsl8KSXcj JhACwjBgYzuIeDo9wNjq2j96ZuZJl2RgqlvmLhriPxQayKHQGCay3NfZQs7sWyntj902f5sHbp+ PkTHOvXQfzyLNxpRjDcwShcaGCjeu6xlbWzTX4XCwCZGAwURW1G0KmGUGAIbSbzXw6PWAOlyP6q 7/LkkbyqnoT9oZFejL3E6GP9Smx5jdF5o= X-Received: by 2002:a05:651c:1551:b0:38e:d3ec:4fac with SMTP id 38308e7fff4ca-38ed3ec5605mr47926221fa.3.1776762050707; Tue, 21 Apr 2026 02:00:50 -0700 (PDT) Received: from thinkpad ([178.205.156.194]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38ecb75b033sm28583931fa.39.2026.04.21.02.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 02:00:50 -0700 (PDT) From: Matthew Bystrin To: Lee Jones , Richard Cochran , Min Li Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 1/2] mfd: rsmu_spi: fix page register setup Date: Tue, 21 Apr 2026 12:07:09 +0300 Message-ID: <20260421090710.395591-2-dev.mbstr@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260421090710.395591-1-dev.mbstr@gmail.com> References: <20260421090710.395591-1-dev.mbstr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix writes to page register in 8A3400x family (Clock Matrix). All calls to rsmu_write_page_register() have resulted in early return, becase all addresses in include/linux/mfd/idt8a340_reg.h are less than RSMU_CM_SCSR_BASE. There were 2 separate patch series which have to be merged in one time: mfd and ptp. The latter have been merged, the former[1] have not. Link: https://lore.kernel.org/netdev/LV3P220MB1202F8E2FCCFBA2519B4966EA0192@LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM/ Fixes: 67d6c76fc815 ("mfd: rsmu: Support 32-bit address space") Signed-off-by: Matthew Bystrin --- drivers/mfd/rsmu_spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mfd/rsmu_spi.c b/drivers/mfd/rsmu_spi.c index 39d9be1e141f..55c5698e7e77 100644 --- a/drivers/mfd/rsmu_spi.c +++ b/drivers/mfd/rsmu_spi.c @@ -101,11 +101,9 @@ static int rsmu_write_page_register(struct rsmu_ddata *rsmu, u32 reg) switch (rsmu->type) { case RSMU_CM: - /* Do not modify page register for none-scsr registers */ - if (reg < RSMU_CM_SCSR_BASE) - return 0; page_reg = RSMU_CM_PAGE_ADDR; page = reg & RSMU_PAGE_MASK; + page |= RSMU_CM_SCSR_BASE; buf[0] = (u8)(page & 0xFF); buf[1] = (u8)((page >> 8) & 0xFF); buf[2] = (u8)((page >> 16) & 0xFF); -- 2.53.0