From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E9963D8112 for ; Tue, 21 Apr 2026 14:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776780912; cv=none; b=tkPiey+lQOsq63IJqtknLM5PSm3VrJaq1/1zW5fjkmpzw+t8KVZ7gswBCTRUN1DazfoZMXED9VpRlGgMvBMFVx5HjfJl/IkUEQ6uFfKkqogoDZWoMEMGn5XN0OKHaKOjmM0TVgXh0QmokNtOYZgfoyBt2XM2KagZS9c617ByU4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776780912; c=relaxed/simple; bh=XiLcP/LPrCdCh3xpZQsGzM+Q8XAFL4cckbFaJxwRI1o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l7B9eMK5kPxi6UyxDNVF9SlohIOQpCQNyPyhEJ+a9kCKJbeduTflchd3jnUsQg/BIiof091T1cuyeQRHKEB5Qjziay2X75rq0nTy9emUdnx0r0bcGfwjkwkSDo4cxOtmhCGzu9pTERoWjx2Wg3XB1m+9BVZQQSP3nm2B5lWOlaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BGQVek5J; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WRcb50/n; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BGQVek5J"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WRcb50/n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776780910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sBspbL/u+4h/YiAyL1HV/VPAyarYaOL540HM7IEPE4s=; b=BGQVek5JdQ8sPAcCIQyS9bw6gdjW/19DYiMgSmb5BeRmXxZGhG8FUhQpbNmu/e6MBGmeF9 Cd95Hhe9FNaFhyN53SH423yw/ZFFP63TU9xIMTi4IQRxHW6B++yyMFQADMcmWOb35Muxn+ 9GRU2U+nnn+EbmqC3k883haR8R3fXWQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-1dvlbfwvPMq81sKj1Rf_nQ-1; Tue, 21 Apr 2026 10:15:09 -0400 X-MC-Unique: 1dvlbfwvPMq81sKj1Rf_nQ-1 X-Mimecast-MFC-AGG-ID: 1dvlbfwvPMq81sKj1Rf_nQ_1776780908 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488d1b5bca0so23529665e9.2 for ; Tue, 21 Apr 2026 07:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776780908; x=1777385708; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sBspbL/u+4h/YiAyL1HV/VPAyarYaOL540HM7IEPE4s=; b=WRcb50/nE/4DPG85EMds5xlYUuMiI80k1mRoQjZ6YEcV6RgShkWpR9NgnkxniVSPJe miqj7H/bE9t0v1Ksvcgr0I7Y7b4Y+1ZPfyV00TCEmW1IA3PtcBO6CXUmuNRJRfnIy0Il 4kHvdUjxCjfuSRnJr+jI3A5X/g2giTymlPs1jy0nBiidfcyNPsaLbmbv3qzxZgvCLFEO DDZK576PuSlpuyXRdIrZv5+ncAA4MOfwxd97/PO3XClDPYRgW9MIh0xlUqTkg8D07SUP 7WZHD2+LWs5M4w76+S4iT3oKdQm9IuBo3CNzPHrGGZHO321VdKuPmICBC9SLe4H1emI2 oEdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776780908; x=1777385708; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sBspbL/u+4h/YiAyL1HV/VPAyarYaOL540HM7IEPE4s=; b=jpnnSaR8jXbTdT/pdxu5uL22j29SgknoLbdsmoMXoF83DZzbs6iLCLf5ZXBugEqGYt wO6N2lGmvzHDrD2McG/SKPxXSgUj+haHOk/r0LM1zvPfA4LhJFcI+V2Mu6QYzqWrakrZ +1Q596zGBZZhAkSaNvqYV8gg9ofDaZZBL1t2McQSFwpCZjgmkcEEoPaTSNFvrai1YEpU XKPazSqTHlerjeAoRtw2I4v145hX2TdXtBdulnAvh2SgKVUIjt3jdQx4+CPRxGRZWe07 OMvX194y5n6xMeSd7Va36zP0a3TKkYhYu2gW2S5c/o+ex/DrGszdUxR0ojs+qdoq7J7n kdow== X-Forwarded-Encrypted: i=1; AFNElJ+m9JledZWlc6IO7w7qTPakBZukTEWqbz5l3Bu/aagVgLF96Wb/XCGRcwiSPz0TR+4igbz1f84d+UNly/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwaUx9RG9oPBbD6g6fL2URNuisI2JoJIUoXy5+qc4acAk5USKk6 79REqrhqD4uuFrkduItxlBdw0rwwm47oJcExK3QWltgqAIR4Hl//lsmQKvrsWFP9AZXRtt7L9Ki xfjdYRj06nrfSYQue9nX/saGrEGYolmySz7xfm6x31i8lEyatlli7p3DHI9YZo6xMFA== X-Gm-Gg: AeBDiet1j3z0y3Ty3Yg66sbm/yc0X5XdbQ3QOwjge4CLsa+sTW2vRgUJmO9Y3pH1Gaj ZlgPJnhaSQ/eYuco5cBn9HsLrPe1u3nbAPjmE8DaL/4kC+5zU84h+Yq+3bmIwh7awSixLfUrc3h mW7RpQBrVs030j1vVo2KGnjzRkM0dctRbrvFy8oyLTaLd5tr9yVDgdvTE3mwKWmlOA1xO9f98W+ JOCmwdkzt6lE2Ewzza5upH8EQ4JkUjAz28RlbyRzJYjMaIxJ5jLniNlVtt/NfLqYqZRKinyQ5+P NgNlcgFOhxd1V/HncqZAaOYfWVL9MvLxKeX6ZegFI2mj/mRh8zgQ0Fm6a98SeMGYye9WckQ/vjG ZRAxqc0Ao8GJ3Pyx98F/91ytsp/w+E4md6OePNTNhmx3U/81n1PzxCQ== X-Received: by 2002:a05:600c:3b11:b0:48a:525b:e148 with SMTP id 5b1f17b1804b1-48a525be2f8mr82580065e9.4.1776780908057; Tue, 21 Apr 2026 07:15:08 -0700 (PDT) X-Received: by 2002:a05:600c:3b11:b0:48a:525b:e148 with SMTP id 5b1f17b1804b1-48a525be2f8mr82579225e9.4.1776780907341; Tue, 21 Apr 2026 07:15:07 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-21.inter.net.il. [80.230.25.21]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb796ea2sm166370405e9.7.2026.04.21.07.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 07:15:06 -0700 (PDT) Date: Tue, 21 Apr 2026 10:15:03 -0400 From: "Michael S. Tsirkin" To: "David Hildenbrand (Arm)" Cc: Gregory Price , linux-kernel@vger.kernel.org, Andrew Morton , Vlastimil Babka , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Jason Wang , Andrea Arcangeli , linux-mm@kvack.org, virtualization@lists.linux.dev Subject: Re: [PATCH RFC v2 00/18] mm/virtio: skip redundant zeroing of host-zeroed reported pages Message-ID: <20260421101409-mutt-send-email-mst@kernel.org> References: <20260420192037-mutt-send-email-mst@kernel.org> <0bb2d565-4b3e-4b0b-8e81-57898d8a2a21@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bb2d565-4b3e-4b0b-8e81-57898d8a2a21@kernel.org> On Tue, Apr 21, 2026 at 12:04:49PM +0200, David Hildenbrand (Arm) wrote: > On 4/21/26 04:38, Gregory Price wrote: > > On Mon, Apr 20, 2026 at 07:33:38PM -0400, Michael S. Tsirkin wrote: > >> On Mon, Apr 20, 2026 at 08:20:57PM +0200, David Hildenbrand (Arm) wrote: > >> > >>> > >>> Which would *already* be the case of you use folio_alloc(GFP_ZERO) > >>> instead of magical vma_alloc_folio() + folio_zero_user(). > >>> > >>> I don't really see how vma_alloc_folio_hints() -- that also consumes the > >>> address -- is any better in that regard? > >> > >> By itself, it is not. But the issue is propagating the address from > >> there all over mm. If we miss even one place - we get a subtle cache > >> corruption on non x86. > >> > > > > Why does it need to propogate? > > > > Can we leave folio_zero_user() callers the same, but add a PG_zeroed > > check in folio_zero_user() that skips the zeroing (but not the cache > > flush) and clear the PG_zeroed bit? > > folio_zero_user() is just an abomination, really. We can't completely replace it with GFP_ZERO though e.g. because hugetlbfs has its own pool and needs to zero that. > -- > Cheers, > > David