From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70A83AE6F8 for ; Tue, 21 Apr 2026 10:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776768422; cv=none; b=rGAPPIHE3H5KkrSXz55VbVv4r5yiTqnxLpoOuIdetiDReZVIwSfDQ9+2zwIf4g2UkXlxtlMc1htkcSDUxGt4uSAidr2cwkuCtD9ObfOuoSjsgqLGczPC9gAmmnhIJkMoycouru3WdkVhclNMu3wNYThROvZm+vZ4XwJwMBpAtAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776768422; c=relaxed/simple; bh=jhuexCHU6ECDBpnRsUzpdW9ej8BppDujUy588VT8vHo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=q7NvbZZcf1mdPE6sAuFVsSfk7yIw5BJPy/QqLi4/oE1rzp3MBVDe9ShfdcYpWgUqhxeUwo9/Lu3x2VWKNkXGs25uLYxIQ2TmYhlQgnGwOUV2ghCaFGF1ewj25bJcHbYu0ETLkpLovDX7cNOpvNmup9X3U9uF1Y/LxQp376zpfcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JjuHkk8O; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JjuHkk8O" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2b241be0126so82505425ad.3 for ; Tue, 21 Apr 2026 03:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776768420; x=1777373220; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4Uq/uRpREn5XIIRm9bsEmT+nBdZqaFV7D4pSp2A3MzQ=; b=JjuHkk8OzyPJcgIgTRKmSkCNAvw+zStk+LWWn/9lX7yz8xTCRwy00O/lsbjCXI6IEG mz+GMjoD08gy6r79cOLV+4wurzS8Z/lOjw3sOGLQTYheAOYEBMmbW8U451xx/W1EzgqR VBM1qWvwxzlVveEQB8SRR8KKvhRoaWv9nLREer4qNz+5BA+jMZbOyGXfELYFSJgDDsWn b3ut6B85GzTcA/5A3SMwMBHxeOdthObudUA/MUNnOBu8TC1nSr8QHUVcqiyohG4VArne yE13qCCI4Bp3MAa1yH/6vLAmItvHxgSknk/os7PqRIWdzTIIuRFC+CkwMlZyP8DfKUzY B9dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776768420; x=1777373220; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Uq/uRpREn5XIIRm9bsEmT+nBdZqaFV7D4pSp2A3MzQ=; b=P/8qAAO1amYBVVx68dn/7ZqO22FfoHHPCvaIdQFKGzKrj/ga8K243b9qM3u3EwVME4 cFFpC2YiPDR04dd+t4GN7Za2tMqKdLNP84fyrPma1RBE7ySefgGyugVmcZPKHDI+E9r/ FlT0JfHVST1wmBGOV0mX6v0kEIOcSdVIGNkKheoJe5i6DE2PPPHXXEnmXhaWiBdz069r ezYTuanSv0kBYBg5EcFntcz2++gt92ANnwsRH5j+8OTH3b5qBI52Fv4iq08J7/jZgUWN 1b+DbMPigsdm8cEvBjI1WtVTU2zVmOi3IbWJ+L8Kja/S1xqWRxg7yJMBQr+3ai8vPWKv 295w== X-Gm-Message-State: AOJu0Yw9YZsbLz0YZS3oHCRlykwNOKGGYiVoZwy2wcbZD12VALvIbGG1 wqbMpS9aPAkA/4T+EWrohJlhSfXBqHB919lNAgKuyw34EWpXA68OKPcqufu3/Hx0r1a2YNcmmvo 7jwtniIii/eDR8gyDDGep6xBafw== X-Received: from pglc7.prod.google.com ([2002:a63:d07:0:b0:c76:8ec1:5090]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:6a20:b0:398:9d5f:e093 with SMTP id adf61e73a8af0-3a08d74e6e5mr21273139637.19.1776768419944; Tue, 21 Apr 2026 03:46:59 -0700 (PDT) Date: Tue, 21 Apr 2026 10:46:52 +0000 In-Reply-To: <20260421104652.211276-1-joonwonkang@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260421104652.211276-1-joonwonkang@google.com> X-Mailer: git-send-email 2.54.0.rc1.555.g9c883467ad-goog Message-ID: <20260421104652.211276-2-joonwonkang@google.com> Subject: [PATCH v4] mailbox: Make mbox_send_message() return error code when tx fails From: Joonwon Kang To: jassisinghbrar@gmail.com, sudeep.holla@kernel.org Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Joonwon Kang Content-Type: text/plain; charset="UTF-8" When the mailbox controller failed transmitting message, the error code was only passed to the client's tx done handler and not to mbox_send_message() in blocking mode. For this reason, the function could return a false success. This commit resolves the issue by introducing the tx status and checking it before mbox_send_message() returns. Cc: stable@vger.kernel.org Signed-off-by: Joonwon Kang --- v4: Detach it from the previous commit that supports multi-thread in blocking mode and rebase it on the latest for-next branch. v3: No major patch since v1. drivers/mailbox/mailbox.c | 6 +++++- include/linux/mailbox_controller.h | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index b00f7a32e866..066702e5a46f 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -98,8 +98,10 @@ static void tx_tick(struct mbox_chan *chan, int r) if (chan->cl->tx_done) chan->cl->tx_done(chan->cl, mssg, r); - if (r != -ETIME && chan->cl->tx_block) + if (r != -ETIME && chan->cl->tx_block) { + chan->tx_status = r; complete(&chan->tx_complete); + } } static enum hrtimer_restart txdone_hrtimer(struct hrtimer *hrtimer) @@ -295,6 +297,8 @@ int mbox_send_message(struct mbox_chan *chan, void *mssg) if (ret == 0) { t = -ETIME; tx_tick(chan, t); + } else if (chan->tx_status < 0) { + t = chan->tx_status; } } diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h index dc93287a2a01..26a238a6f941 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -120,6 +120,7 @@ struct mbox_controller { * @txdone_method: Way to detect TXDone chosen by the API * @cl: Pointer to the current owner of this channel * @tx_complete: Transmission completion + * @tx_status: Transmission status * @active_req: Currently active request hook * @msg_count: No. of mssg currently queued * @msg_free: Index of next available mssg slot @@ -132,6 +133,7 @@ struct mbox_chan { unsigned txdone_method; struct mbox_client *cl; struct completion tx_complete; + int tx_status; void *active_req; unsigned msg_count, msg_free; void *msg_data[MBOX_TX_QUEUE_LEN]; -- 2.54.0.rc1.555.g9c883467ad-goog