From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 291533D6CC1 for ; Tue, 21 Apr 2026 13:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779374; cv=none; b=ZotJo03dTLspwRzZxxkh618vNW4Tjkv8dFgL/V8gMUWABDYk5sioL2D80lQBOfb2mIKGRWiBS9BbT4RO49WFYS0J/QyAz/Z3NzSBCvx6ehavtDKHcRpgEzQYzl9gwDi0ext2Djka3rACivcGCoFBOUF1XCsP9w+kIXXdchCGO7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779374; c=relaxed/simple; bh=eU2PqVajCx7C9hG12bCOjfZ2cSR8pQR5MC85pWwkEJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JTk96wGk5QkHKPQl6vzYaUVOMGUsXlwJrsgzkZLdNnru8Oawb3XscGUot9X1LXZ1hPXSJIzU/wwhqL9Xjw4LOkcNyCVucsJHKtrrQzOxJ4J81qfTAnpu1fzgG72xG9EzhT+X+fue7364/LwNv2E2mXVGeMLNZjT+g1gpXfE76hU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M4jrl6sW; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M4jrl6sW" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so6793025e9.0 for ; Tue, 21 Apr 2026 06:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779371; x=1777384171; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YkmQzi5Gnl//BDK8FQBprWJdIzhvbcB7BpCe6DN/Jac=; b=M4jrl6sWmdKIycdOcrf3MkbusxYOZ3IAHQfF4ZaJEH1azu1bTU4RnuF3KoNXQNUijC feKee3bxVPpEW9aqGU4lwCR+AsR+/Ki9+G2xRJcyJeW4mgJLOeNhbkhmpUdeDAr5Q/eI Mlb359q+J6LouX3KBJE19eFxu23VTaoAr7SLDTEIIfvh3Xd9XzX4CwlyGKCl62KmZel5 9owbh2s9i4qokv7oXxklMw8r03u1rpT8RDs08b9ZO5T9BrwTOvH5ZriN67NHq90w9QNq O5ak9MSGQJus/dX8KEklOURzV2jmXopCCYLZc87AtT2Faz4X0irSEstzTOo3lHA1DbBM aZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779371; x=1777384171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YkmQzi5Gnl//BDK8FQBprWJdIzhvbcB7BpCe6DN/Jac=; b=AqDnRpCo7MZnYW7WIfafmCES46Md/BtrY/7ym/NpJs7vMlXqGesJh/ijcttn/bh5NZ r2sSoonZLWKR/vcoOBi4vk3md4qQv4qpJgU3fdgEhT+u4DSaBILeuRdwWA1QDLYHO125 bymzgHa0WDB5fmvSKQT8RYXUV6OOe78wdTKuBKGBfhHBbbdGkJw5kt8eR9iChvF5p9fD EAEeNygX13ib1JDD4iNyX9yFr/0X32AjmgIzQupAXNEWSAZlXnrgsWdLWqOXO4eIZGQj rK1uwnwq+1q1c9gNToy+14hqiqevDsa8aqeeUtpiFpZiBrz6mKqWbC2z5QgxEF/fHy6T 15AA== X-Forwarded-Encrypted: i=1; AFNElJ+E2UKgD4l9HrjYSrg2qbU3UTaNEHwsT8/5g4sTYa6ZMdc5t30gBemsF/U39yLiD3mM1fi1TmisWXmPkTI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5fRetV3WsfIkM9oRlQFnqx1jpOI3B68vaRuQfao8shIFsXIb4 TPPb+0inxcaXmX+Zqzo8/yrbWp6S75pnkOIVMR3ag+UF2bv2fVkwZ1i3RnWX X-Gm-Gg: AeBDiev1q9Bghpx1h/8m6RirTQtL22o8keRjfkram3n69KtWhqQgwhyqRqajmJODe1h sCE5XDkqS+C8QkPWxOtBtJGlw0kKMNXGBZcaVDX2As66i8uB9csQ30/yB2x4GWv0ZlRpcR4Tywc E928eKODeVJM/+uSbNXk+nUANRl1gM0oJK1Z94raozzUIgwdSbDfRaJrC2v4chnw4iUpt1XJJnU 1v5C+SuM22NetDsyolmnW59GPUOBM75xgqfWxbD2AzN76o5Vmgnb0QwmnJBn3w4jHd82HLC6zBz IGhGRaweSfIYo+XzieEqxAY+dxJ6BAta4V4+lfQCi/b0Q1IHXEhU2xXjYWcUMW9KKI+4Pbed66X jFROBsw6ERu6PPE5dD59dwReDbdiMyUMTpt3dldKkMc87yMBiL+UtCE/26PK9CqWw/jsASjP6fU SZHjk= X-Received: by 2002:a05:600c:3e05:b0:486:ffa3:594 with SMTP id 5b1f17b1804b1-488fb78049amr264260995e9.23.1776779371241; Tue, 21 Apr 2026 06:49:31 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891c318636sm168157785e9.7.2026.04.21.06.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:30 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 1/3] wifi: carl9170: bound memcpy length in cmd callback to prevent OOB read Date: Tue, 21 Apr 2026 13:49:26 +0000 Message-ID: <20260421134929.325662-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134929.325662-1-tristmd@gmail.com> References: <20260421134929.325662-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani When the firmware sends a command response with a length mismatch, carl9170_cmd_callback() logs the mismatch and calls carl9170_restart() but then falls through to memcpy(ar->readbuf, buffer + 4, len - 4). Since len comes from the firmware and can exceed ar->readlen, this copies more data than the readbuf was allocated for. Bound the memcpy to min(len - 4, ar->readlen) so that the response is still completed -- avoiding repeated restarts from queued garbage -- while preventing an overread past the response buffer. Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch to produce valid index hashes (v2 had post-processed index lines). Changes in v2: - No code changes from v1. drivers/net/wireless/ath/carl9170/rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c index 6833430130f4c..f6855efc05c0f 100644 --- a/drivers/net/wireless/ath/carl9170/rx.c +++ b/drivers/net/wireless/ath/carl9170/rx.c @@ -150,7 +150,8 @@ static void carl9170_cmd_callback(struct ar9170 *ar, u32 len, void *buffer) spin_lock(&ar->cmd_lock); if (ar->readbuf) { if (len >= 4) - memcpy(ar->readbuf, buffer + 4, len - 4); + memcpy(ar->readbuf, buffer + 4, + min_t(u32, len - 4, ar->readlen)); ar->readbuf = NULL; } -- 2.47.3