From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B76E7288C08 for ; Tue, 21 Apr 2026 15:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776783793; cv=none; b=qUwbH7cJbq7YbhMBL+AvsizvW2f05QfNe/r3lh2334H+EjSQ3sbuzCKJw+hLfThBIFLql/BogK4FTrQ8e1SmEyRhddpPbruzdr8kNp8iyd6Jt1NIveOE94bFVVxB2uS1hqp4oYH/h4z96irQa53eRlSnNw/7LkOqoxF5CJmfI1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776783793; c=relaxed/simple; bh=9g3J8B+xdxtvnQfXBYhaMIv5GB+x26NF8Rn4DfqUI/M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kT3l+Iv7Wl2KsysztjHzbr70rJ4EtuTpzNLEf9oH3AdKQHjQh2dhjUE2a9VnEceOCTzrbNgUemJaABg9mX4YUcIFxN9MNfJ4nXvSsrkcRGzP7MYAbOmdiQmow3h/uFdwjovyyb+uDAs/rvW5EJUA3sa7ux5yNYwz1p5Z3/Uvb/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=cgnXEr9A; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cgnXEr9A" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fi7RqWewM5Hc3+FiMOKBokozqsq7O+/mqRZWnxWizYo=; b=cgnXEr9AkaWMzS2awjYYo3juNf lw6234B2THW135IC0nvnz0Yw1peoWCjiKvSiWK8Dz+bX5KJHH9Fg02ZbfvCbePqXdNm2Kdhl9JVAF 80TFfihMsM0mBq72zs9KfLA0jSiagQ4cIqGS5paX9RAPFM9hMRdbyp1lTPLCVGpUqgUSb1x5aHI/+ Mu7jCCm5Crk5boEwStebEOvur7VF/x6w6VlD/++LJzu1wxVUiXmyT14un6/72rW7f9ZW+B39iWzGx yNHIZuNItF55rpgBHX+SVou4uA8ffmatirtnLEmeaSUHopsjqUO2R+RSA7Qulpep6aQpyuxWUZkPK GmdROzFA==; Received: from 2001-1c00-8d85-4b00-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:4b00:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFCd1-00000009z9t-3ELn; Tue, 21 Apr 2026 15:03:07 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 4ECCD300708; Tue, 21 Apr 2026 17:03:07 +0200 (CEST) Date: Tue, 21 Apr 2026 17:03:07 +0200 From: Peter Zijlstra To: Matthew Wilcox Cc: K Prateek Nayak , John Stultz , "Borah, Chaitanya Kumar" , linux-kernel@vger.kernel.org, "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , "Kurmi, Suresh Kumar" , "Saarinen, Jani" , ravitejax.veesam@intel.com Subject: Re: Regression on linux-next (next-20260324 ) Message-ID: <20260421150307.GE1064669@noisy.programming.kicks-ass.net> References: <20260327163100.GL3738010@noisy.programming.kicks-ass.net> <20260327164353.GM3739106@noisy.programming.kicks-ass.net> <20260330195037.GW2872@noisy.programming.kicks-ass.net> <20260420130318.GD3102924@noisy.programming.kicks-ass.net> <20260421101521.GO3102624@noisy.programming.kicks-ass.net> <95651a71-1adf-45ba-83eb-5744bc6d4a52@amd.com> <20260421143752.GD1064669@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 21, 2026 at 03:45:02PM +0100, Matthew Wilcox wrote: > On Tue, Apr 21, 2026 at 04:37:52PM +0200, Peter Zijlstra wrote: > > Argh, I see... yes. Perhaps something like the below though? > > This is a documentation bug. I thought it was supposed to add *after* > pos, not before. So can we clear that up too? Sure, that comment is indeed less than clear. The comment in __ww_mutex_add_waiter() is better. > > @@ -198,7 +198,7 @@ static inline void __mutex_clear_flag(struct mutex *lock, unsigned long flag) > } > > /* > - * Add @waiter to a given location in the lock wait_list and set the > + * Add @waiter before a given location in the lock wait_list and set the > * FLAG_WAITERS flag if it's the first waiter. > */ > static void >