From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B465438758E for ; Tue, 21 Apr 2026 17:13:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776791617; cv=none; b=JH0M9Fc3VzAi5M4gtrgZ1bBQCUk9LaR5A1Wx3M81GaMxQ5baY60qQ0asnAn0JRm0E3m2KxsPy/cohQOaInBjp6yKff4JcED8Gc0jQcdbMEBLdP4Ne806qX8IlE0tv0dh2eYwzuZTBKArjYHLWiTBM3NnHqRvPogx7eH8QTWDOek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776791617; c=relaxed/simple; bh=dNPqhdaCExXnqljjtmyEiK2FfGUZQrh5olPv++EE6Kw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=otAn3o8Yp8qtnoDlu6HTxf+qCvVjgyr7+BGR+OEn6xFdVTt3L08Lse+qzLPPkyLfsoIkPqsfqV1eNNXcWBF4JxzEyFrqCDys2hqGFsxweTJZruZYwYCiHrQD4FDhI+Nq5rABqQrf4lxnj3H8118JEOwR3fUQ0g+3y5CIibxp6Hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b4583f0a1aso28313275ad.3 for ; Tue, 21 Apr 2026 10:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776791616; x=1777396416; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NOptXCQFoecDGSEMq5oXbgb/TQScxdLgsFvp93S1GiI=; b=gM1NB3sbVyUv5vqV8WkjhXPWeIuJi7ygFI8QlhjYpHMMRZKVDmY4pbpV3wYK6kfh18 JFR2R+9RFQUOYD78Xk1DSyLiHRkUQ8DLiq8bB72hYzpVWLzTCrQitcgZ1YzqzD9KW+qA VOzW6t2X99tetRtH2bc05Rzt/+ECjzHBfteQDxFPEBJ1dezWIBZ5z7ciUuIWgtcHqEVj 1UkFQ+D2uQJsY3nnMA9Wbqit9VqLXgCBqU08C6Ul6kOuwJsjC1uEDCl+MHrv0lmYevSb NF4KkuAo2V3aZHlDML3fDOTHcdglLeM89ftHq/yU7grmZO9v1ZKcpk161Hg/OGivPuXr wHaA== X-Forwarded-Encrypted: i=1; AFNElJ/6k7/BZVH9TmFQ/DGnjB/8HUMqFRAqkHgqmrVmMaEO7qONcMCLmZ7E+PIDOw+leMt8vWxchYAL4Ir9HI8=@vger.kernel.org X-Gm-Message-State: AOJu0YzdbqljIG4nSdGhnaqgDkJnCofDi/QoHz51eVZV9uWoNHkNcX5P 1aIXYuqlZeNHdzuxfYU/fsKAYNjwiszyNryJLP6PP/5F254u8Wur6Sen X-Gm-Gg: AeBDievjyCLFv7Dzue08VUFz3WwqSFwroYlnA51yOOTl4+pmvZRH894u/ccY9VNE77c g/qxBvDcONk7hk/UihfWhVvQMdFsobDPtHN+SnX8HI5Izj5ZD6Fl3QoZH/1DIXVltunFwDxVkn5 QcqXWgpeKYBqb8v35lTQ6QqrasKHgrbJyf/xAMaLHmOKBwrcGPaI/mCqZQtVOezh8W9cip2L+f2 xKXAZA8eTWlsa0H6ZZE3ZpdPWjBa7hrdF5mJaHBa2hp0u0t78YXymDijjfz1FOETyVsPgzDE3sD 6LWQBeWQvl3qiQB8Wxk1JdpxCcsRyhnO/CJv87nOVoO8+63aguX/Ezk0AGmw0vDbDy99PIIlTTb 4hphrvZlt76diDLnWfp162op+LE5X0fNrcIZx5bwcvWg4s0zaWf4gmCJLQvV4TOSTCUP8+h8oWB M5GlsaPh2JDVGqkevTgYgJsUuv107z4pNxFBVVcVYwzVpaMTaOOQRSxhggJTz90j/xiVgbkoFpF vL0O0GqvIyVsDRQMs+RRYNVqbDRqOKdLYVrbmo+zdwe905IeysdcBFtchE6pszAUeoBSi9icczH rlAEfzRyOxj+pY9lk5TYF3ScRUZ9tQi4jRaPUM0n4Q== X-Received: by 2002:a17:902:bf4a:b0:2b2:4e5c:69a9 with SMTP id d9443c01a7336-2b5f9e79fa8mr145008315ad.5.1776791616146; Tue, 21 Apr 2026 10:13:36 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9ff713sm142070275ad.5.2026.04.21.10.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 10:13:35 -0700 (PDT) Date: Wed, 22 Apr 2026 02:13:34 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Ramesh Errabolu Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Bjorn Helgaas , Lukas Wunner , Niklas Schnelle , Peter Oberparleiter , Matthew Rosato , Gerd Bayer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev Subject: Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events Message-ID: <20260421171334.GA1684602@rocinante> References: <20260416213909.705753-1-ramesh@linux.ibm.com> <20260416213909.705753-2-ramesh@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416213909.705753-2-ramesh@linux.ibm.com> Hello, > +static struct pci_slot_attribute hotplug_slot_attr_uevent = { > + .attr = {.name = "uevent", .mode = S_IFREG | 0200}, > + .show = NULL, > + .store = uevent_write_file > +}; I think, you could use the __ATTR_WO() macro here. Thank you! Krzysztof