From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0692FFDE3 for ; Tue, 21 Apr 2026 17:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776794092; cv=none; b=YyXBHtrAGYLL4gwMaQZqnGVbmJZx4vEvjeYRNAsMa9sBPOOtb+oEFMtvGPLu3KmA0RXjCDZWS5Vv47EZ9UeEAXp/2OjfEo54WRGiepfOhZdMDbTQwjPkw7cKlz6nygmSbNhm90N2hzbwxrNejlxY/7y++KsW5Z0vSLtgyk4REVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776794092; c=relaxed/simple; bh=7R5KiZVWPGMisYuzQJsEbYOq5Z5KTDBUHJNw2BHSXtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZYFYMe9ispw6CMFA92lDdW8Px+0myX51oXaR1b91BbHWi5B3FQ6BKYDoDI+26YILN7AK3bNgXFSYbPkqu2eCCWHCJxW3KwzyxFPJ6dRAdsDjwn+lyVWXkG3xeTJQg3kyhHtcyO4wifPJNZAiejhadcbh6YKhra+YZgJOu+9hXMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=i4rfSUU7; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="i4rfSUU7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776794090; x=1808330090; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7R5KiZVWPGMisYuzQJsEbYOq5Z5KTDBUHJNw2BHSXtQ=; b=i4rfSUU7pb9sgUWIk4s5p35iTAEzXxKRh3EKy+UIV8G1G0iQJy8NMKT4 WJXXPp4gMQAh5/EFtcu8BeNZDfSX9r7a8jWaZtC18ec1hiE0N5qzy3fn3 qehv96Ctr2yeer4OJ0WZuBd4IgOufQqhNiA1fBG1Mtp2BAcTRf6xfkhuK EHsrDzvdPU2Z4FuT5R8IvS6+1XjFrQv7uV1/BxyWVKqp7dZe9dvrBl7bn nN4ys++t/uqXIaL6eS0sZAh2ps1T8+PbBEE7F+a7fcPVc8q8ujq2pNrix 83Ylms3Ze2138P304uudLWilZ4Uh8VylpptmAq9T77tC71patfOZWdcB0 g==; X-CSE-ConnectionGUID: KblI7sfOSG6jouUSKhcFiQ== X-CSE-MsgGUID: FMQdfGV7SGukq34KXqWIow== X-IronPort-AV: E=McAfee;i="6800,10657,11763"; a="77651344" X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="77651344" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 10:54:50 -0700 X-CSE-ConnectionGUID: wGdh/BscRomcQnRPr+Spiw== X-CSE-MsgGUID: GlehnzN7RXWMchg1J5KLhg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="227494836" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.242]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 10:54:48 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 01/16] i3c: mipi-i3c-hci: Fix suspend behavior when bus disable falls back to software reset Date: Tue, 21 Apr 2026 20:54:20 +0300 Message-ID: <20260421175435.122094-2-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260421175435.122094-1-adrian.hunter@intel.com> References: <20260421175435.122094-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit Software reset was introduced as a fallback if bus disable failed. The change was made in 2 places: the cleanup path and the suspend path. For the cleanup path (i3c_hci_bus_cleanup()), after software reset the function continues to do cleanup for the current I/O mode. For the suspend path (i3c_hci_rpm_suspend()), after software reset the function returns early. However software reset does not reset any Ring Headers in the Host Controller, so returning early is not the right thing to do. Instead, continue to call suspend for the current I/O mode, which for DMA mode will reset any Ring Headers. Note, although Ring Headers should not be active at this stage, performing this reset follows the procedure defined by the specification and keeps the suspend path consistent with the cleanup path. Note also, i3c_hci_sync_irq_inactive() is still called via the PIO and DMA hci->io->suspend() callbacks. Always return 0 because the device is quiesced as much as possible and returning a negative error code would unnecessarily prevent system suspend. Fixes: 9a258d1336f7 ("i3c: mipi-i3c-hci: Fallback to software reset when bus disable fails") Signed-off-by: Adrian Hunter --- Changes in V2: Always return 0 from suspend callback Amend commit message drivers/i3c/master/mipi-i3c-hci/core.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c index b781dbed2165..afb0764b5e1f 100644 --- a/drivers/i3c/master/mipi-i3c-hci/core.c +++ b/drivers/i3c/master/mipi-i3c-hci/core.c @@ -762,15 +762,10 @@ static int i3c_hci_reset_and_init(struct i3c_hci *hci) int i3c_hci_rpm_suspend(struct device *dev) { struct i3c_hci *hci = dev_get_drvdata(dev); - int ret; - ret = i3c_hci_bus_disable(hci); - if (ret) { - /* Fall back to software reset to disable the bus */ - ret = i3c_hci_software_reset(hci); - i3c_hci_sync_irq_inactive(hci); - return ret; - } + /* Fall back to software reset to disable the bus */ + if (i3c_hci_bus_disable(hci)) + i3c_hci_software_reset(hci); hci->io->suspend(hci); -- 2.51.0