From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0095339DBF3 for ; Tue, 21 Apr 2026 17:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776794102; cv=none; b=KwbjI7XnMsfd2a1Uj+9MD6oQk5zMby2BCYX1h26Nl/OvlI9vLKjHgqEH3peGcNeIWKd4RYQcmCZKZiv3AzREvtDtUzrxU1l6rI0CzS/LqoHNoWpHTHAeCl0ySLUCsHGUe+u+PiyudNnkByLJsLm+0nmFzsg8kJNC8b1JkRNjj30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776794102; c=relaxed/simple; bh=vIipsx5svp72kwB41kARwQF7UhLQmZOq5LWQKjJv/G4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UOjZXEcrJ95clnbGYBDpa82hOpSPxZ4bidcBHuKZDfAhccnw9fU0p8DsQLE4szEsPeUfD5AzH08iJdvf0H0l1NtURbRwGKZ4+TRLvPPEnaHEyIwtQju37ewhsCb3E5ZdASSvXmx1RIMqqeW0lsOdx9iHXyGYYgPMBapTwOvmb7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XzCNPzfJ; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XzCNPzfJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776794101; x=1808330101; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vIipsx5svp72kwB41kARwQF7UhLQmZOq5LWQKjJv/G4=; b=XzCNPzfJrSrdXLJhNxgrFU+hSdZuFui/GwBQwqYl+mXxUhkDh5LXe9ah EeIyVZa3fdmxVHZHKIMtMWa6+Mx0ADEEuwIL9iMQ/+zLpio2cwDYI3tRl TO5fxFCdASUh7fGYf2wq8dLKg1qoBWys23abNltYx5KMIQiMj/7JKmRnZ fR2eAA8RKrfLpUyfjuUHHX872vm2ebN6uwjIZM6rEh6dI2E1UKL9HmlWX VLgU3zd7HNdZtJnawxZDh6bFOxFuDkXwW0+mK+1cFDgO85rtIJUI3lUIA ymC007gEmtpCherr8XjfmJU4ve3RzObDxp5F6aURG8/FYKxQ6ZqzBf6im A==; X-CSE-ConnectionGUID: B/J/6H2HRS6RVMhAFOwCJQ== X-CSE-MsgGUID: lTZ0TjkhRK6ZZP9qEUAujg== X-IronPort-AV: E=McAfee;i="6800,10657,11763"; a="77651378" X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="77651378" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 10:55:00 -0700 X-CSE-ConnectionGUID: eU1ft4tfTLCQnme+Dw9g1Q== X-CSE-MsgGUID: WMopnoCQSW6wefY8Gr7FMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="227494921" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.242]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 10:54:59 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 07/16] i3c: mipi-i3c-hci: Complete transfer lists immediately on error Date: Tue, 21 Apr 2026 20:54:26 +0300 Message-ID: <20260421175435.122094-8-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260421175435.122094-1-adrian.hunter@intel.com> References: <20260421175435.122094-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit In DMA mode, transfer lists are currently completed only when the final transfer in the list completes. If an earlier transfer fails, the list is left incomplete and callers wait until timeout. There is no need to wait for a timeout, as the completion path in i3c_hci_process_xfer() already checks for error status. Complete the transfer list as soon as any transfer in the list reports an error. This avoids unnecessary delays and spurious timeouts on error. Complete a transfer list completion immediately there is an error. Signed-off-by: Adrian Hunter --- Changes in V2: Renamed completing_xfer to final_xfer drivers/i3c/master/mipi-i3c-hci/dma.c | 6 ++++-- drivers/i3c/master/mipi-i3c-hci/hci.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c index 28e4d38f55d3..899fdf6555a8 100644 --- a/drivers/i3c/master/mipi-i3c-hci/dma.c +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c @@ -502,6 +502,8 @@ static int hci_dma_queue_xfer(struct i3c_hci *hci, struct hci_xfer *xfer = xfer_list + i; u32 *ring_data = rh->xfer + rh->xfer_struct_sz * enqueue_ptr; + xfer->final_xfer = xfer_list + n - 1; + /* store cmd descriptor */ *ring_data++ = xfer->cmd_desc[0]; *ring_data++ = xfer->cmd_desc[1]; @@ -576,8 +578,8 @@ static void hci_dma_xfer_done(struct i3c_hci *hci, struct hci_rh_data *rh) tid, xfer->cmd_tid); /* TODO: do something about it? */ } - if (xfer->completion) - complete(xfer->completion); + if (xfer == xfer->final_xfer || RESP_STATUS(resp)) + complete(xfer->final_xfer->completion); if (RESP_STATUS(resp)) hci->enqueue_blocked = true; } diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h index d630400ec945..f07fc627d4d2 100644 --- a/drivers/i3c/master/mipi-i3c-hci/hci.h +++ b/drivers/i3c/master/mipi-i3c-hci/hci.h @@ -104,6 +104,7 @@ struct hci_xfer { struct { /* DMA specific */ struct i3c_dma *dma; + struct hci_xfer *final_xfer; int ring_number; int ring_entry; }; -- 2.51.0