From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f99.google.com (mail-oa1-f99.google.com [209.85.160.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A4F13D565F for ; Tue, 21 Apr 2026 19:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776800868; cv=none; b=J94dz2NrdA8c2ouMmaPJN6V8L+MPxHi7qexRTkFXBfQNIftO+DX/XG/8zYTzNGwGB3bC/0OKcZzfNS5fuD/q00XKaJY3d2Erp7EaWEX2nXdkdr+8EbjSIhi72ETQONtiYIOaWr/5uZFkfm68CgVK1JSDXwpAAVjY7T6wYJaB9Xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776800868; c=relaxed/simple; bh=4sNNErw2gAPyRIYm6TjTmGT/loyfw3iDZAk666ZzaU0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HqLDIpySf/x2Lr6kkCNOnjBIjmA0x4OhQrYPeBr71pzdHQbE1CZYg9poHwSYIdy93VlpgN7auouJhctX85bFkSXQ4iV1e1HAwlg3phJ1mEuez8tKIQE5HWWdaWHeo8oSIqoDR7OQVRJwnFblwfxgbUhrqabSFJ/VXdkBGzCeRJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=N+d3scJ8; arc=none smtp.client-ip=209.85.160.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="N+d3scJ8" Received: by mail-oa1-f99.google.com with SMTP id 586e51a60fabf-41574fa6a87so542963fac.3 for ; Tue, 21 Apr 2026 12:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1776800866; x=1777405666; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PczJzLTjB6v6Bolkhq/enF3XwnBjQpdRCoqwwfPNnM0=; b=N+d3scJ8HUCOFQkEfbWGpnQ8iq6sp0CEIPup8vni/H34SfzKGCDaHy1NPyHKZl2OeO xANSHcGMAAN1TV+8tl1ePD43Y/XqtP118JDvbPWaAXE9m7zGZVB+Z+ZoKc7883aXrh6f b+jnL0Pnpm3Se+b2171xAUhsOmT8jL5FCZ022qtEd/v+taUUeVDfmVRk/jQoXefMTtUN XYpUhpMcsNi/y608iK6kIfs2aS/pkw/wOiaajsCrmKMysvfN7WZNSsdC7j6vRMrsV6/x p4Q4pE6FtIhWyfEXqjPVnWO/xDU4hcXP1pWRSvYe/ngk3ydK7PMa88F1Mi4/GT5AX1Oh fPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776800866; x=1777405666; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PczJzLTjB6v6Bolkhq/enF3XwnBjQpdRCoqwwfPNnM0=; b=XFDrfb7TvwTZVZ6ZEW+pGvd2aXZkEHew46LpjhjciuRzJvhrwUazwUmrbh7/TGNCTS gfeiWSPkj73uP9u5kcPTI1V3qGOopfWCqK1QgJKeIdtzchoWwjt986TjTsvjR4Nbnoqt 51ROq9Zj9pl2SeIU7uGEsAJ16vHxVfKUW7V6R1+mq5xUiwgdEXZE6kdgrpIGcCSgxVHk PT3QVEPrT6inMPwZ83C5OYxS6T57tnvDOKcliZ1iyWDh1AQ8ZE04gdZagPeU1wi9zpDS AJxI78TS13/ZbOVkR4DZlBUCiTO1nGzrIb/OWQQzp7QkdY9F6ou9/yUWMj49dNmVdXkL W3Ow== X-Forwarded-Encrypted: i=1; AFNElJ9eHBfU4q9wMIX/XQVLeQYNylNQ4VfOaVvVXQsbQqUWPM9LBc1u5lRSWsV+mXa9zf9FAUVsrDiXALNA8TE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjy0t6yMKOeEDTx5PvaGODSZrbtWPOLZ2umUy0Ew3Lt3V4SX1P MAsRulmhtmbsGYCsuoM1xuZJ//UfFYIu0Htsk+N6rcPcE2FgQIRD1XnzHnVQvVF43b0g8Wc720b xQ+jV/VkCDniGLd41pqPHpFgIE7yrv/wPYjF/ X-Gm-Gg: AeBDieuYFH0lIFqj2C6iQo7kP/5DMYANPzJmZm3lmLffikyctvZLXugdPNiQ9jtgfkZ 7iSzmc/7qQoFkyhI5g7yIOj5pCPQqHZMxeWORr4GKIsu/aFwO/3iRk9fIUNrzg+5kGmErYliBxG rIUP3QKJ0ILVrksUs9AOU5fsJA8Qx4hQQK8lVf5ZPeRkuxQ2qHe6TzjnyKhuQKiPqbTF5sAEuAq dcHZhPyC0Y+pc6Ew6E0HW6OTpPeW7fVofGyebM1nio2DE0e2QXO+QCa4oz3lXLgG/vq8hvd657I vTWCjdgtrEohFBU7lq59s6LReX108DVhrzJRsZD2epeJhuEz3YWM8pPeYyhIok8HMHWJp0tOMKJ U/JS1GbtG33KXsDcEi718d78RMn91oPfD8L5vkHySl2KBGB3SUXL4shNamOvp9dCS X-Received: by 2002:a05:6871:d204:b0:417:1b7:5b9a with SMTP id 586e51a60fabf-42aded74a43mr7838417fac.6.1776800866257; Tue, 21 Apr 2026 12:47:46 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-42bd266b8d6sm822149fac.14.2026.04.21.12.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 12:47:46 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id D10F9340576; Tue, 21 Apr 2026 13:47:45 -0600 (MDT) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id BC38EE41A9F; Tue, 21 Apr 2026 13:47:45 -0600 (MDT) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe Cc: Caleb Sander Mateos , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ublk: optimize ublk_rq_has_data() Date: Tue, 21 Apr 2026 13:47:42 -0600 Message-ID: <20260421194744.1524637-1-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ublk_rq_has_data() currently uses bio_has_data(), which involves 2 indirections and several branches. Use blk_rq_bytes() instead, which performs a single indirection with no branches. Signed-off-by: Caleb Sander Mateos --- drivers/block/ublk_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index ef8a0705e68b..5f9b3c3876f4 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1172,11 +1172,11 @@ static inline struct ublk_queue *ublk_get_queue(struct ublk_device *dev, return dev->queues[qid]; } static inline bool ublk_rq_has_data(const struct request *rq) { - return bio_has_data(rq->bio); + return blk_rq_bytes(rq); } static inline struct ublksrv_io_desc * ublk_queue_cmd_buf(struct ublk_device *ub, int q_id) { -- 2.45.2