Re: [PATCH v3 1/6] rust: add warn_on_err macro

Alexandre Courbot
2026-05-01T06:13:29Z

On Fri May 1, 2026 at 12:22 AM JST, Danilo Krummrich wrote:
> On 4/30/26 5:11 PM, Alexandre Courbot wrote:
>> Thanks - I will send a separate patch for this shortly, and take it
>> alongside the Nova unload series if it can be reviewed quickly.
> Do we still need this? It goes away with the lifetime series.

Even after the lifetime series we still have this bit:

let _ = self
.gsp
.unload(pdev.as_ref(), self.bar, &self.gsp_falcon, &self.sec2_falcon)
.inspect_err(|e| dev_err!(pdev, "failed to unload GSP: {:?}\n", e));

where `warn_on_err` could apply, but it is definitely less essential.

However, since that pattern is likely to be common, I'd say it still
makes sense to merge it (albeit outside of this series).