Re: [PATCH V1 08/13] PCI: hv: rename hv_compose_msi_msg to hv_vmbus_compose_msi_msg

Mukesh R
2026-04-28T02:22:14Z

On 4/27/26 09:31, Bjorn Helgaas wrote:
> On Tue, Apr 21, 2026 at 07:32:34PM -0700, Mukesh R wrote:
>> Main change here is to rename hv_compose_msi_msg to
>> hv_vmbus_compose_msi_msg as we introduce hv_compose_msi_msg in upcoming
>> patches that builds MSI messages for both VMBus and non-VMBus cases. VMBus
>> is not used on baremetal root partition for example. While at it, replace
>> spaces with tabs and fix some formatting involving excessive line wraps.
>
> Would be better to do the whitespace changes in their own patch,
> although several of them should just be dropped (see below).
>
> Capitalize subject ("PCI: hv: Rename ...").
>
> Add "()" after function names in subject and commit log.

Ok, will do in next version.

>> +++ b/drivers/pci/controller/pci-hyperv.c
>> @@ -30,7 +30,7 @@
>> * function's configuration space is zero.
>> *
>> * The rest of this driver mostly maps PCI concepts onto underlying Hyper-V
>> - * facilities. For instance, the configuration space of a function exposed
>> + * facilities. For instance, the configuration space of a function exposed
>
> Oops, this hunk made it worse. Definitely don't want a tab there.
>
>> @@ -1954,7 +1955,7 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
>> return;
>> }
>> /*
>> - * The vector we select here is a dummy value. The correct
>> + * The vector we select here is a dummy value. The correct
>
> Another tab that should be a space. Actually, you should just drop
> this hunk; the rest of the comment has two spaces after periods, so
> this should too.

well, most of our files does global replace 8 spaces with tabs, so
everywhere comments are well indented. Since, checkpatch doesn't complain
about tabs on comment lines, may I assue it is not a strict requirement
and more a nit or personal preference?

Thanks,
-Mukesh

>> @@ -2046,7 +2047,7 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
>>
>> /*
>> * Make sure that the ring buffer data structure doesn't get
>> - * freed while we dereference the ring buffer pointer. Test
>> + * freed while we dereference the ring buffer pointer. Test
>
> Same here. This makes it worse.
>
>> @@ -2226,7 +2227,7 @@ static int hv_pcie_init_irq_domain(struct hv_pcibus_device *hbus)
>> /**
>> * get_bar_size() - Get the address space consumed by a BAR
>> * @bar_val: Value that a BAR returned after -1 was written
>> - * to it.
>> + * to it.
>
> Just put "to it" on the preceding line. There's plenty of space
> there.
>
>> @@ -2580,7 +2581,7 @@ static void q_resource_requirements(void *context, struct pci_response *resp,
>> * new_pcichild_device() - Create a new child device
>> * @hbus: The internal struct tracking this root PCI bus.
>> * @desc: The information supplied so far from the host
>> - * about the device.
>> + * about the device.
>
> Ditto. If you want to change this, put "about the device" on the
> preceding line.
>
>> @@ -3422,7 +3423,7 @@ static int hv_allocate_config_window(struct hv_pcibus_device *hbus)
>> * vmbus_allocate_mmio() gets used for allocating both device endpoint
>> * resource claims (those which cannot be overlapped) and the ranges
>> * which are valid for the children of this bus, which are intended
>> - * to be overlapped by those children. Set the flag on this claim
>> + * to be overlapped by those children. Set the flag on this claim
>
> Another hunk that should be dropped.