From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10ED328DC4 for ; Wed, 22 Apr 2026 04:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776833094; cv=none; b=tetSqUr48GnLY6lCOvoZLHm9tddbBrVaIvKdjdnKEM0kfEzMvNrrNROwXBJZRH020FrAHivkv8+yQKjKhuXSKCwkAZgCvGQWLJGCBvtrzoN4UGjDGVGHN57gocORUPMJow7nNwzpv8lNG+wym2QHeNLVe9UJYLUlx/0Yn78Jtp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776833094; c=relaxed/simple; bh=oOwDGIKkQYinZ6cEzj7x1hi+TEyEe7g2fiXeqCNMaws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bLXaUHsqksgpvT48Lvi5hP2/4pNf+ohd7PFmQBhCSe+3IgH/tUS4PwMNHBvQgFBV7zetVm/+pXYyZGxu/3Ma93ZZRsbaAA71owzCfWDBrstC/G+XevkSIt6M9jhJ4+kALbrgGnBAxHUDfkZXhCknujUnTxYFjCo0QipNnAasANk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82f4a53ae20so3754146b3a.3 for ; Tue, 21 Apr 2026 21:44:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776833092; x=1777437892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XhIDpGgSMmQPWhVlMLk1NWm+UmS94pEyHKaTl2QDpX0=; b=hkB+FVw+lbhVm3yIdMKpDpSAwFODkJ+ng72sxhF+hLaY40pPZC9oxrCv0wCSmX5iwh sjJYbEQSMYxI7uAzUED2+m+vf7Yq7VRYdETi1ZVVu4p3O+ey972JC/E2Svy3uzv/Lm94 +s3qh1PpkL+ia8yeCd3jsnPXZLU1dQJMVZcPDT6s/JCV45hQ5bWQSADOL7kv2krVgp8i 3D/j2Dh6BGPyPUGPzPWw8AtxuEBEKS2MT7a6WN62CFs+V9QMJQVGAhJfOjczhZGWfdxk 1D+NI/64TGtWaxAAARoUkONyw3TMvk1X0NYvWhIJrYnTWx747byucpd+I0p0mLfkadoK v9ew== X-Forwarded-Encrypted: i=1; AFNElJ9kyKmw/2SaSnwSnDGpqbsrV9LN1T5gwXYHcch8RQwYukE+ExX3TxxEDJv6aILCN00lYR5nCCUki4K1U6A=@vger.kernel.org X-Gm-Message-State: AOJu0YwiCZug4UsHe7w2KajmDa+HTJpipvftEduOEcDPtSal/4kuB8Eu NbeOC69Hw3XD0jAzyXXe7/EPbMM/GlaUkEUNbRphlv9YZxN26gqh0DFk X-Gm-Gg: AeBDiethBWYTWm5NfXzyS2z8LOYRQ9wc+HwPTjivToqsexZ+ZLBsbSPBdqssTibpn3j 0Ok3+GcuXObbMfbKNCQB8HqbPWtS5TslK/OC2EOlhbySlK0mwouKbTCuhsUnyMDs8G2H4Z7kR4f Hsh8vcqVbcvAmhlWK0UGk8a0bL4Mvi8lOQ/9myD6V4PMzYU31pjCWhEFRdAmGkBkOBZnuwT0vHK ne3vR5xVdyXd7n7sKVXSuKo4ljQuw3riRlYJLUV6/ztQlIMGmSBBqwtBwto962jVF98SYHq5LHb VrtsC8P1a8O0F7aNTWuvKnQ7pMl1pKx/KeqJLIitQd13j2eZ13026HB+/HhSa74VfRn9U4D2/Dm TpvLH1qPNXCOsP3Lh3ENdbufy+GwDIFJtTid41LkY2FQc8QPc6caOLoAmmmE1jIKXm0BHmAMl81 M8fqJ4Gm9lg8nPKE+AS29bx3kYjEF8wSzhpdHK3Q2G2PNm7mNOV3uGIZzPZZZqD9PUBe9PkLLb4 hPWy3c68T6f+jo3/tcrG4YIC7XGdqq42fqSVSa/XEEEqGA+jEG5tw2D3cVnCwQ9bDs7lhj9ZoaA eBEZ7VY/m7N3r8qOQOKTwHopG5d1krPVZA+0ft656A== X-Received: by 2002:a05:6a00:17a0:b0:82c:e0d7:2682 with SMTP id d2e1a72fcca58-82f8c8c8c5cmr22933258b3a.25.1776833092489; Tue, 21 Apr 2026 21:44:52 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d2f9asm16487176b3a.19.2026.04.21.21.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 21:44:51 -0700 (PDT) Date: Wed, 22 Apr 2026 13:44:50 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Ramesh Errabolu Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Bjorn Helgaas , Lukas Wunner , Niklas Schnelle , Peter Oberparleiter , Matthew Rosato , Gerd Bayer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev Subject: Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events Message-ID: <20260422044450.GA2544787@rocinante> References: <20260416213909.705753-1-ramesh@linux.ibm.com> <20260416213909.705753-2-ramesh@linux.ibm.com> <20260421171334.GA1684602@rocinante> <305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com> Hello, > > > +static struct pci_slot_attribute hotplug_slot_attr_uevent = { > > > + .attr = {.name = "uevent", .mode = S_IFREG | 0200}, > > > + .show = NULL, > > > + .store = uevent_write_file > > > +}; > > I think, you could use the __ATTR_WO() macro here. > Use of the suggested macro is not appropriate Just to expand on the "not appropriate" bit here. Not wanting to change the name to have the _store suffix would be fine. The __ATTR() would work here. But, this file is old and wanting to keep the style aligned with rest of it would be fine, too. So, both of these reasons would be fine, to avoid using any new macro. Thank you! Krzysztof