From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD1D6306D2A for ; Wed, 22 Apr 2026 07:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776844110; cv=none; b=GLj/EOO6jKdqJbH1rWdA0A6MrpAsxp106RvDXmFR6lj7jGFUfcQ/RUR20iP7avCKp8P0qzoJvl/txpqiIeWLVE7SVEAk2pYW9fCFbHTYIUt5e3wjeK2V3sjrsITAoZPhVQZUGZvikz/BU027MGLLyR9uZZ2tmL8N8z3ITuKJEWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776844110; c=relaxed/simple; bh=9QmZJk6nNP7BmBhjWjz5dh029aLvyN18dDwM1N0VeeE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PZlZMDkzX9mLRAGCywPRo6UnGwnt5tkmnNCFp5+5fBbXeP7K50H0kMP7kt1z5RwtVFw75JMqMmfO4zPwskpoGW/Riaag2ejJrubuRDwiYj4BtpiYbbaqrMOZPU0q+WJ/+djHssVueAka4rg+3ntVDSfEqsFYftBK44m12JtUk5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JE0e+G7k; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JE0e+G7k" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43d7e23defbso3248979f8f.0 for ; Wed, 22 Apr 2026 00:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776844107; x=1777448907; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=G30wgWfxQ2XefhTFiNX7NVklFXAUvDTePASFRoNn3hY=; b=JE0e+G7ksK1NunMu+sv8WFiEOZOuPBY7fKA5lM99Iu/WuE4OJA0gpJz42JyTZU0ZT/ /HXNGxjEeeYAtKvpIxMcHPFlCTkGLJLiI7oUB9AzM00TU3T8BBlpIsAgIlSBPbdVgHBK BjDpbI5VS2SJGtwA4TqVTI1aENvCj2Ji5wg6GnsDtn9IxNsu07Fgt1Y/mhN4F7Zb0uhb N9MjwGxQ0fWt99J9eR1B4grZ6hWSx8GJclXESnTpSjZ8292DrdXxEU/ZifMyoCA1DCXN qAT2ESbjUHVGb9TAVgUDoXTji5jxma3q1cGuI6dBXh6E26cV9CTc6pjsk3/qSjM379Sj fiUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776844107; x=1777448907; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G30wgWfxQ2XefhTFiNX7NVklFXAUvDTePASFRoNn3hY=; b=g5NRBW1PKwlZafdL62azn6cJtiy6krbii3HWMw1hLf03ZJM5tTxoEavFqtKcQx5KgW TNIgTf+xrTVg1tk3LJNObq1iNdmNBCbsD3iNyvy7/i8PZImwLZCipB7fEciPkvTYfJVE xjrpX5Q8ZuhtrVtxsj6J8VDCeQOfhYfrnVFdsrkkPGu8R8EnO3OsMKZtAEJJKj64epUT 2hTO51SluPjQpZusJCrDlVe1bGQwnODIarQ1K2d57KT3hpje/Jogpvzk4k45pcNjGJkD G+xXKtMDbIogad43dwV7EQSWLTJrl9C1bPj9y2lJYt8SgVXtjCAVCaEZXoXsEXNJbJkx I1aA== X-Forwarded-Encrypted: i=1; AFNElJ9UOsV4RAUqLxfNlu25zY5AfRcRUYMyqxx9qI0dZBvxk18imriL6NQ5UHPT6oOY5fkmlKGTwZezRiGvAz0=@vger.kernel.org X-Gm-Message-State: AOJu0YzUCgYKuaQYdoeHS+Ok0Fj1Y8yia/K7I4bgTjC4Y88qp2epsfn8 YFB+B/XFnVl1zdNlPJWUb9O9b6smcvlUbcdOlJP+OoSrKgrdVfKqseq6hyXrkQ== X-Gm-Gg: AeBDievjA9n9emxEBoirKr+34o+CHaew2IpOngZZg+wYYaqpGuU6v2YTDRDS5AXCGOB fOBqhCRZOj1G9dtnJkitBCUsBDXgvVqNUvEfRC42ZZJLBevcc8yhZNP/TlbjbAjBo5viknusA8e 2RYZH897E2ci5qo2eR1baLHb62z8qZNc59mos+Gaymh77sC6mpv4DNTLVwQhkCRMuZmDsuOMVbj DG4myA5pUUWuLDzU3ipoaP11A6Blk+STQaIzYc0nhCDTTuOlZ1UWRjc+xIIEMAah6uIdqiheudB tKmZFcpBAZJoBzZPQwFaNj/qUKzqzNX8HmmVBX8DZBH5d0eQI8sTJKUt7rrOV/pdnCFcOz4Ijlj 9vJgCN8eFUBfnwWzveUavzHIvSCLJFU5M7ZH2ES+m5uzW0am5YHHhLczayu2eE2Vqq3SP1yJvzX rmnDVFEfQxPuDW9nwdn0RcDHwKTNTFulJ05Ez3/HqnpxKyzoRifA== X-Received: by 2002:a05:6000:1a8d:b0:43b:8806:be32 with SMTP id ffacd0b85a97d-43fe3db3b49mr31960085f8f.7.1776844107067; Wed, 22 Apr 2026 00:48:27 -0700 (PDT) Received: from egonzo (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e46898sm45476509f8f.27.2026.04.22.00.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 00:48:26 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Dave Penkler Subject: [PATCH] gpib: Suppress setting END on error from NI_USB dongle Date: Wed, 22 Apr 2026 09:48:07 +0200 Message-ID: <20260422074807.3194-1-dpenkler@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The NI USB adapter sets the END bit in the status word when an error occurs such as a read being interrupted by the setting of ATN. This happens for example when a device clear is received from the controller in charge during a read. The common driver changes the error return to 0 whenever the END bit is set in order to avoid errors such as timeout or interrupt to be reported after the full message has actually been read. The behaviour of the NI USB adapter in setting the END bit on errors was causing actual errors (-EINTR, -ETIMEDOUT) not to be reported. We avoid setting the END bit in the ni_usb_gpib driver when an error is reported in error_code of the status from the adaptor. Signed-off-by: Dave Penkler --- drivers/gpib/ni_usb/ni_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb_gpib.c index a24cd6521362..b1f63c81c259 100644 --- a/drivers/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c @@ -720,7 +720,7 @@ static int ni_usb_read(struct gpib_board *board, u8 *buffer, size_t length, break; } ni_usb_soft_update_status(board, status.ibsta, 0); - if (status.ibsta & END) + if ((status.ibsta & END) && (status.error_code == NIUSB_NO_ERROR)) *end = 1; else *end = 0; -- 2.53.0