From: Joshua Crofts <joshua.crofts1@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: [PATCH v3 5/6] iio: magnetometer: ak8975: fix wrong errno on return
Date: Wed, 22 Apr 2026 11:22:06 +0000 [thread overview]
Message-ID: <20260422112207.1313-6-joshua.crofts1@gmail.com> (raw)
In-Reply-To: <20260422112207.1313-1-joshua.crofts1@gmail.com>
The driver currently returns -EINVAL on polling timeout instead of
-ETIMEDOUT.
Replace return code for -ETIMEDOUT and remove unnecessary error message
as error is described enough by error code.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
drivers/iio/magnetometer/ak8975.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index bceab47e5af..723c2f64b8e 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -662,10 +662,8 @@ static int wait_conversion_complete_gpio(struct ak8975_data *data)
break;
timeout_ms -= AK8975_CONVERSION_DONE_POLL_TIME;
}
- if (!timeout_ms) {
- dev_err(&client->dev, "Conversion timeout happened\n");
- return -EINVAL;
- }
+ if (!timeout_ms)
+ return -ETIMEDOUT;
ret = i2c_smbus_read_byte_data(client, data->def->ctrl_regs[ST1]);
if (ret < 0)
@@ -695,10 +693,8 @@ static int wait_conversion_complete_polled(struct ak8975_data *data)
break;
timeout_ms -= AK8975_CONVERSION_DONE_POLL_TIME;
}
- if (!timeout_ms) {
- dev_err(&client->dev, "Conversion timeout happened\n");
- return -EINVAL;
- }
+ if (!timeout_ms)
+ return -ETIMEDOUT;
return read_status;
}
--
2.47.3
next prev parent reply other threads:[~2026-04-22 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 11:22 [PATCH v3 0/6] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts
2026-04-22 11:22 ` [PATCH v3 1/6] iio: magnetometer: ak8975: sort headers alphabetically Joshua Crofts
2026-04-22 11:22 ` [PATCH v3 2/6] iio: magnetometer: ak8975: remove unused headers Joshua Crofts
2026-04-24 17:58 ` Jonathan Cameron
2026-04-24 18:12 ` Joshua Crofts
2026-04-22 11:22 ` [PATCH v3 3/6] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts
2026-04-22 11:22 ` [PATCH v3 4/6] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts
2026-04-22 11:22 ` Joshua Crofts [this message]
2026-04-22 13:13 ` [PATCH v3 5/6] iio: magnetometer: ak8975: fix wrong errno on return Andy Shevchenko
2026-04-22 13:27 ` Joshua Crofts
2026-04-22 11:22 ` [PATCH v3 6/6] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts
2026-04-22 13:16 ` [PATCH v3 0/6] iio: magnetometer: ak8975: modernize and cleanup driver Andy Shevchenko
2026-04-22 13:20 ` Joshua Crofts
2026-04-24 8:23 ` Joshua Crofts
2026-04-24 10:18 ` Andy Shevchenko
2026-04-24 10:23 ` Joshua Crofts
2026-04-24 18:02 ` Jonathan Cameron
2026-04-24 18:15 ` Joshua Crofts
2026-04-27 20:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422112207.1313-6-joshua.crofts1@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox